Re: clang Warning: Padding Class...

2020-02-20 Thread Scott Kostyshak
On Thu, Feb 20, 2020 at 01:51:24AM -0500, Richard Kimberly Heck wrote: > On 2/19/20 9:56 PM, Scott Kostyshak wrote: > > On Wed, Feb 19, 2020 at 05:08:47PM -0500, Richard Kimberly Heck wrote: > > > >> On 2/19/20 4:48 PM, Jean-Marc Lasgouttes wrote: > >>> It is a good idea to have correct padding by

Re: clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 9:56 PM, Scott Kostyshak wrote: > On Wed, Feb 19, 2020 at 05:08:47PM -0500, Richard Kimberly Heck wrote: > >> On 2/19/20 4:48 PM, Jean-Marc Lasgouttes wrote: >>> It is a good idea to have correct padding by reordering members, even if >>> the memory gains are minimal for buffer::impl .

Re: clang Warning: Padding Class...

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 05:08:47PM -0500, Richard Kimberly Heck wrote: > On 2/19/20 4:48 PM, Jean-Marc Lasgouttes wrote: > > It is a good idea to have correct padding by reordering members, even if > > the memory gains are minimal for buffer::impl . Do you have that for other > > classes ? > >

Re: clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
> > Le 19 février 2020 21:24:15 GMT+01:00, Richard Kimberly Heck a écrit : >> I'm seeing a lot of warnings in QtCreator of the form: >> >> Buffer.cpp:219:11: warning: padding class 'lyx::Buffer::Impl' with 3 >> bytes to align 'filename' >> >> I take it that this is because there were five bools ri

Re: clang Warning: Padding Class...

2020-02-19 Thread Jean-Marc Lasgouttes
It is a good idea to have correct padding by reordering members, even if the memory gains are minimal for buffer::impl . Do you have that for other classes ? Note that padding needs are not the same for 32bist and 64bits, and probably not the same for Linux and windows. JMarc Le 19 février 202

clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
I'm seeing a lot of warnings in QtCreator of the form: Buffer.cpp:219:11: warning: padding class 'lyx::Buffer::Impl' with 3 bytes to align 'filename' I take it that this is because there were five bools right before this declaration. Do we care about this? Riki -- lyx-devel mailing list lyx-d