Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-27 Thread Abdelrazak Younes
Stephan Witt wrote: Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Do you need a new patch from me or will you change it yourself? No, that's fine, I'll do it. Thank you! You are welcome. Please send a message to

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-27 Thread Stephan Witt
Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Do you need a new patch from me or will you change it yourself? No, that's fine, I'll do it. Thank you! You are welcome. Please send a message to this list stating th

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-27 Thread Abdelrazak Younes
Stephan Witt wrote: Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Do you need a new patch from me or will you change it yourself? No, that's fine, I'll do it. Thank you! You are welcome. Please send a message to this list stating the following: I granted pe

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-27 Thread Stephan Witt
Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: Do you need a new patch from me or will you change it yourself? No, that's fine, I'll do it. Thank you! You are welcome. Please send a message to this list stating the following: I granted permission already in 20

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-27 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: José Matos wrote: With Jürgen coming soon I will let this decision to him. :-) So apart from style issues (that are easily fixed) this patch can go in devel. :-) OK for branch as well, if Abdel's testing revealed no problems. No problem on Windows too so I just c

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-26 Thread Abdelrazak Younes
Stephan Witt wrote: Abdelrazak Younes schrieb: Do you need a new patch from me or will you change it yourself? No, that's fine, I'll do it. Thank you! You are welcome. Please send a message to this list stating the following: I grant permission to license any and all contributions I've ma

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-26 Thread Stephan Witt
Abdelrazak Younes schrieb: Stephan Witt wrote: Abdelrazak Younes schrieb: I am OK with the patch but I would like to know first if there are any drawbacks, I am not on X11. I tested this patch with Qt 4.1.2 and it is working without drawbacks. AFAIK older Qt versions are not supported anymore

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-25 Thread Jürgen Spitzmüller
José Matos wrote: > With Jürgen coming soon I will let this decision to him. :-) > >   So apart from style issues (that are easily fixed) this patch can go in > devel. :-) OK for branch as well, if Abdel's testing revealed no problems. Jürgen

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread José Matos
On Friday 24 August 2007 12:57:23 Abdelrazak Younes wrote: > Jose, do you want it for 1.5? With Jürgen coming soon I will let this decision to him. :-) So apart from style issues (that are easily fixed) this patch can go in devel. :-) > Abdel. -- José Abílio

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread Andre Poenitz
On Fri, Aug 24, 2007 at 10:43:09AM +0200, Stephan Witt wrote: > I'll provide a modified patch when there is a need for. > Do you want the "if (sm.allowsInteraction()) {" style? Yes. Even if it's not everyones favourite it is very beneficial to have a uniform style to be able to do certain kinds o

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread Abdelrazak Younes
Stephan Witt wrote: Abdelrazak Younes schrieb: I am OK with the patch but I would like to know first if there are any drawbacks, I am not on X11. I tested this patch with Qt 4.1.2 and it is working without drawbacks. AFAIK older Qt versions are not supported anymore were I had problems with t

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread Stephan Witt
Abdelrazak Younes schrieb: Stephan Witt wrote: Andre Poenitz schrieb: On Tue, Aug 21, 2007 at 10:31:57AM +0200, Stephan Witt wrote: // X11 specific stuff goes here... #ifdef Q_WS_X11 + +void GuiApplication::commitDat

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread Abdelrazak Younes
Stephan Witt wrote: Andre Poenitz schrieb: On Tue, Aug 21, 2007 at 10:31:57AM +0200, Stephan Witt wrote: // X11 specific stuff goes here... #ifdef Q_WS_X11 + +void GuiApplication::commitData(QSessionManager & sm) +{ +

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-24 Thread Stephan Witt
Andre Poenitz schrieb: On Tue, Aug 21, 2007 at 10:31:57AM +0200, Stephan Witt wrote: // X11 specific stuff goes here... #ifdef Q_WS_X11 + +void GuiApplication::commitData(QSessionManager & sm) +{ + /// The implemen

Re: [patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-21 Thread Andre Poenitz
On Tue, Aug 21, 2007 at 10:31:57AM +0200, Stephan Witt wrote: > > // X11 specific stuff goes here... > #ifdef Q_WS_X11 > + > +void GuiApplication::commitData(QSessionManager & sm) > +{ > + /// The implementation is requ

[patch for [Bug 1656] command "gnome-session-save" kills lyx!]

2007-08-21 Thread Stephan Witt
Hi Richard, you moved the target milestone of bug 1656 to 1.5.x. Now I had the time and energy to check my proposal to fix the bug again. I modified the code to fit the new 1.5.x code base. My tests with OpenSuSE 10.2 and Qt 4.1.2 went well. The program isn't exiting prematurely anymor

Re: bug 1656

2005-11-28 Thread Stephan Witt
Stephan Witt wrote: Jean-Marc Lasgouttes wrote: Last weekend I did some further investigation. 1. Checking the behaviour of kwrite it opens a question box to save the changes when it gets the focus... Hm... when it is iconized or on another desktop it doesn't ask? Really strange. 2. Checking

Re: bug 1656

2005-11-28 Thread Stephan Witt
Jean-Marc Lasgouttes wrote: "Stephan" == Stephan Witt <[EMAIL PROTECTED]> writes: Stephan> as promised yesterday I did some testing today. Thanks. Stephan> With the patch the unsaved changes remains unsaved. Without Stephan> the patch I was asked to save the changes. So far seems all Stephan

Re: bug 1656

2005-11-25 Thread Jean-Marc Lasgouttes
> "Stephan" == Stephan Witt <[EMAIL PROTECTED]> writes: Stephan> as promised yesterday I did some testing today. Thanks. Stephan> With the patch the unsaved changes remains unsaved. Without Stephan> the patch I was asked to save the changes. So far seems all Stephan> well, Is this really w

Re: bug 1656

2005-11-25 Thread Stephan Witt
Jean-Marc Lasgouttes wrote: "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1656 Shouldn't this Juergen> patch be applied? Personally, I don't get the described Juergen> patch, but Martin has confirmed that the problem is solved by

Re: bug 1656

2005-11-24 Thread Stephan Witt
Jean-Marc Lasgouttes wrote: "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1656 Shouldn't this Juergen> patch be applied? Personally, I don't get the described Juergen> patch, but Martin has confirmed that the problem is solved by

Re: bug 1656

2005-11-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1656 Shouldn't this Juergen> patch be applied? Personally, I don't get the described Juergen> patch, but Martin has confirmed that the problem is solved by Juergen> the patch. The

Re: bug 1656

2005-11-24 Thread Stephan Witt
Juergen Spitzmueller wrote: http://bugzilla.lyx.org/show_bug.cgi?id=1656 Shouldn't this patch be applied? Personally, I don't get the described patch, but Martin has confirmed that the problem is solved by the patch. Jürgen Just in case nobody knows... I have no karma to apply it. Stephan

bug 1656

2005-11-24 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1656 Shouldn't this patch be applied? Personally, I don't get the described patch, but Martin has confirmed that the problem is solved by the patch. Jürgen

Re: [Bug 1656] command "gnome-session-save" kills lyx!

2005-07-22 Thread Stephan Witt
Hello Lars, > You had a simple fix that avoids the crash, didn't you Stephan? yes I have. Yesterday I came back to Berlin and since today I'm online again... After a vacation of 2 weeks I have to do some real work. But I'll provide the patch shortly. In Paris I failed to compile the patched ve