Jean-Marc Lasgouttes wrote:
> Yes, it is OK, although the FormPreference changes seem to be bogus
> and in #if 0 code.
I know, but since I removed every occurence of 'none' I wanted to make sure
that the code would still work if it would ever be put outside the #if 0
again.
Georg
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> See this patch. The only difference to the 1.5 version is that
Georg> "none" can still be read, but configure.py does not produce
Georg> "none" anymore. OK to go in? It has no status.14x entry on
Georg> purpose.
Yes, it is OK, althoug
Am Donnerstag, 25. Mai 2006 13:54 schrieb Georg Baum:
> Am Montag, 22. Mai 2006 10:55 schrieb Jean-Marc Lasgouttes:
> > It looks good. I still think that adding this not_founf='auto' cruft
> > all over is less readable than having a checkViewer helper function :)
>
> Of course you are right. This
Am Montag, 22. Mai 2006 10:55 schrieb Jean-Marc Lasgouttes:
> It looks good. I still think that adding this not_founf='auto' cruft
> all over is less readable than having a checkViewer helper function :)
Of course you are right. This is going in trunk right now, the 1.4 version
will follow soon.
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Am Samstag, 20. Mai 2006 19:32 schrieb Jean-Marc Lasgouttes:
>> Can't we get rid of 'none', since it is equivalent to empty?
Georg> Sure (but for 1.4 I would only remove it from configure.py, not
Georg> from the reading code). I guess
Am Samstag, 20. Mai 2006 19:32 schrieb Jean-Marc Lasgouttes:
> Can't we get rid of 'none', since it is equivalent to empty?
Sure (but for 1.4 I would only remove it from configure.py, not from the
reading code). I guess 'none' was only used because comparisons with
empty strings can be difficul
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Here is a variant of it. Your patch still did the
Georg> windows/non-windows distinction that we don't want. Bo, can you
Georg> please test whether it works?
Georg> Jean-Marc, can it go in 1.5 and 1.4 if it works?
Can't we get rid of
Am Samstag, 20. Mai 2006 17:48 schrieb Bo Peng:
> So, you basically want to use 'auto' for not-found viewers, and
> 'none' for not-found converters. Right?
Yes.
Georg
> I have not checked the details, but my 'final patch' did just that.
> Change '' to 'none', add things like 'auto'.
So, you basically want to use 'auto' for not-found viewers, and
'none' for not-found converters. Right?
Bo
Am Freitag, 19. Mai 2006 18:19 schrieb Bo Peng:
> > I thought about doing that at first. Then I read checkProg in
> > configure.py and decided I'd rather not touch it. I am not brave
> > enough.
python is friendly to its users, don't fear ;-)
> I have not checked the details, but my 'final patch'
Georg> I think that configure.py should write "auto" if no
Georg> viewer/editor was found and it was not explicitly requested
Georg> that it should be empty (as needed for the lyx13x format).
Georg> "none" should be equivalent to "" as it was, and "auto" should
Georg> be replaced in fixCommand() b
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> I think that configure.py should write "auto" if no
Georg> viewer/editor was found and it was not explicitly requested
Georg> that it should be empty (as needed for the lyx13x format).
Georg> "none" should be equivalent to "" as it was
When I was updating my patch to add a 'document' flag to the formats in
order to get rid of the hardcoding in MenuBackend.C, I also wrote the
documentation for it and for the autoview feature in Customization.lyx.
I had a closer look at the autoview logic in configure.py and format.C,
and it is
13 matches
Mail list logo
