Re: assorted metrics bugs

2007-08-31 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> A neat trick by Andre, look at MetricsInfo.h. You build an object that >> restores the old value on destruction. I'm not sure it is worth it, just >> because makes a simple thing slightly more obscure. Probably it is >> sufficient to put modifications of the MetricsInfo

Re: assorted metrics bugs

2007-08-31 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: (maybe it should be better to use Changers to avoid this kind of problems?) Changers? A neat trick by Andre, look at MetricsInfo.h. You build an object that restores the old value on destruction. I'm not sure it is worth it, just because mak

Re: assorted metrics bugs

2007-08-31 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> (maybe it should be better to use Changers to avoid this kind of >> problems?) > > Changers? A neat trick by Andre, look at MetricsInfo.h. You build an object that restores the old value on destruction. I'm not sure it is worth it, just because makes a simple thing sl

Re: assorted metrics bugs

2007-08-31 Thread Abdelrazak Younes
Alfredo Braunstein wrote: This fixes a bug in InsetCollapsable::metrics, where textwidth was not restored 2 bugs in InsetCaption::metrics - textwidth was not restored Yes, I suspected something like this. - remove an extra metrics call Good! (maybe it should be better

assorted metrics bugs

2007-08-31 Thread Alfredo Braunstein
This fixes a bug in InsetCollapsable::metrics, where textwidth was not restored 2 bugs in InsetCaption::metrics - textwidth was not restored - remove an extra metrics call (maybe it should be better to use Changers to avoid this kind of problems?) Abdel or Martin you are the p