Re: XworkArea keyboard handler

2002-12-09 Thread Angus Leeming
On Monday 09 December 2002 5:36 pm, Lars Gullik Bjønnes wrote: > I think you are farily right on, I am only wondering a bit about the > > | These two calls contain the same information, but processing of > | (int(buffer[0]), xev) is unnecessarily complex. In fact, > | int(buffer[0]) == keysym

Re: XworkArea keyboard handler

2002-12-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | It looks like there are three bugs in xforms key event handling. Two have | trivial solutions and one will require more work. > | Minor 1. When composing, fl_XLookupString(xev, ... &keysym, ...) returns | (keysym == 0). xforms should "swallow" this eve

Re: XworkArea keyboard handler

2002-12-09 Thread Angus Leeming
On Monday 09 December 2002 4:30 pm, Lars Gullik Bjønnes wrote: > | (Am I right here? passing a KeyRelease event to > | fl_XLookupString((XKeyEvent *)xev, ..., &keysym, ...) > | is pointless?) > > no... Good. Then do_keyboard is right in this regard. > | However, fl_handle_form does NOT proces

Re: XworkArea keyboard handler

2002-12-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Monday 09 December 2002 3:06 pm, Lars Gullik Bjønnes wrote: >> My plan was/is to remove a lot of these when we get separate KEY_PRESS >> and KEY_RELEASE events, this has not been true with 0.88 and 0.89 (not >> sure how 1.0 behaves in this respect). >

Re: XworkArea keyboard handler

2002-12-09 Thread Angus Leeming
On Monday 09 December 2002 3:06 pm, Lars Gullik Bjønnes wrote: > My plan was/is to remove a lot of these when we get separate KEY_PRESS > and KEY_RELEASE events, this has not been true with 0.88 and 0.89 (not > sure how 1.0 behaves in this respect). Ummm. Well, xforms /receives/ separate events fr

Re: XworkArea keyboard handler

2002-12-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars, why do you leave these vars last_time_pressed, last_key_pressed and | last_state_pressed uninitialised before you use them for the first time? > | Should they not be: | static Time last_time_pressed = 0; | static unsigned int last_key_

Re: XworkArea keyboard handler

2002-12-09 Thread Angus Leeming
On Monday 09 December 2002 3:03 pm, José Matos wrote: > On Monday 09 December 2002 15:03, Angus Leeming wrote: > > Lars, why do you leave these vars last_time_pressed, last_key_pressed and > > last_state_pressed uninitialised before you use them for the first time? > > This bit I think I know. I

Re: XworkArea keyboard handler

2002-12-09 Thread José Matos
On Monday 09 December 2002 15:03, Angus Leeming wrote: > Lars, why do you leave these vars last_time_pressed, last_key_pressed and > last_state_pressed uninitialised before you use them for the first time? This bit I think I know. If they are static they are initialized to zero automatically. :

XworkArea keyboard handler

2002-12-09 Thread Angus Leeming
Lars, why do you leave these vars last_time_pressed, last_key_pressed and last_state_pressed uninitialised before you use them for the first time? Should they not be: static Time last_time_pressed = 0; static unsigned int last_key_pressed = 0; static unsigned int last_stat