Re: Wrap figure patch to CVS contains mistake

2002-09-25 Thread R. Lahaye
Dekel Tsur wrote: > On Wed, Sep 25, 2002 at 09:29:16PM +0900, R. Lahaye wrote: > >>Today you've committed a patch to "forms/form_wrap.fd" and "FormWrap.C". >>You replaced inner by Outer, but now the dialog interface has lost >>its logic, because the Default also says "outer": >> >> o Left >>

Re: Wrap figure patch to CVS contains mistake

2002-09-25 Thread Dekel Tsur
On Wed, Sep 25, 2002 at 09:29:16PM +0900, R. Lahaye wrote: > Today you've committed a patch to "forms/form_wrap.fd" and "FormWrap.C". > You replaced inner by Outer, but now the dialog interface has lost > its logic, because the Default also says "outer": > >o Left >o Right >o Outer >

Re: Wrap figure patch to CVS contains mistake

2002-09-25 Thread John Levon
On Wed, Sep 25, 2002 at 09:29:16PM +0900, R. Lahaye wrote: > We could merge this placement dialog, with the placement dialog > for regular float, for example, and handle it from there. fwiw, I think this would be beetter UI too, but we have to be careful about the complexity of the float dialog

Wrap figure patch to CVS contains mistake

2002-09-25 Thread R. Lahaye
Dekel, Today you've committed a patch to "forms/form_wrap.fd" and "FormWrap.C". You replaced inner by Outer, but now the dialog interface has lost its logic, because the Default also says "outer": o Left o Right o Outer o Default (outer) Maybe the last entry should be "o Inner