Re: Don't record (de)activating change tracking on undo stack

2023-12-01 Thread Daniel
On 2023-11-30 17:46, Lorenzo Bertini wrote: Il giorno gio 30 nov 2023 alle ore 15:47 Jean-Marc Lasgouttes ha scritto: Le 30/11/2023 à 03:01, Daniel a écrit : LyX has the peculiarity of treating the (de)activating of change tracking as something that is recorded on the undo stack. Actually

Re: Don't record (de)activating change tracking on undo stack

2023-11-30 Thread Lorenzo Bertini
Il giorno gio 30 nov 2023 alle ore 15:47 Jean-Marc Lasgouttes ha scritto: > > Le 30/11/2023 à 03:01, Daniel a écrit : > > LyX has the peculiarity of treating the (de)activating of change > > tracking as something that is recorded on the undo stack. > > Actually, everythi

Re: Don't record (de)activating change tracking on undo stack

2023-11-30 Thread Jean-Marc Lasgouttes
Le 30/11/2023 à 03:01, Daniel a écrit : LyX has the peculiarity of treating the (de)activating of change tracking as something that is recorded on the undo stack. Actually, everything that is stored in the file goes to the undo stack. I do not see how to avoid that. One of the problems I

Don't record (de)activating change tracking on undo stack

2023-11-29 Thread Daniel
LyX has the peculiarity of treating the (de)activating of change tracking as something that is recorded on the undo stack. One of the problems I ran into with this is that it unexpectedly killed the redo function when I activated change tracking, i.e. I undid some changes and activated the

Re: BufferParams and Undo Stack

2008-07-10 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck <[EMAIL PROTECTED]> writes: OK, well, this may not be a huge issue, but looking closely at the Undo code, it is noticeable that we are creating a copy of the BufferParams for every undo operation, although---as the code says---this information is only USED

Re: BufferParams and Undo Stack

2008-07-10 Thread Jean-Marc Lasgouttes
rgheck <[EMAIL PROTECTED]> writes: > OK, well, this may not be a huge issue, but looking closely at the > Undo code, it is noticeable that we are creating a copy of the > BufferParams for every undo operation, although---as the code > says---this information is only USED for full-document operatio

BufferParams and Undo Stack

2008-07-09 Thread rgheck
OK, well, this may not be a huge issue, but looking closely at the Undo code, it is noticeable that we are creating a copy of the BufferParams for every undo operation, although---as the code says---this information is only USED for full-document operations. So that seems like a waste of memo

Re: Undo stack

2003-11-06 Thread Alfredo Braunstein
Kornel Benko wrote: > Wow. Thanks. > Unfortunately, both errors have gone, therefore no more reports :) > I have to end this thread. Such a pity. ;-) > Now, there is new error, related maybe to lyx2lyx ... I am trying to > provide a minimal lyx-file in a new thread. > > Your last provided patc

Re: Undo stack

2003-11-06 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Mittwoch, 5. November 2003 22:29, Alfredo Braunstein wrote: > Hi Kornel, > > Kornel Benko wrote: > > I have one more. While searching for undo I found, that > > deleting Title in this file crashes lyx too. > > > > 1.) Open file > > 2.) Move cursor to title-sta

Re: Undo stack

2003-11-05 Thread Alfredo Braunstein
Hi Kornel, Kornel Benko wrote: > I have one more. While searching for undo I found, that > deleting Title in this file crashes lyx too. > > 1.) Open file > 2.) Move cursor to title-start > 3.) delete title > 4.) move cursor -> crash I'm bored today ;-). Regards, Alfredo Btw, excellent report

Re: Undo stack

2003-11-04 Thread Alfredo Braunstein
Andre Poenitz wrote: > Hm... comment it out and put a warning there. I'll have a look again > later. Done. Alfredo

Re: Undo stack

2003-11-03 Thread Andre Poenitz
On Tue, Nov 04, 2003 at 01:26:09AM +, John Levon wrote: > On Mon, Nov 03, 2003 at 10:05:21PM +0100, Kornel Benko wrote: > > > What is "DESM"? Google --> "commonly used anatomic prefix for > > terms which relate to the ligaments." > > It's certainly a pain in one anatomical area Just o

Re: Undo stack

2003-11-03 Thread Andre Poenitz
On Mon, Nov 03, 2003 at 09:44:35PM +0100, Alfredo Braunstein wrote: > Kornel Benko wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > > > cvs from today. > > I have tried to make a minimal lyx-example for the undo crash. > > 1.) Select some text inside the enumarated part > > 2.) type any text >

Re: Undo stack

2003-11-03 Thread John Levon
On Mon, Nov 03, 2003 at 10:05:21PM +0100, Kornel Benko wrote: > What is "DESM"? > Google --> "commonly used anatomic prefix for terms which relate to the > ligaments." It's certainly a pain in one anatomical area john -- Khendon's Law: If the same point is made twice by the same pe

Re: Undo stack

2003-11-03 Thread Alfredo Braunstein
Kornel Benko wrote: > What is "DESM"? > Google --> "commonly used anatomic prefix for terms which relate to the > ligaments." DEPM = "Delete empty paragraph mechanism". Delete also double spaces. As at some point in time John planned to split the "delete double spaces" thing from the "delete e

Re: Undo stack

2003-11-03 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 3. November 2003 21:46, Alfredo Braunstein wrote: > Kornel Benko wrote: > > > I have one more. While searching for undo I found, that > > deleting Title in this file crashes lyx too. > > > > 1.) Open file > > 2.) Move cursor to title-start > > 3.) de

Re: Undo stack

2003-11-03 Thread Alfredo Braunstein
Kornel Benko wrote: > I have one more. While searching for undo I found, that > deleting Title in this file crashes lyx too. > > 1.) Open file > 2.) Move cursor to title-start > 3.) delete title > 4.) move cursor -> crash > > Kornel This is DESM. As I hate DESM, I will leave it to someone else

Re: Undo stack

2003-11-03 Thread Alfredo Braunstein
Kornel Benko wrote: > -BEGIN PGP SIGNED MESSAGE- > > cvs from today. > I have tried to make a minimal lyx-example for the undo crash. > 1.) Select some text inside the enumarated part > 2.) type any text > 3.) undo it > 4.) undo once again -> command not! disabled, -> crash This is the p

Re: Undo stack

2003-11-03 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 3. November 2003 20:08, Alfredo Braunstein wrote: > Kornel Benko wrote: > > > cvs from today. > > I have tried to make a minimal lyx-example for the undo crash. > > 1.) Select some text inside the enumarated part > > 2.) type any text > > 3.) undo it

Re: Undo stack

2003-11-03 Thread Alfredo Braunstein
Kornel Benko wrote: > cvs from today. > I have tried to make a minimal lyx-example for the undo crash. > 1.) Select some text inside the enumarated part > 2.) type any text > 3.) undo it > 4.) undo once again -> command not! disabled, -> crash > > Kornel Thanks Kornel! I will look into it. Alfr

Undo stack

2003-11-03 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- cvs from today. I have tried to make a minimal lyx-example for the undo crash. 1.) Select some text inside the enumarated part 2.) type any text 3.) undo it 4.) undo once again -> command not! disabled, -> crash Kornel - -

Re: [PATCH] undo stack second try

2002-05-26 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | OK this kills the Undo * thing in favour of boost::shared_ptr. It's | valgrind clean, and seems to work fine for me. Getting undo_funcs.C into | readable shape is a job for another day. > | I've not included boring parts of the patch like removal of undost

Re: [PATCH] undo stack second try

2002-05-26 Thread John Levon
On Sun, May 26, 2002 at 08:01:35PM +0100, John Levon wrote: > OK this kills the Undo * thing in favour of boost::shared_ptr. It's Sorry, let me provide a more detailed summary : 1. Remove !DELETE_UNUSED_PARAGRAPHS code 2. remove UndoStack in favour of a template 3. use shared_ptr for managing U

[PATCH] undo stack second try

2002-05-26 Thread John Levon
OK this kills the Undo * thing in favour of boost::shared_ptr. It's valgrind clean, and seems to work fine for me. Getting undo_funcs.C into readable shape is a job for another day. I've not included boring parts of the patch like removal of undostack files OK to apply ? thanks john -- "Time

Re: [PATCH] use template for undo stack

2002-05-23 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, May 23, 2002 at 09:51:04AM +0200, Lars Gullik Bjønnes wrote: > >> Can you do this with out using a bald pointer in the stack? > | I can but try. > >> limited_stack > XX; >> >> or something? > | So what do I do in overflow case ? > | ~T(); >

Re: [PATCH] use template for undo stack

2002-05-23 Thread John Levon
On Thu, May 23, 2002 at 09:51:04AM +0200, Lars Gullik Bjønnes wrote: > Can you do this with out using a bald pointer in the stack? I can but try. > limited_stack > XX; > > or something? So what do I do in overflow case ? ~T(); call the dtor directly ? > I am planning to work hard t

Re: [PATCH] use template for undo stack

2002-05-23 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Also some minor cleanups, and one not-so-minor: now when createUndo | returns 0, it is not added to the undostack. As I understand it, this | led to us adding to the stack sizeof(Undo *) on every character the user | added. > | Please apply (can applier ad

Re: [PATCH] use template for undo stack

2002-05-22 Thread John Levon
On Wed, May 22, 2002 at 08:25:04PM +0100, John Levon wrote: > + /// limit is the maximum size of the stack > + limited_stack(size_type limit = 10) { Sigh, and change this back to the non-debug default of 100 not 10 :)) thanks john -- "I never understood what's so hard about picking a

[PATCH] use template for undo stack

2002-05-22 Thread John Levon
Also some minor cleanups, and one not-so-minor: now when createUndo returns 0, it is not added to the undostack. As I understand it, this led to us adding to the stack sizeof(Undo *) on every character the user added. Please apply (can applier add limited_stack.h to support/Makefile.am themselve