Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Thibaut Cuvelier
Guillaume just made me notice a limitation of this patch for MathFactory: with \def, the column for the XML entity was not parsed. It's fixed in this new stand-alone patch (along with small updates in lib/symbols for things I forgot). Thibaut Cuvelier On Thu, 18 Jun 2020 at 23:40, Pavel Sanda w

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 11:35:39PM +0200, Thibaut Cuvelier wrote: > indicating that no real translation was available. I highly suspect that > \varGamma was displayed as "varGamma", i.e. as text, instead of the right > symbol. As far as I know, there is no HTML entity for rare symbols like > \varGa

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Thibaut Cuvelier
That effect was not intended: few new Unicode-based XML entities should be output in HTML. I therefore investigated further the case of varGamma. Before, it was simply not translated into MathML: the symbols file only contained an x ( https://github.com/cburschka/lyx/blob/57272e837b148975817440bdc6

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 09:41:10PM +0200, Kornel Benko wrote: > > Mint 19.3 Tara. > > Tricia! Ok, debian based distros seem to be covered, I just checked with another win machine and its fine. I'll comit the last patch. Pavel -- lyx-devel mailing list lyx-devel@lists

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 21:40:25 +0200 schrieb Kornel Benko : > Am Thu, 18 Jun 2020 21:24:45 +0200 > schrieb Pavel Sanda : > > > On Thu, Jun 18, 2020 at 09:08:07PM +0200, Kornel Benko wrote: > > > I have no problems, if that is the expected line. > > > > Good, what distro? Pavel > > Mint 19

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 21:24:45 +0200 schrieb Pavel Sanda : > On Thu, Jun 18, 2020 at 09:08:07PM +0200, Kornel Benko wrote: > > I have no problems, if that is the expected line. > > Good, what distro? Pavel Mint 19.3 Tara. Kornel pgpMkJYoL8IYI.pgp Description: Digitale Signatur von Ope

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 09:08:07PM +0200, Kornel Benko wrote: > I have no problems, if that is the expected line. Good, what distro? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 21:08:07 +0200 schrieb Kornel Benko : > Am Thu, 18 Jun 2020 20:54:08 +0200 > schrieb Pavel Sanda : > > > On Thu, Jun 18, 2020 at 08:46:08PM +0200, Kornel Benko wrote: > > > > > If you go to > > > > > https://en.wikipedia.org/wiki/Mathematical_Alphanumeric_Symbols > > > > > a

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 20:54:08 +0200 schrieb Pavel Sanda : > On Thu, Jun 18, 2020 at 08:46:08PM +0200, Kornel Benko wrote: > > > > If you go to > > > > https://en.wikipedia.org/wiki/Mathematical_Alphanumeric_Symbols > > > > and check for the U+1D6Ex line do you see some meaningful symbols > > > > li

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 08:46:08PM +0200, Kornel Benko wrote: > > > If you go to > > > https://en.wikipedia.org/wiki/Mathematical_Alphanumeric_Symbols > > > and check for the U+1D6Ex line do you see some meaningful symbols > > > like \varGamma in your browsers? > Sorry, I misread the question. Dont

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 20:44:20 +0200 schrieb Kornel Benko : > Am Thu, 18 Jun 2020 20:01:18 +0200 > schrieb Pavel Sanda : > > > On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > > > Here is a new version of the first patch. Indeed, I forgot to completely > > > refactor a few font

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Kornel Benko
Am Thu, 18 Jun 2020 20:01:18 +0200 schrieb Pavel Sanda : > On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > > Here is a new version of the first patch. Indeed, I forgot to completely > > refactor a few font-related things. It should be much better now. (I also > > removed a meth

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > Here is a new version of the first patch. Indeed, I forgot to completely > refactor a few font-related things. It should be much better now. (I also > removed a method declaration that belongs to another DocBook commit down > the l

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 05:26:34PM +0200, Jean-Marc Lasgouttes wrote: > Le 18/06/2020 ?? 17:19, Pavel Sanda a écrit : > >Thanks, I committed the first patch with consts added (binding to > >temporaries). > >I propose to drop the second patch altogether. Unless you use simple > >expressions > >cha

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Jean-Marc Lasgouttes
Le 18/06/2020 à 17:19, Pavel Sanda a écrit : Thanks, I committed the first patch with consts added (binding to temporaries). I propose to drop the second patch altogether. Unless you use simple expressions chaining is not particularly safe, << is not a sequence point so order of evaluation is un

Re: Tweaking lib/symbols for XML entities

2020-06-18 Thread Pavel Sanda
On Thu, Jun 18, 2020 at 02:03:38AM +0200, Thibaut Cuvelier wrote: > On Mon, 15 Jun 2020 at 23:51, Pavel Sanda wrote: > > > On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > > > Here is a new version of the first patch. Indeed, I forgot to completely > > > refactor a few font-rel

Re: Tweaking lib/symbols for XML entities

2020-06-17 Thread Thibaut Cuvelier
On Mon, 15 Jun 2020 at 23:51, Pavel Sanda wrote: > On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > > Here is a new version of the first patch. Indeed, I forgot to completely > > refactor a few font-related things. It should be much better now. (I also > > Ok, we are bit closer

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Pavel Sanda
On Mon, Jun 15, 2020 at 02:46:47PM +0200, Thibaut Cuvelier wrote: > Here is a new version of the first patch. Indeed, I forgot to completely > refactor a few font-related things. It should be much better now. (I also Ok, we are bit closer, I committed update of first patch. There is still missing

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Pavel Sanda
On Mon, Jun 15, 2020 at 01:48:50PM +0200, Thibaut Cuvelier wrote: > The goal being to completely overhaul that export (i.e. rewrite it), I > don't know if it's helpful to ensure it still works with this patch :/. No it's not. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.ly

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Pavel Sanda
On Tue, Jun 09, 2020 at 07:02:23PM +0200, Thibaut Cuvelier wrote: > This patch is made so that there should not be any change to the XHTML > output. Oops, I think I waas too fast to accept your changes in the first patch. I see huge diff between the current Math Manual and the pre a6b07608d8e9de

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Thibaut Cuvelier
On Mon, 15 Jun 2020 at 13:30, Kornel Benko wrote: > Am Mon, 15 Jun 2020 13:21:40 +0200 > schrieb Thibaut Cuvelier : > > > On Mon, 15 Jun 2020 at 12:57, Pavel Sanda wrote: > > > > > On Mon, Jun 15, 2020 at 08:43:39AM +0200, Kornel Benko wrote: > > > > Thanks, no warnings. > > > > > > > > My try t

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Kornel Benko
Am Mon, 15 Jun 2020 13:21:40 +0200 schrieb Thibaut Cuvelier : > On Mon, 15 Jun 2020 at 12:57, Pavel Sanda wrote: > > > On Mon, Jun 15, 2020 at 08:43:39AM +0200, Kornel Benko wrote: > > > Thanks, no warnings. > > > > > > My try to export was not successful though. > > > Error: Couldn't expo

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Thibaut Cuvelier
On Mon, 15 Jun 2020 at 12:57, Pavel Sanda wrote: > On Mon, Jun 15, 2020 at 08:43:39AM +0200, Kornel Benko wrote: > > Thanks, no warnings. > > > > My try to export was not successful though. > > Error: Couldn't export file > > > > No infor

Re: Tweaking lib/symbols for XML entities

2020-06-15 Thread Pavel Sanda
On Mon, Jun 15, 2020 at 08:43:39AM +0200, Kornel Benko wrote: > Thanks, no warnings. > > My try to export was not successful though. > Error: Couldn't export file > > No information for exporting the format MS Excel Office Open XML. These

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Kornel Benko
Am Mon, 15 Jun 2020 01:54:57 +0200 schrieb Thibaut Cuvelier : ... > > Here is a new version addressing this! I let the function return a docstring, > to avoid > changing too much the initial code without a good reason to do so.  Thanks, no warnings. My try to export was not successful though.

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Kornel Benko
Am Mon, 15 Jun 2020 00:57:06 +0200 schrieb Thibaut Cuvelier : > Dear list, > > Here is a new version of the patches with the following changes: > - Kornel's patches for tests/dummy_functions.cpp and tex2lyx/dummy_impl.cpp > - rebased on top of 57272e8 >

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Kornel Benko
Am Sun, 14 Jun 2020 23:07:50 +0200 schrieb Pavel Sanda : > On Sun, Jun 14, 2020 at 10:12:31PM +0200, Kornel Benko wrote: > > > Can you try to import my patch into dummy_functions.cpp ? > > > Pavel > > > > Works, if inserted also > > #include "xml.h" > > into src/tests/dummy_functions.cpp.

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Pavel Sanda
On Sun, Jun 14, 2020 at 10:12:31PM +0200, Kornel Benko wrote: > > Can you try to import my patch into dummy_functions.cpp ? > > Pavel > > Works, if inserted also > #include "xml.h" > into src/tests/dummy_functions.cpp. Cool, can you post the patch for convenience? P -- lyx-devel mailing li

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Kornel Benko
Am Sun, 14 Jun 2020 21:37:12 +0200 schrieb Pavel Sanda : > On Sat, Jun 13, 2020 at 02:39:18PM +0200, Kornel Benko wrote: > > > Just checked, same error in cmake build for tex2lyx without Pavel's patch. > > > > > > With the patch it compiles. > > > > > > Kornel > > > > And as expected, break

Re: Tweaking lib/symbols for XML entities

2020-06-14 Thread Pavel Sanda
On Sat, Jun 13, 2020 at 02:39:18PM +0200, Kornel Benko wrote: > > Just checked, same error in cmake build for tex2lyx without Pavel's patch. > > > > With the patch it compiles. > > > > Kornel > > And as expected, breaks building of check_layout: Can you try to import my patch into dummy_fun

Re: Tweaking lib/symbols for XML entities

2020-06-13 Thread Jean-Marc Lasgouttes
Le 13/06/2020 à 10:21, Kornel Benko a écrit : Or you can add ../xml.o to the link list. Does this work? I think this is in general better than to use a hack. I do not see it as a hack. This is unused code in tex2lyx. And dummy*.cpp is exactly for this purpose there. I know that, I just advoc

Re: Tweaking lib/symbols for XML entities

2020-06-13 Thread Kornel Benko
Am Sat, 13 Jun 2020 14:36:34 +0200 schrieb Kornel Benko : > Am Sat, 13 Jun 2020 10:09:34 +0200 > schrieb Kornel Benko : > > > Am Fri, 12 Jun 2020 13:15:19 +0200 > > schrieb Pavel Sanda : > > > > > On Thu, Jun 11, 2020 at 06:30:22PM +0200, Thibaut Cuvelier wrote: > > > > Yes, the output is

Re: Tweaking lib/symbols for XML entities

2020-06-13 Thread Kornel Benko
Am Sat, 13 Jun 2020 10:09:34 +0200 schrieb Kornel Benko : > Am Fri, 12 Jun 2020 13:15:19 +0200 > schrieb Pavel Sanda : > > > On Thu, Jun 11, 2020 at 06:30:22PM +0200, Thibaut Cuvelier wrote: > > > Yes, the output is identical. I also added some comments. > > > > > > I'm adding a third patch in

Re: Tweaking lib/symbols for XML entities

2020-06-13 Thread Kornel Benko
Am Sat, 13 Jun 2020 00:33:20 +0200 schrieb Jean-Marc Lasgouttes : > Le 12/06/2020 à 23:28, Pavel Sanda a écrit : > > On Fri, Jun 12, 2020 at 01:15:19PM +0200, Pavel Sanda wrote: > > For this part, the attached patch seem to help with autotools. IMHO it would help on cmake build too. > Or you c

Re: Tweaking lib/symbols for XML entities

2020-06-13 Thread Kornel Benko
Am Fri, 12 Jun 2020 13:15:19 +0200 schrieb Pavel Sanda : > On Thu, Jun 11, 2020 at 06:30:22PM +0200, Thibaut Cuvelier wrote: > > Yes, the output is identical. I also added some comments. > > > > I'm adding a third patch in this, I forgot it was necessary??? It is a > > refactoring of XHTMLStream

Re: Tweaking lib/symbols for XML entities

2020-06-12 Thread Pavel Sanda
On Sat, Jun 13, 2020 at 12:33:20AM +0200, Jean-Marc Lasgouttes wrote: > Le 12/06/2020 ? 23:28, Pavel Sanda a écrit : > >On Fri, Jun 12, 2020 at 01:15:19PM +0200, Pavel Sanda wrote: > >For this part, the attached patch seem to help with autotools. > > Or you can add ../xml.o to the link list. Does

Re: Tweaking lib/symbols for XML entities

2020-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2020 à 23:28, Pavel Sanda a écrit : On Fri, Jun 12, 2020 at 01:15:19PM +0200, Pavel Sanda wrote: For this part, the attached patch seem to help with autotools. Or you can add ../xml.o to the link list. Does this work? I think this is in general better than to use a hack. It all depend

Re: Tweaking lib/symbols for XML entities

2020-06-12 Thread Pavel Sanda
On Fri, Jun 12, 2020 at 01:15:19PM +0200, Pavel Sanda wrote: For this part, the attached patch seem to help with autotools. > CXX dummy_impl.o > CXXLDtex2lyx > dummy_impl.o: In function > `lyx::xml::StartTag::StartTag(std::__cxx11::basic_string std::char_traits, std::allocator > cons

Re: Tweaking lib/symbols for XML entities

2020-06-12 Thread Pavel Sanda
On Thu, Jun 11, 2020 at 06:30:22PM +0200, Thibaut Cuvelier wrote: > Yes, the output is identical. I also added some comments. > > I'm adding a third patch in this, I forgot it was necessary??? It is a > refactoring of XHTMLStream as a more generic XMLStream (required for > DocBook, and it has a fe

Re: Tweaking lib/symbols for XML entities

2020-06-11 Thread Pavel Sanda
On Tue, Jun 09, 2020 at 07:02:23PM +0200, Thibaut Cuvelier wrote: > This patch is made so that there should not be any change to the XHTML > output. All features are opt-in (name spaces and XML entities). XHTML > output always uses HTML entities (which are very lenient), XML ones should > never be

Re: Tweaking lib/symbols for XML entities

2020-06-09 Thread Pavel Sanda
On Wed, May 20, 2020 at 03:02:21AM +0200, Thibaut Cuvelier wrote: > Hi all, > > Again, a new version of the second patch, as I find new things that should > be adapted. Is it good enough to be merged? I skimmed through the pacthes. Given the obselete status of docbook export I do not care that mu

Re: Tweaking lib/symbols for XML entities

2020-05-14 Thread Thibaut Cuvelier
On Thu, 14 May 2020 at 20:40, Guenter Milde wrote: > Dear Thibaut, > > On 2020-05-10, Thibaut Cuvelier wrote: > > > In order to ensure a valid DocBook entity with math formulae, the MathML > > generator must produce valid XML. Right now, it "only" produces valid > HTML > > (which is already quite

Re: Tweaking lib/symbols for XML entities

2020-05-14 Thread Guenter Milde
Dear Thibaut, On 2020-05-10, Thibaut Cuvelier wrote: > In order to ensure a valid DocBook entity with math formulae, the MathML > generator must produce valid XML. Right now, it "only" produces valid HTML > (which is already quite an achievement!). The difference is in the > entities: in HTML, yo

Re: Tweaking lib/symbols for XML entities

2020-05-13 Thread Pavel Sanda
On Wed, May 13, 2020 at 01:44:43AM +0200, Thibaut Cuvelier wrote: > I am attaching a new version of the patch that does this. Can we get this line in symbols right? #symbolfont charid charid-in-fallback-Xsymbol-font I hope my understanding is correct that with your patch the str

Re: Tweaking lib/symbols for XML entities

2020-05-10 Thread Richard Kimberly Heck
On 5/9/20 9:25 PM, Thibaut Cuvelier wrote: > Dear list, > > In order to ensure a valid DocBook entity with math formulae, the > MathML generator must produce valid XML. Right now, it "only" produces > valid HTML (which is already quite an achievement!). The difference is > in the entities: in HTML,

Tweaking lib/symbols for XML entities

2020-05-09 Thread Thibaut Cuvelier
Dear list, In order to ensure a valid DocBook entity with math formulae, the MathML generator must produce valid XML. Right now, it "only" produces valid HTML (which is already quite an achievement!). The difference is in the entities: in HTML, you can use many entities, like ∑. This is no more th