Richard Heck wrote:
> are similar bugs lurking elsewhere. So I'd suggest we go ahead.
ok
pavel
On 03/09/2010 09:59 AM, Pavel Sanda wrote:
Richard Heck wrote:
I don't think this will introduce instability, as delaying the call to
updateBuffer() shouldn't have ill effects. I'll guess, though, that there
are some missing updates in here, but these can easily enough be fixed. In
any event
Le 09/03/2010 16:10, rgheck a écrit :
The fine workaround doesn't really work. It prevents the crash, but
there's a nasty flashing, and the TOC resets to "Table of Contents"
every time we updateBuffer(). I also suspect, though of course I don't
know, that there are similar bugs lurking elsewhere.
Richard Heck wrote:
> I don't think this will introduce instability, as delaying the call to
> updateBuffer() shouldn't have ill effects. I'll guess, though, that there
> are some missing updates in here, but these can easily enough be fixed. In
> any event, it is essential. What caused 6522 wil
On 03/09/2010 03:26 AM, Abdelrazak Younes wrote:
This is a very good and welcome initiative.
First comment: You call cur.needBufferUpdate() but that does nothing ;-)
I suggest to have two different method for setting/getting:
+///
+void setNeedBufferUpdate(bool u);
+///
+bool n
On 03/09/2010 12:07 AM, rgheck wrote:
The attached patch attempts to address the underlying cause of bug
6522. My other fixes all have problems, which trace to the fact that
we are calling updateBuffer()---what used to be called
updateLabels()---before we are really ready to do so. The patch
Le 09/03/2010 00:07, rgheck a écrit :
The patch introduces an argument to DispatchResult that tracks whether
we need to update the Buffer. This reduces the number of updateBuffer
calls to six or seven from a whole lot more than that, and some of these
can still go, too. Ideally, we'd like one suc
The attached patch attempts to address the underlying cause of bug 6522.
My other fixes all have problems, which trace to the fact that we are
calling updateBuffer()---what used to be called updateLabels()---before
we are really ready to do so. The patch also does something we've been
wanting
