Re: Math Toolbar patch

2001-05-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Attached is a patch doing this and fixing the other bugs I Angus> discovered. It does not implement the math toolbar at all and Angus> can be applied now. Please do so! I am in the process of applying it. JMarc

Re: Math Toolbar patch

2001-05-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> * Finally, the Angus> Layout definition in default.ui should be replaced with Angus> DropdownList "layout". An even better suggestion was to use the menu backend for toolbars too (somehow) and to implement drop down lists as subme

Re: Math Toolbar patch

2001-04-27 Thread Angus Leeming
width(), height(), xpos(), ypos() > | and insettext, insettabular that call > | getClipboard() > | > | Shall I add some wrappers for these calls to BufferView? > > please do. (and in a separate from the toolbar patch please) Attached is a patch doing this and fixing the othe

Re: Math Toolbar patch

2001-04-27 Thread Lars Gullik Bjønnes
I add some wrappers for these calls to BufferView? please do. (and in a separate from the toolbar patch please) | Point 3, for Dekel, Allan. | The flicker is annoying isn't it! Can we avoid this by locking the xforms forms/object? -- Lgb

Re: Math Toolbar patch

2001-04-27 Thread Angus Leeming
Thanks everybody for the feedback. Point 1, for Lars: this IS almost generic. At least as a first attempt it ain't far off. And for this, I think you/I must extend a special thank you to Jean-Marc for creating such a general toolbar code. Even if toolbarItem should be a base class so that co

Re: Math Toolbar patch

2001-04-26 Thread Allan Rae
On Fri, 27 Apr 2001, Dekel Tsur wrote: > On Thu, Apr 26, 2001 at 08:58:42PM +0100, Angus Leeming wrote: > > Attached is a patch creating a Math Toolbar. I'm posting it, rather than > > commiting it to the repository because I discovered what I think are a couple > > of bugs in WorkArea and in Too

Re: Math Toolbar patch

2001-04-26 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | WorkArea's (width, height, xpos, ypos) returned the dimensions of something | in between the work_area FL_OBJECT and the entire space taken up by WorkArea. | I think that this is wrong and have changed them to return the dimensions of | the entire W

Re: Math Toolbar patch

2001-04-26 Thread Dekel Tsur
On Thu, Apr 26, 2001 at 08:58:42PM +0100, Angus Leeming wrote: > Attached is a patch creating a Math Toolbar. I'm posting it, rather than > commiting it to the repository because I discovered what I think are a couple > of bugs in WorkArea and in ToolbarDefaults, but am not very familiar with th

Math Toolbar patch

2001-04-26 Thread Angus Leeming
Attached is a patch creating a Math Toolbar. I'm posting it, rather than commiting it to the repository because I discovered what I think are a couple of bugs in WorkArea and in ToolbarDefaults, but am not very familiar with the code, so think I should seek a second opinion... WorkArea's (widt

Re: Toolbar patch

2000-07-31 Thread Jean-Marc Lasgouttes
> "Baruch" == Baruch Even <[EMAIL PROTECTED]> writes: Baruch> Hello, While reading the new toolbar and menu code I found Baruch> what seems to me to be a bug (possible resource leak) in Baruch> Toolbar_impl.C, patch follows. Yes, it seems reasonable. I put the fix in cvs. JMarc

Toolbar patch

2000-07-30 Thread Baruch Even
Hello, While reading the new toolbar and menu code I found what seems to me to be a bug (possible resource leak) in Toolbar_impl.C, patch follows. Index: src/frontends/xforms/Toolbar_pimpl.C === RCS file: /usr/local/lyx/cvsroot/lyx-