Re: [PATCH] Re: SubFigure conversion error

2008-10-25 Thread José Matos
On Saturday 25 October 2008 09:33:02 Jürgen Spitzmüller wrote: > > Yes, I've double-checked, and you're right. > > > If that seems right, I'll commit the fix. > > I'd say so. OK. > Jürgen -- José Abílio

Re: [PATCH] Re: SubFigure conversion error

2008-10-25 Thread Jürgen Spitzmüller
rgheck wrote: > I've checked this. If there's nothing in the subcaption in 1.5, you get: >     \subfigure[]{whatever} > as if there were an empty caption. So I guess we should put in an empty > caption inset, so that in 1.6 you get: >     \subfloat[]{whatever} > rather than: >     \subfloat{whateve

Re: [PATCH] Re: SubFigure conversion error

2008-10-24 Thread rgheck
Jürgen Spitzmüller wrote: rgheck wrote: I've got a working patch where lyx2lyx writes an empty caption inset. Patch is attached. We could omit the caption inset altogether if we wanted, but will LyX accept that? What is the output? I think it should look as comparable as possible. I.e.

Re: [PATCH] Re: SubFigure conversion error

2008-10-24 Thread Jürgen Spitzmüller
rgheck wrote: > I've got a working patch where lyx2lyx writes an empty caption inset. > Patch is attached. We could omit the caption inset altogether if we > wanted, but will LyX accept that? What is the output? I think it should look as comparable as possible. I.e., if the 1.5 document outputted

[PATCH] Re: SubFigure conversion error

2008-10-24 Thread rgheck
Jürgen Spitzmüller wrote: rgheck wrote: One of our users has had a problem converting certain documents into 1.6. Turns out these are documents that have subfigures but NO subcaption. Right now, lyx2lyx throws an error in this case. It's easy to fix this, but what should we do? Can we just om

Re: SubFigure conversion error

2008-10-24 Thread Jürgen Spitzmüller
rgheck wrote: > One of our users has had a problem converting certain documents into > 1.6. Turns out these are documents that have subfigures but NO > subcaption. Right now, lyx2lyx throws an error in this case. It's easy > to fix this, but what should we do? Can we just omit the caption? Should >

SubFigure conversion error

2008-10-23 Thread rgheck
One of our users has had a problem converting certain documents into 1.6. Turns out these are documents that have subfigures but NO subcaption. Right now, lyx2lyx throws an error in this case. It's easy to fix this, but what should we do? Can we just omit the caption? Should we write and empt