Andre Poenitz wrote:
> +void DocumentIterator::forwardInset()
> +{
> + while (depth()) {
> + size_t old_depth = depth();
> +
> + forwardPos();
> +
> + if (depth() > old_depth)
> + break;
> + }
> +}
>
> Aehm, forget the last mail. If
On Sat, Mar 27, 2004 at 02:11:16PM +0100, Alfredo Braunstein wrote:
> I think it is a complete no-issue for now, as iterating over all cursor
> positions of the Userguide20 is still unnoticeable (sub second) here. If it
> shows up in the profiles we can do it later. I'd really prefer to have the
>
On Sat, Mar 27, 2004 at 01:16:33PM +0100, Alfredo Braunstein wrote:
> I've reimplemented forwardPar as well which was severely fsckd up.
AKA "not implemented at all"?
> I'll apply both shortly if there are no objections.
None from my side...
Andre'
On Sat, Mar 27, 2004 at 01:16:33PM +0100, Alfredo Braunstein wrote:
> Ok, your testcase works fine with Andre's patch and this implementation of
> forwardInset.
+void DocumentIterator::forwardInset()
+{
+ while (depth()) {
+ size_t old_depth = depth();
+
+ forwar
Andre Poenitz wrote:
> On Sat, Mar 27, 2004 at 12:56:03AM +0100, Alfredo Braunstein wrote:
>> > Missing insetiterator.C?
>>
>> No, just DocIterator::forwardInset in dociterator.C.
>
>
> void DocumentIterator::forwardInset()
> {
> forwardPos();
> while (!empty() && (pos() == lastpos() || nextI
On Sat, Mar 27, 2004 at 12:56:03AM +0100, Alfredo Braunstein wrote:
> > Missing insetiterator.C?
>
> No, just DocIterator::forwardInset in dociterator.C.
void DocumentIterator::forwardInset()
{
forwardPos();
while (!empty() && (pos() == lastpos() || nextInset() == 0))
On Sat, Mar 27, 2004 at 12:59:19AM +0100, Alfredo Braunstein wrote:
> Andre Poenitz wrote:
>
> > This seems to be solvable. Attached a 'makepatch.sh' style patch that
> > replaces Buffer::inset_iterator by some small wrapper around
> > DocumentIterator.
> >
> > [Alfredo: Is this close to what yo
Alfredo Braunstein wrote:
> Angus Leeming wrote:
>
>> On Friday 26 March 2004 7:05 pm, Andre Poenitz wrote:
>>> On Thu, Mar 25, 2004 at 04:20:18PM +, Angus Leeming wrote:
>>> > LyX is crashing when iterating over insets. Note the two added
>>> > lines, below. That looks very, very wrong :-(
>
Andre Poenitz wrote:
> This seems to be solvable. Attached a 'makepatch.sh' style patch that
> replaces Buffer::inset_iterator by some small wrapper around
> DocumentIterator.
>
> [Alfredo: Is this close to what you proposed for PosIterator?]
Yes... I wonder if private derivation would be prefe
Angus Leeming wrote:
> On Friday 26 March 2004 7:05 pm, Andre Poenitz wrote:
>> On Thu, Mar 25, 2004 at 04:20:18PM +, Angus Leeming wrote:
>> > LyX is crashing when iterating over insets. Note the two added
>> > lines, below. That looks very, very wrong :-(
>>
>> This seems to be solvable. Att
On Friday 26 March 2004 7:05 pm, Andre Poenitz wrote:
> On Thu, Mar 25, 2004 at 04:20:18PM +, Angus Leeming wrote:
> > LyX is crashing when iterating over insets. Note the two added
> > lines, below. That looks very, very wrong :-(
>
> This seems to be solvable. Attached a 'makepatch.sh' style
On Thu, Mar 25, 2004 at 04:20:18PM +, Angus Leeming wrote:
> LyX is crashing when iterating over insets. Note the two added lines,
> below. That looks very, very wrong :-(
This seems to be solvable. Attached a 'makepatch.sh' style patch that
replaces Buffer::inset_iterator by some small wrapp
On Thu, Mar 25, 2004 at 05:02:50PM +, Angus Leeming wrote:
> > // This is also a buffer property (ale)
> > void Buffer::fillWithBibKeys(std::vector >
>
> > for (inset_iterator it = inset_const_iterator_begin();
> > it != inset_const_iterator_end(); ++it) {
> > +
LyX is crashing when iterating over insets. Note the two added lines,
below. That looks very, very wrong :-(
Angus
// This is also a buffer property (ale)
void Buffer::fillWithBibKeys(std::vector > &
keys)
const
{
/// if this is a child document and the parent is already loaded
14 matches
Mail list logo
