Re: Some bug fixes are trivial :-)

2005-04-29 Thread Georg Baum
Martin Vermeer wrote: > ...and some development work should not be done after bedtime ;-) Well, noon is not bedtime for me, but thanks for the fix! Georg

Some bug fixes are trivial :-)

2005-04-29 Thread Martin Vermeer
...and some development work should not be done after bedtime ;-) This goes in now. - Martin Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/ChangeLog,v retrieving revision 1.475 diff -u -p

Re: Some bug fixes

2001-12-10 Thread Jean-Marc Lasgouttes
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: Herbert> as far as I remember \columnwidth, \textwidth, and others Herbert> can't have a glue length because they are of registertype Herbert> dimen and not of type skip, which can have glue. This is the kind of information I was lookin

Re: Some bug fixes

2001-12-10 Thread Herbert Voss
Jean-Marc Lasgouttes wrote: >>"Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: >> > >>>I wrote the code this week-end, and then lost it :( Anyway, it was >>>not too difficult. However what kind of length should I have? >>>LyXLength or LyXGlueLength? Can there be glue in column width

Re: Some bug fixes

2001-12-10 Thread Jean-Marc Lasgouttes
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: >> I wrote the code this week-end, and then lost it :( Anyway, it was >> not too difficult. However what kind of length should I have? >> LyXLength or LyXGlueLength? Can there be glue in column widths? >> Same question holds for minipage

Re: Some bug fixes

2001-12-10 Thread Herbert Voss
Jean-Marc Lasgouttes wrote: >>"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> > > Jean-Marc> On the other hand, VSpace::VSpace takes 38% of the total > Jean-Marc> time to load/display this file! This is because langths are > Jean-Marc> stored as strings and converted

Re: Some bug fixes

2001-12-10 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> On the other hand, VSpace::VSpace takes 38% of the total Jean-Marc> time to load/display this file! This is because langths are Jean-Marc> stored as strings and converted whenever something needs to Jean-Marc> be don

Re: Some bug fixes

2001-12-04 Thread John Levon
On Tue, Dec 04, 2001 at 02:46:10PM +1000, Allan Rae wrote: > > Who the hell is Jerry Springer! #:O) > > Yet another American talk show host (YAATSH) who relies on the 5 C's > of communication: > Confrontation, > Cursing, > Confusion, > Conceit, > Corruption > heh

Re: Some bug fixes

2001-12-03 Thread Allan Rae
On Mon, 3 Dec 2001, Juergen Vigna wrote: > > On 03-Dec-2001 Allan Rae wrote: > > >> this is just like Jerry Springer ! > > > > Which is more frightening: > > that this conversation is allegedly like Jerry Springer > > or > > that John has watched Jerry Springer in order to make this >

Re: Some bug fixes

2001-12-03 Thread Juergen Vigna
On 03-Dec-2001 Allan Rae wrote: >> this is just like Jerry Springer ! > > Which is more frightening: > that this conversation is allegedly like Jerry Springer > or > that John has watched Jerry Springer in order to make this > observation? Who the hell is Jerry Springer! #:O)

Re: Some bug fixes

2001-12-02 Thread Allan Rae
On Fri, 30 Nov 2001, John Levon wrote: > On Fri, Nov 30, 2001 at 12:51:13PM +0100, Juergen Vigna wrote: > > > Do you want to let us know how good your math-skills are or did you > > book a statistical course lately? Anyway just try to load the TablesExamples > > file and you'll get the messages.

Re: Some bug fixes

2001-11-30 Thread John Levon
On Fri, Nov 30, 2001 at 12:51:13PM +0100, Juergen Vigna wrote: > Do you want to let us know how good your math-skills are or did you > book a statistical course lately? Anyway just try to load the TablesExamples > file and you'll get the messages. Is this an ease enough solution also > for you?

Re: Some bug fixes

2001-11-30 Thread Jules Bean
On Fri, Nov 30, 2001 at 05:00:51PM +0100, Andre Poenitz wrote: > On Fri, Nov 30, 2001 at 05:00:01PM +0100, Lars Gullik Bjønnes wrote: > > | That is my belief. Although, when you care about these things, I've > > | always thought a naming scheme like u32int is better style. > > > > So how many mm

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 05:00:01PM +0100, Lars Gullik Bjønnes wrote: > | That is my belief. Although, when you care about these things, I've > | always thought a naming scheme like u32int is better style. > > So how many mm can a 32 bits int measured in sp span? 2^16 points = 2^16/72 inches = 2

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 03:32:53PM +, Jules Bean wrote: > It's not in Stroustrup; but I can't see any such details about data > size there. *sigh* Portability is not obtained by making 'int' > represent 'a convenient size': rather, portability is obtained by > knowing exactly how many bits you

Re: Some bug fixes

2001-11-30 Thread Jules Bean
On Fri, Nov 30, 2001 at 04:16:40PM +0100, Andre Poenitz wrote: > On Fri, Nov 30, 2001 at 03:12:02PM +, Jules Bean wrote: > > There is a standardised 64 bit integer type: long long int is standard. > > It's in C99 as far as I know, but in C++98? I don't know. It's not in Stroustrup; but I ca

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 03:12:02PM +, Jules Bean wrote: > There is a standardised 64 bit integer type: long long int is standard. It's in C99 as far as I know, but in C++98? > It may not be supported by all the compilers though. Yes. > Anyhow, this is all (fortunately) moot: you'll notice

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Fri, Nov 30, 2001 at 03:48:27PM +0100, Jean-Marc Lasgouttes Andre> wrote: >> As far as my benchmarking is concerned, not storing the lengths as >> strings should do the trick. >> Please discuss you planned changes before doing

Re: Some bug fixes

2001-11-30 Thread Jules Bean
On Fri, Nov 30, 2001 at 04:04:03PM +0100, Andre Poenitz wrote: > On Fri, Nov 30, 2001 at 02:59:50PM +, Jules Bean wrote: > > And the difference between 'multiple of some small value' and 'some > > fixed point thingy' is what, exactly? > > I'd stick to double for the moment since if the sp is

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 02:59:50PM +, Jules Bean wrote: > And the difference between 'multiple of some small value' and 'some > fixed point thingy' is what, exactly? I'd stick to double for the moment since if the sp is 2^(-32) of a point, they won't fit too well into an int on IA32 and there

Re: Some bug fixes

2001-11-30 Thread Jules Bean
On Fri, Nov 30, 2001 at 03:48:27PM +0100, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> LaTeX stores length as multiple of some small value if I got > Andre> this right, and we should do likewise. The 'scaled point' which is 2^(-32) of a poi

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 03:48:27PM +0100, Jean-Marc Lasgouttes wrote: > As far as my benchmarking is concerned, not storing the lengths as > strings should do the trick. > Please discuss you planned changes before doing them. I was thinking about this ;-) The "plan" looks like: Internal: -

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> LaTeX stores length as multiple of some small value if I got Andre> this right, and we should do likewise. Where did you find that? I though it was some fixed point thingy. Andre> You benchmarking even suggests that there is som

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 03:40:17PM +0100, Jean-Marc Lasgouttes wrote: > Andre> As I said, the next look I will have on vspace.[hC] would > Andre> probably involve some real changes... > > To the interface? To the code? Both. LaTeX stores length as multiple of some small value if I got this righ

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> As I said, the next look I will have on vspace.[hC] would Andre> probably involve some real changes... To the interface? To the code? JMarc

Re: Some bug fixes

2001-11-30 Thread Andre Poenitz
On Fri, Nov 30, 2001 at 02:51:34PM +0100, Jean-Marc Lasgouttes wrote: > Jean-Marc> Ahh, so finally I have an answer. Thanks. Yes, I mean it. > > In case anybody cares: It is possible to avoid the warning, but it > involves adding a gratuitous tabular->GetInsetOfCell call just to have > a correct

Re: Some bug fixes

2001-11-30 Thread Juergen Vigna
On 30-Nov-2001 Angus Leeming wrote: > Well I can picture a solution of storing the pixmaps for each cell in a > cache. Changing a cell would then result in you only needing to recreate the > pixmaps for that column (if the width of the cell changed) and that row (if > the height of the cell c

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 30-Nov-2001 Jean-Marc Lasgouttes wrote: >> On the other hand, VSpace::VSpace takes 38% of the total time to >> load/display this file! This is because langths are stored as >> strings and converted whenever something needs

Re: Some bug fixes

2001-11-30 Thread Juergen Vigna
On 30-Nov-2001 Jean-Marc Lasgouttes wrote: > On the other hand, VSpace::VSpace takes 38% of the total time to > load/display this file! This is because langths are stored as strings > and converted whenever something needs to be done (at each > getMaxWidthOfCell, for example). Is there a reason

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Anyway just try to load the TablesExamples file and you'll Juergen> get the messages. Is this an ease enough solution also for Juergen> you? Jean-Marc> Ahh,

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Anyway just try to load the TablesExamples file and you'll Juergen> get the messages. Is this an ease enough solution also for Juergen> you? Ahh, so finally I have an answer. Thanks. Yes, I mean it. Juergen> Anyway if you all

Re: Some bug fixes

2001-11-30 Thread Juergen Vigna
On 30-Nov-2001 Jean-Marc Lasgouttes wrote: > So the drawing was in O(nbcells^2). Now this is fixed. Fine. > > So now we have a warning when a text inset has to check over all its > tabular owner to know in which cell it lies. This is an O(nbcells) > operation, so it is expensive. Since you seem

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 30-Nov-2001 Jean-Marc Lasgouttes wrote: >> Yes, but when the warning appears, it means that one has to scan >> all the tabular. Juergen> Ok then tell me how you would draw the tabular by NOT Juergen> scanning all of it! Or

Re: Some bug fixes

2001-11-30 Thread Angus Leeming
On Friday 30 November 2001 10:15 am, Juergen Vigna wrote: > On 30-Nov-2001 Jean-Marc Lasgouttes wrote: > > > Yes, but when the warning appears, it means that one has to scan all > > the tabular. > > Ok then tell me how you would draw the tabular by NOT scanning all of it! > Or better just implem

Re: Some bug fixes

2001-11-30 Thread Juergen Vigna
On 30-Nov-2001 Jean-Marc Lasgouttes wrote: > Yes, but when the warning appears, it means that one has to scan all > the tabular. Ok then tell me how you would draw the tabular by NOT scanning all of it! Or better just implement it I'm surely curious how that painted table my look!

Re: Some bug fixes

2001-11-30 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Comeone Jean-Marc you can do better! You know that in that Juergen> code we are setting a cache variable for the used Inset now Juergen> if you iterate over all cell doing a whole redraw of the Juergen> tabular guess if the cac

Re: Some bug fixes

2001-11-30 Thread Juergen Vigna
On 29-Nov-2001 Jean-Marc Lasgouttes wrote: > I asked because this getMaxWidth is slow when the warning occurs, and > speeding things up is always nice :) Comeone Jean-Marc you can do better! You know that in that code we are setting a cache variable for the used Inset now if you iterate over al

Re: Some bug fixes

2001-11-29 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> It is obvious why this happens and it will always happen! The Juergen> message is in getMaxWidth() which every InsetText inside of a Juergen> tabular has to call to be able to draw itself! So if we draw Juergen> the tabular for

Re: Some bug fixes

2001-11-29 Thread Juergen Vigna
On 28-Nov-2001 Jean-Marc Lasgouttes wrote: > Juergen> Fixed (actually this is only a warning for internal reasons I > Juergen> left it there but with lyxerr[INSETTEXT] ;) > > Did you manage in reproducing it? I would be interested to see why it > happens. I'm not sure what I am supposed to do t

Re: Some bug fixes

2001-11-28 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: >> - Loading a document with a very large table (125 rows x 5 columns) >> causes the following console message(s): "Actcell not equal to >> actual cell!" (document by request) Juergen> Fixed (actually this is only a warning for interna

Some bug fixes

2001-11-28 Thread Juergen Vigna
> - Loading a document with a very large table (125 rows x 5 columns) causes the > following console message(s): "Actcell not equal to actual cell!" (document by > request) Fixed (actually this is only a warning for internal reasons I left it there but with lyxerr[INSETTEXT] ;) > - Juergen