Re: Slight speedup of BufferView::Pimpl::update

2006-07-05 Thread Andre Poenitz
On Tue, Jul 04, 2006 at 09:46:48AM +0200, Jean-Marc Lasgouttes wrote: > > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > Lars> This patch speeds up the scroll-down test by and odd second or > Lars> two for me. Do others see the same? I guess it cannot do any > Lars> harm, so com

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | Definitely. But does your answer mean you are not opposed to it? Lars> Not as opposed as I used to be :-) This is what I had in mind :) JMarc

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> If we go the macro way (and we should be very careful about | Lars> this), then we should go even a bit further. | | Lars> We should then use a macro that adds the BOOST_C

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> If we go the macro way (and we should be very careful about Lars> this), then we should go even a bit further. Lars> We should then use a macro that adds the BOOST_CURRENT_FUNCTION, Lars> and __FILE__ and __LINE__ always to the

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | > This patch speeds up the scroll-down test by and odd second or two for | > me. | | Really? A _very_ coarse test really. I might be mistaken. Howver it cannot hurt. | Wow! Did John Torjo's logging li

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> This patch speeds up the scroll-down test by and odd second or | Lars> two for me. Do others see the same? I guess it cannot do any | Lars> harm, so committing. | | Isn't

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Angus Leeming
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > This patch speeds up the scroll-down test by and odd second or two for > me. Really? Wow! Did John Torjo's logging library ever make it into Boost? IIRC, using it would be equivalent to your change here. > void BufferView::Pimpl::update(Update::f

Re: Slight speedup of BufferView::Pimpl::update

2006-07-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> This patch speeds up the scroll-down test by and odd second or Lars> two for me. Do others see the same? I guess it cannot do any Lars> harm, so committing. Isn't it possible to do this in a more compact way? If we use macros,

Slight speedup of BufferView::Pimpl::update

2006-07-03 Thread Lars Gullik Bjønnes
This patch speeds up the scroll-down test by and odd second or two for me. Do others see the same? I guess it cannot do any harm, so committing. Index: src/BufferView_pimpl.C === --- src/BufferView_pimpl.C (revision 14332) +++