Re: Remove Qt < 5.2 conditionals and special code

2023-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 17.08.2023 um 20:51 +0200 schrieb Jean-Marc Lasgouttes: > +1 Thanks, done. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Jean-Marc Lasgouttes
+1 JMarc Le 17 août 2023 16:12:43 GMT+02:00, Pavel Sanda a écrit : >I don't think there is a value in keeping LyX compilable with Qt < 5.2, >because 5.2 was released 10 years ago. >Even closed/commerical LTS variants of current distros do not show support >>10y. > >So +1 for removal from my s

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Pavel Sanda
On Thu, Aug 17, 2023 at 02:40:44PM +0200, Jürgen Spitzmüller wrote: > But this would mean, in consequence, that if we implement something > within the 2.4 cycle, we would have to make sure it still compiles with > Qt < 5.2. > > I got to this while pondering about the URL link warning dialog. > Imp

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Scott Kostyshak
On Thu, Aug 17, 2023 at 02:40:44PM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 17.08.2023 um 07:24 -0400 schrieb Scott Kostyshak: > > I'm not necessarily against it, but the argument for keeping that > > code is that it might be helpful to do a bisect of Qt to figure out a > > Qt bug. The

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Jürgen Spitzmüller
Am Donnerstag, dem 17.08.2023 um 07:24 -0400 schrieb Scott Kostyshak: > I'm not necessarily against it, but the argument for keeping that > code is that it might be helpful to do a bisect of Qt to figure out a > Qt bug. The reason we require a higher Qt 5.x is that *some* things > don't work well,

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Scott Kostyshak
On Thu, Aug 17, 2023 at 10:18:13AM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 17.08.2023 um 10:01 +0200 schrieb Jürgen > Spitzmüller: > > According to the README, we require Qt 5.2 or higher for 2.4. > > > > There is still some code for Qt < 5.2 in the source. Particularly a > > self-ba

Re: Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Jürgen Spitzmüller
Am Donnerstag, dem 17.08.2023 um 10:01 +0200 schrieb Jürgen Spitzmüller: > According to the README, we require Qt 5.2 or higher for 2.4. > > There is still some code for Qt < 5.2 in the source. Particularly a > self-baked "Don't ask me again" warning dialog. > > OK to remove that (see patch)? I

Remove Qt < 5.2 conditionals and special code

2023-08-17 Thread Jürgen Spitzmüller
According to the README, we require Qt 5.2 or higher for 2.4. There is still some code for Qt < 5.2 in the source. Particularly a self-baked "Don't ask me again" warning dialog. OK to remove that (see patch)? -- Jürgen diff --git a/src/frontends/qt/FancyLineEdit.cpp b/src/frontends/qt/FancyLine