Re: windows preview bug fix

2024-03-12 Thread Jürgen Spitzmüller
Am Dienstag, dem 12.03.2024 um 13:23 +0200 schrieb Idan Pazi: > I hereby grant a permission for all of my contributions to LyX to be > licensed under the GPL version 2 or later. Thanks, I committed your patch. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mail

Re: windows preview bug fix

2024-03-12 Thread Idan Pazi
I hereby grant a permission for all of my contributions to LyX to be licensed under the GPL version 2 or later. Thank you, Idan Pazi -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: windows preview bug fix

2024-03-12 Thread José Matos
On Tue, 2024-03-12 at 10:37 +0100, Jürgen Spitzmüller wrote: > If nobody beats me to it, I will do it. Thank you Jürgen, I am busy with other issues. Best regards, -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: windows preview bug fix

2024-03-12 Thread Jürgen Spitzmüller
Am Sonntag, dem 10.03.2024 um 14:52 -0400 schrieb Richard Kimberly Heck: > On 3/8/24 04:19, Jürgen Spitzmüller wrote: > > Am Samstag, dem 02.03.2024 um 19:49 + schrieb José Matos: > > > After our exchange last week I feel inclined to apply this. > > > > > > I am still note sure that this is th

Re: windows preview bug fix

2024-03-10 Thread Richard Kimberly Heck
On 3/8/24 04:19, Jürgen Spitzmüller wrote: Am Samstag, dem 02.03.2024 um 19:49 + schrieb José Matos: After our exchange last week I feel inclined to apply this. I am still note sure that this is the right step but clearly it improves the code regarding the previous one. Does any one oppose

Re: windows preview bug fix

2024-03-08 Thread Jürgen Spitzmüller
Am Samstag, dem 02.03.2024 um 19:49 + schrieb José Matos: > After our exchange last week I feel inclined to apply this. > > I am still note sure that this is the right step but clearly it > improves the code regarding the previous one. > > Does any one opposes to this action? My suggestion w

Re: windows preview bug fix

2024-03-02 Thread José Matos
On Fri, 2024-02-16 at 15:23 +0200, Idan Pazi wrote: > Encountered the following bug (windows 10, python 3.12) - preview of > math fails: > >  graphics\PreviewLoader.cpp (2ef): > > PreviewLoader::finishedInProgress(1): processing failed for py -3 - > > tt $$s/scripts/lyxpreview2bitmap.py --png > > "

Re: windows preview bug fix

2024-02-24 Thread José Matos
On Sat, 2024-02-24 at 21:51 +0100, Enrico Forestieri wrote: > Wanting to be very safe, we could use te chardet library for > performing the correct conversion, but if the above is the standard > with python 3 on windows I don't think it is necessary. In [1]: help(str) ... str(object='') -> str str

Re: windows preview bug fix

2024-02-24 Thread Enrico Forestieri
On Sat, Feb 24, 2024 at 01:17:56PM +0200, Idan Pazi wrote: I have sys.flags.utf8_mode = 0. I assume everything is utf8, but I don't think the problem is about finding the right encoding. On the contrary, it is necessary to know the initial encoding of a bytes object for converting it to unic

Re: windows preview bug fix

2024-02-24 Thread Idan Pazi
I have sys.flags.utf8_mode = 0. I assume everything is utf8, but I don't think the problem is about finding the right encoding. win32file.ReadFile returns bytes, which cannot be added (+) to a string (see data = "" at line 162). Assume that on some cases it returns a string, then this patch won'

Re: windows preview bug fix

2024-02-23 Thread José Matos
On Sat, 2024-02-17 at 10:41 +0100, Enrico Forestieri wrote: > On Fri, Feb 16, 2024 at 03:28:25PM +, José Matos wrote: > > > > On Fri, 2024-02-16 at 15:23 +0200, Idan Pazi wrote: > > > > > > Apparently, the returned value from win32file.ReadFile should be > > > converted to a string.  > > > >

Re: windows preview bug fix

2024-02-17 Thread Enrico Forestieri
On Fri, Feb 16, 2024 at 03:28:25PM +, José Matos wrote: On Fri, 2024-02-16 at 15:23 +0200, Idan Pazi wrote: Apparently, the returned value from win32file.ReadFile should be converted to a string.  Fix patch attached. Thank you, Idan What is the encoding of the bytes? Is it UTF8? If so

Re: windows preview bug fix

2024-02-16 Thread José Matos
On Fri, 2024-02-16 at 15:23 +0200, Idan Pazi wrote: > > Apparently, the returned value from win32file.ReadFile should be > converted to a string.  > Fix patch attached. > Thank you, Idan What is the encoding of the bytes? Is it UTF8? If so the patch look right. @Enrico, what do you think? --