Re: unable to navigate

2022-06-29 Thread Kornel Benko
Am Wed, 29 Jun 2022 11:29:18 +0200 schrieb Jean-Marc Lasgouttes : > Le 29/06/2022 à 09:59, Kornel Benko a écrit : > >> I thin the recursion break is just a way to hide the issue. > > > > OK, my try was only to show that omiting the recursion helped. > > Fair enough. > > I was not able to re

Re: unable to navigate

2022-06-29 Thread Jean-Marc Lasgouttes
Le 29/06/2022 à 09:59, Kornel Benko a écrit : I thin the recursion break is just a way to hide the issue. OK, my try was only to show that omiting the recursion helped. Fair enough. I was not able to reproduce this issue. However, does the following patch help? JMarc diff --git a/src/fr

Re: unable to navigate

2022-06-29 Thread Kornel Benko
Am Wed, 29 Jun 2022 09:48:53 +0200 schrieb Jean-Marc Lasgouttes : > Le 29/06/2022 à 09:41, Kornel Benko a écrit : > > I tried to omit recursion in indAndReplaceWidget::eventFilter() > > > > No crash after this. There may be better places though. > > I would try to avoid the creation of a new d

Re: unable to navigate

2022-06-29 Thread Kornel Benko
Am Wed, 29 Jun 2022 09:52:20 +0200 schrieb Jean-Marc Lasgouttes : > Le 29/06/2022 à 08:22, Kornel Benko a écrit : > > Since there seems to be no one using it so extensively as me, this is a good > > approach :) Anyway, this should only apply if findadv dialog has the > > cursor, so a > > mouse-cl

Re: unable to navigate

2022-06-29 Thread Jean-Marc Lasgouttes
Le 29/06/2022 à 08:22, Kornel Benko a écrit : Since there seems to be no one using it so extensively as me, this is a good approach :) Anyway, this should only apply if findadv dialog has the cursor, so a mouse-click seems inevitable anyhow. No it is not required. Assume I am searching someth

Re: unable to navigate

2022-06-29 Thread Jean-Marc Lasgouttes
Le 29/06/2022 à 09:41, Kornel Benko a écrit : I tried to omit recursion in indAndReplaceWidget::eventFilter() No crash after this. There may be better places though. I would try to avoid the creation of a new document class in copy_params. I am not sure why thei is needed. Or at least tell m

Re: unable to navigate

2022-06-29 Thread Kornel Benko
Am Wed, 29 Jun 2022 08:22:31 +0200 schrieb Kornel Benko : > Am Tue, 28 Jun 2022 23:53:32 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 28/06/2022 à 10:13, Kornel Benko a écrit : > > >> For example, some people may want to use the toc to redo a search at a > > >> different place in the documen

Re: unable to navigate

2022-06-28 Thread Kornel Benko
Am Tue, 28 Jun 2022 23:53:32 +0200 schrieb Jean-Marc Lasgouttes : > Le 28/06/2022 à 10:13, Kornel Benko a écrit : > >> For example, some people may want to use the toc to redo a search at a > >> different place in the document. > > > > Setting the cursor manually (mouse click) would help here.

Re: unable to navigate

2022-06-28 Thread Jean-Marc Lasgouttes
Le 28/06/2022 à 10:13, Kornel Benko a écrit : For example, some people may want to use the toc to redo a search at a different place in the document. Setting the cursor manually (mouse click) would help here. You mean that if people have a different use case than yours, they should do extra

Re: unable to navigate

2022-06-28 Thread Kornel Benko
Am Tue, 28 Jun 2022 09:15:58 +0200 schrieb Jean-Marc Lasgouttes : > Le 28/06/2022 à 08:55, Kornel Benko a écrit : > > Yes, except if the saving of actual cursor would also be done. Starts to be > > more > > complicated. Is that even possible? (I mean display document area with the > > cursor not

Re: unable to navigate

2022-06-28 Thread Jean-Marc Lasgouttes
Le 28/06/2022 à 08:55, Kornel Benko a écrit : Yes, except if the saving of actual cursor would also be done. Starts to be more complicated. Is that even possible? (I mean display document area with the cursor not inside) We could have a new paragraph-show lfun that does that (except if cursor

Re: unable to navigate

2022-06-27 Thread Kornel Benko
Am Mon, 27 Jun 2022 16:03:43 +0200 schrieb Jean-Marc Lasgouttes : > Le 25/06/2022 à 22:15, Kornel Benko a écrit : > >>> But works fine if not changing the view. > >>> One comment though: > >>> I'd prefer to not only change focus, but restore the old focus after the > >>> dispatch > >>> (if possib

Re: unable to navigate

2022-06-27 Thread Jean-Marc Lasgouttes
Le 25/06/2022 à 22:15, Kornel Benko a écrit : But works fine if not changing the view. One comment though: I'd prefer to not only change focus, but restore the old focus after the dispatch (if possible of course). Inserting any text after clicking TOC, inserts in the work area and not in the in

Re: unable to navigate

2022-06-27 Thread Jean-Marc Lasgouttes
Le 25/06/2022 à 21:29, Kornel Benko a écrit : Does immediately crash here open lyx with 2 files open findadv dialog, without any other action click on the panel with the non-active workarea ==> crash (does not seem to depend on the patch) But works fine if not changing the view. One comment th

Re: unable to navigate

2022-06-25 Thread Kornel Benko
Am Sat, 25 Jun 2022 22:06:32 +0200 schrieb Jean-Marc Lasgouttes : > Le 25/06/2022 à 21:29, Kornel Benko a écrit : > > Does immediately crash here > > > > open lyx with 2 files > > That is 2 file in two tabs in the same window? Yes. > > open findadv dialog, without any other action > > click

Re: unable to navigate

2022-06-25 Thread Jean-Marc Lasgouttes
Le 25/06/2022 à 21:29, Kornel Benko a écrit : Does immediately crash here open lyx with 2 files That is 2 file in two tabs in the same window? open findadv dialog, without any other action click on the panel with the non-active workarea ==> crash (does not seem to depend on the patch) I'

Re: unable to navigate

2022-06-25 Thread Kornel Benko
Am Sat, 25 Jun 2022 21:29:38 +0200 schrieb Kornel Benko : > Am Sat, 25 Jun 2022 20:57:22 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 21/06/2022 à 22:40, Jean-Marc Lasgouttes a écrit : > > > Here is another possibility. It makes sense, but this is beginning to be > > > too complicated for 2

Re: unable to navigate

2022-06-25 Thread Kornel Benko
Am Sat, 25 Jun 2022 20:57:22 +0200 schrieb Jean-Marc Lasgouttes : > Le 21/06/2022 à 22:40, Jean-Marc Lasgouttes a écrit : > > Here is another possibility. It makes sense, but this is beginning to be > > too complicated for 2.4.0 IMO. It does not work yet for some very > > fundamental reasons.

Re: unable to navigate

2022-06-25 Thread Jean-Marc Lasgouttes
Le 21/06/2022 à 22:40, Jean-Marc Lasgouttes a écrit : Here is another possibility. It makes sense, but this is beginning to be too complicated for 2.4.0 IMO. It does not work yet for some very fundamental reasons. When the solution to a problem is too difficult to obtain, the best is to chang

Re: unable to navigate

2022-06-21 Thread Kornel Benko
Am Tue, 21 Jun 2022 22:40:07 +0200 schrieb Jean-Marc Lasgouttes : > Le 21/06/2022 à 12:55, Kornel Benko a écrit : > > Am Tue, 21 Jun 2022 10:59:40 +0200 > > schrieb Jean-Marc Lasgouttes : > > > >> Le 21/06/2022 à 10:36, Kornel Benko a écrit : > >>> But the point (from my POV) is: > >>> TOC

Re: unable to navigate

2022-06-21 Thread Jean-Marc Lasgouttes
Le 21/06/2022 à 12:55, Kornel Benko a écrit : Am Tue, 21 Jun 2022 10:59:40 +0200 schrieb Jean-Marc Lasgouttes : Le 21/06/2022 à 10:36, Kornel Benko a écrit : But the point (from my POV) is: TOC refers to the document work area, but does not react accordingly. Here is another possib

Re: unable to navigate

2022-06-21 Thread Kornel Benko
Am Tue, 21 Jun 2022 10:59:40 +0200 schrieb Jean-Marc Lasgouttes : > Le 21/06/2022 à 10:36, Kornel Benko a écrit : > > But the point (from my POV) is: > > TOC refers to the document work area, but does not react accordingly. > > I totally agree, but I have not found at this point where this

Re: unable to navigate

2022-06-21 Thread Jean-Marc Lasgouttes
Le 21/06/2022 à 10:36, Kornel Benko a écrit : But the point (from my POV) is: TOC refers to the document work area, but does not react accordingly. I totally agree, but I have not found at this point where this happens. We could try to have TocWidget dispatch to the document bufferview

Re: unable to navigate

2022-06-21 Thread Kornel Benko
Am Tue, 21 Jun 2022 09:12:02 +0200 schrieb Kornel Benko : > Am Mon, 20 Jun 2022 16:33:31 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 18/06/2022 à 11:12, Kornel Benko a écrit : > > > > > > To reproduce: > > > 1.) Open some big lyx-file > > > 2.) Open TOC > > > 3.) Open advanced search dialo

Re: unable to navigate

2022-06-21 Thread Kornel Benko
Am Mon, 20 Jun 2022 16:33:31 +0200 schrieb Jean-Marc Lasgouttes : > Le 18/06/2022 à 11:12, Kornel Benko a écrit : > > > > To reproduce: > > 1.) Open some big lyx-file > > 2.) Open TOC > > 3.) Open advanced search dialog > > 4.) Search for some existing string > > --> The page containing the

Re: unable to navigate

2022-06-20 Thread Jean-Marc Lasgouttes
Le 18/06/2022 à 11:12, Kornel Benko a écrit : To reproduce: 1.) Open some big lyx-file 2.) Open TOC 3.) Open advanced search dialog 4.) Search for some existing string --> The page containing the string is now visible 5.) try to use TOC to navigate --> The view does not change. 6