Juergen Spitzmueller wrote:
Edwin Leuven wrote:
does the silence mean that this is uncontroversial?
No objections from me anyway.
will commit soon
Edwin Leuven wrote:
> does the silence mean that this is uncontroversial?
No objections from me anyway.
Jürgen
Edwin Leuven wrote:
edwin leuven wrote:
> there is too much drawing going on in tabulars
>
> avoids updates on
>
> 1. mouse click (without selection)
> 2. mouse movements (when selection doesn't change)
>
> esp 2 triggers a lot of redraws
the attached patch takes into account a possible
edwin leuven wrote:
> there is too much drawing going on in tabulars
>
> avoids updates on
>
> 1. mouse click (without selection)
> 2. mouse movements (when selection doesn't change)
>
> esp 2 triggers a lot of redraws
the attached patch takes into account a possible depm update on
mouseclick as
Edwin Leuven wrote:
Abdelrazak Younes wrote:
This is really something that should be cleaned up. I don't understand
the "just to be sure" argument in a software that is by definition
deterministic ;-)
i should remind you that it is friday...
Indeed... I am just coming back so for me it is M
Juergen Spitzmueller wrote:
Jean-Marc Lasgouttes wrote:
Juergen> Less, slightly clearer code.
It is not worth doing it, then. I hope this branch will be short-lived
:)
OK. I did it in trunk, though. I investigated why the bvcur setting was
introduced (by André), and verified that problem di
Abdelrazak Younes wrote:
This is really something that should be cleaned up. I don't understand
the "just to be sure" argument in a software that is by definition
deterministic ;-)
i should remind you that it is friday...
Jean-Marc Lasgouttes wrote:
"Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Indeed, but it does not only care for dEPM, but also if the
Juergen> cursor is valid. I wonder, though, if the explicit set of
Juergen> bvcursor is not redundand now.
It may be interesting to exp
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> OK. I did it in trunk, though. I investigated why the bvcur
Juergen> setting was introduced (by André), and verified that problem
Juergen> did not reoccur (viz. font change over multiple cells
Juergen> crashed).
Thanks.
Jean-Marc Lasgouttes wrote:
> Juergen> Less, slightly clearer code.
>
> It is not worth doing it, then. I hope this branch will be short-lived
>
> :)
OK. I did it in trunk, though. I investigated why the bvcur setting was
introduced (by André), and verified that problem did not reoccur (viz. font
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: So shall we risk it for 1.4?
>> What do we gain?
Juergen> Less, slightly clearer code.
It is not worth doing it, then. I hope this branch will be short-lived
:)
JMarc
Jean-Marc Lasgouttes wrote:
> Juergen> So shall we risk it for 1.4?
>
> What do we gain?
Less, slightly clearer code.
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> I think it is enough.
Juergen> So shall we risk it for 1.4?
What do we gain?
JMarc
Jean-Marc Lasgouttes wrote:
> I think it is enough.
So shall we risk it for 1.4?
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> I commented those lines out and didn't see any bad effects at
Juergen> first glance. It looks like this:
[...]
Juergen> while BufferView::mouseSetCursor does:
[...]
Juergen> so cur.bv().cursor() is set in mouseSetCursor.
Jean-Marc Lasgouttes wrote:
> Juergen> Indeed, but it does not only care for dEPM, but also if the
> Juergen> cursor is valid. I wonder, though, if the explicit set of
> Juergen> bvcursor is not redundand now.
>
> It may be interesting to experiment.
I commented those lines out and didn't see any
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Indeed, but it does not only care for dEPM, but also if the
Juergen> cursor is valid. I wonder, though, if the explicit set of
Juergen> bvcursor is not redundand now.
It may be interesting to experiment.
>> But I guess
Jean-Marc Lasgouttes wrote:
> Juergen> Jean-Marc, would this be o.k. for 1.4?
>
> Yes, except that it is a bit weird to add the setCursor just for the
> depm part (and not really to set the cursor).
Indeed, but it does not only care for dEPM, but also if the cursor is valid. I
wonder, though, if
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc, would this be o.k. for 1.4?
Yes, except that it is a bit weird to add the setCursor just for the
depm part (and not really to set the cursor).
But I guess it is not worse than other parts of the code, so go a
Juergen Spitzmueller wrote:
> Indeed, dePM is not triggered at all with the mouse in tabular cells, which
> is a bug (also in 1.4 btw).
This patch fixes that for 1.4. For 1.5, you'll have to do something like
if (cmd.button() == mouse_button::button1
|| (cmd.b
edwin leuven wrote:
> the space is not removed, but it turns out that this is independent of the
> patch!
Indeed, dePM is not triggered at all with the mouse in tabular cells, which is
a bug (also in 1.4 btw).
I think you'll have to use bv->mouseSetCursor(cur); inside LFUN_MOUSE_PRESS in
insett
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
> in a tabular cell, type
> "foo bar"
> then set the cursor after "foo" and type in another space (you have "foo
> bar"
> then)
> Now click somewhere in the line (so that the superfluous space is removed by
> dePM).
the space is not removed, but
edwin leuven wrote:
> > 1. we have two consecutive spaces
>
> not sure i follow you here... can u give me a recipe?
in a tabular cell, type
"foo bar"
then set the cursor after "foo" and type in another space (you have "foo bar"
then)
Now click somewhere in the line (so that the superfluous space
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
> Agreed, but I think we need to redraw when:
>
> 1. we have two consecutive spaces
not sure i follow you here... can u give me a recipe?
> and we click somewhere so that dePM triggers
> 2. we have an empty paragraph and we do the above
>
> I'm p
edwin leuven wrote:
> i tried it and i don't observe any problems and think this should go in (we
> don't want to redraw the table 50 times when setting a selection...)
Agreed, but I think we need to redraw when:
1. we have two consecutive spaces and we click somewhere so that dePM triggers
2. we
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
> take care that dePM doesn't bite you (in fixed with columns).
i tried it and i don't observe any problems and think this should go in (we
don't want to redraw the table 50 times when setting a selection...)
jose...?
(1.4.x could also benefit i t
edwin leuven wrote:
> avoids updates on
>
> 1. mouse click (without selection)
take care that dePM doesn't bite you (in fixed with columns).
Jürgen
27 matches
Mail list logo
