Vincent van Ravesteijn wrote:
> I committed what works for me. I had it in my tree anyway.
i suspected something like that, thanks
ed.
On Sun, Oct 24, 2010 at 22:45, Vincent van Ravesteijn wrote:
>> Another point is that if for some reason the Inset moves or gets
>> deleted while the fingerpointing cursor is there, the mouse cursor is
>> not updated.
>>
>
> This can be solved by adding another call to setCursorShape in
> GuIWorka
> Another point is that if for some reason the Inset moves or gets
> deleted while the fingerpointing cursor is there, the mouse cursor is
> not updated.
>
This can be solved by adding another call to setCursorShape in
GuIWorkarea::redraw().
Vincent
>+ /// are we hovering something that we can click
>+ bool clickableinset_;
>
I would prefer "bool clickable_inset_;".
> void BufferView::updateHoveredInset() const
> {
>+ d->clickableinset_ = false;
>+
[...]
>+
>+ if (covering_inset && covering_inset->asInsetCollapsable()) {
Vincent van Ravesteijn wrote:
> [comments]
i'm glad that i at least anticipated 50% of your comments ;-)
the attached also gets rid of the early return and moves the flag to
BufferView::Private
...
ed.
hover2.patch
Description: Binary data
> comments? ok to put in?
>
> ed.
>
>+ int const x = d->mouse_position_cache_.x_;
>+ int const y = d->mouse_position_cache_.y_;
>+ Inset const * covering_inset = getCoveringInset(buffer_.text(), x, y);
>+ if (!covering_inset)
>+ return;
>+
No, .. the rest of the
Edwin Leuven wrote:
> Abdelrazak Younes wrote:
>>
>> Quite easy actually but nothing to do with Peter's changes. Mouse hovering
>> is already detected in BufferView::updateHoveredInset() and
>> BufferView::mouseEventDispatch(). So I guess that merely setting a flag in
>> BufferView::updateHovered
Abdelrazak Younes wrote:
>
> Quite easy actually but nothing to do with Peter's changes. Mouse hovering
> is already detected in BufferView::updateHoveredInset() and
> BufferView::mouseEventDispatch(). So I guess that merely setting a flag in
> BufferView::updateHoveredInset() when we are over a c
Peter Kümmel wrote:
> But I wonder if there are still active developers who
> insist on this toolkit-agnostic design.
it depends what particularly are you asking about. i have never perceived
anybody thinking about reintroducing framework for having more frontends. last
such frontend-design flame
Abdelrazak Younes wrote:
>
> Quite easy actually but nothing to do with Peter's changes. Mouse hovering
> is already detected in BufferView::updateHoveredInset() and
> BufferView::mouseEventDispatch(). So I guess that merely setting a flag in
> BufferView::updateHoveredInset() when we are over a c
Am Samstag, den 23.10.2010, 22:27 +0200 schrieb Abdelrazak Younes:
> On 23/10/2010 21:42, Peter Kümmel wrote:
> > Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven:
> >
> >> Peter Kuemmel committed:
> >>
> >>> http://www.lyx.org/trac/changeset/35795
> >>>
> >> peter, af
Am Samstag, den 23.10.2010, 22:48 +0200 schrieb Peter Kümmel:
> Am Samstag, den 23.10.2010, 21:57 +0200 schrieb Pavel Sanda:
> > Peter Kümmel wrote:
> > > There will be never a gtk based gui.
> >
> > dont you know the plans about ncurses-lyx? :)
>
> I thought there are plans for ASCII-only termi
Am Samstag, den 23.10.2010, 21:57 +0200 schrieb Pavel Sanda:
> Peter Kümmel wrote:
> > There will be never a gtk based gui.
>
> dont you know the plans about ncurses-lyx? :)
I thought there are plans for ASCII-only terminals :)
> pavel
But I wonder if there are still active developers who
ins
Am Samstag, den 23.10.2010, 22:27 +0200 schrieb Abdelrazak Younes:
> On 23/10/2010 21:42, Peter Kümmel wrote:
> > Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven:
> >
> >> Peter Kuemmel committed:
> >>
> >>> http://www.lyx.org/trac/changeset/35795
> >>>
> >> peter, af
Am Samstag, den 23.10.2010, 21:57 +0200 schrieb Pavel Sanda:
> Peter Kümmel wrote:
> > There will be never a gtk based gui.
>
> dont you know the plans about ncurses-lyx? :)
I thought there are plans for ASCII-only terminals :)
> pavel
But I wonder if there are still active developers who
insis
On 23/10/2010 21:42, Peter Kümmel wrote:
Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven:
Peter Kuemmel committed:
http://www.lyx.org/trac/changeset/35795
peter, after your commit, how easy would it be to change the mouse
cursor to Qt::PointingHandCursor when hov
On 23/10/2010 18:21, Edwin Leuven wrote:
Peter Kuemmel committed:
http://www.lyx.org/trac/changeset/35795
peter, after your commit, how easy would it be to change the mouse
cursor to Qt::PointingHandCursor when hovering a clickable inset?
Quite easy actually but nothing to do wi
Peter Kümmel wrote:
> There will be never a gtk based gui.
dont you know the plans about ncurses-lyx? :)
pavel
Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven:
> Peter Kuemmel committed:
> > http://www.lyx.org/trac/changeset/35795
>
> peter, after your commit, how easy would it be to change the mouse
> cursor to Qt::PointingHandCursor when hovering a clickable inset?
>
> thanks, edwin
Sorry,
Peter Kuemmel committed:
> http://www.lyx.org/trac/changeset/35795
peter, after your commit, how easy would it be to change the mouse
cursor to Qt::PointingHandCursor when hovering a clickable inset?
thanks, edwin
20 matches
Mail list logo
