Re: signedness problem

2007-03-24 Thread Abdelrazak Younes
Georg Baum wrote: Abdel, can you please fix this one? I'll fix that. Abdel. g++ -DHAVE_CONFIG_H -I. -I../../../../src/frontends/controllers -I../../../src -Winvalid-pch --include=../../../../src/frontends/controllers/pch.h -I../../../../src -I../../../../boost -Wextra -Wall -fmessage-length

Re: signedness problem

2006-06-26 Thread Peter Kümmel
Georg Baum wrote: > Peter Kümmel wrote: > >> Yes, a simplest and good solution, 0 would never be a saved size of a >> window. Peter > > And even if it would it should be ignored. I guess that there is a sensible > minimum size in qt itself? Yes, I also think so. And the variables are initialized

Re: signedness problem

2006-06-26 Thread Georg Baum
Peter Kümmel wrote: > Yes, a simplest and good solution, 0 would never be a saved size of a > window. Peter And even if it would it should be ignored. I guess that there is a sensible minimum size in qt itself? Georg

Re: signedness problem

2006-06-26 Thread Peter Kümmel
Bo Peng wrote: >> Originally I've passed an additional parameter for the geometry option, >> but then we've decided to pass -1. Then I have to patch it like this: >> >> Is this really better than an additional parameter? > > I suggested -1, -1, as an example to invalidate width/height when > geome

Re: signedness problem

2006-06-26 Thread Bo Peng
Originally I've passed an additional parameter for the geometry option, but then we've decided to pass -1. Then I have to patch it like this: Is this really better than an additional parameter? I suggested -1, -1, as an example to invalidate width/height when geometry option is present. In thi

Re: signedness problem

2006-06-26 Thread Peter Kümmel
Peter Kümmel wrote: > Georg Baum wrote: >> In src/lyx_main.C lines 340-341 two unsigned variables are set to -1 and >> afterwards passed to the lyx_gui::start function which takes unsigned >> arguments. >> I forgot who did this change, but could this person please fix the problem? >> >> >> Thanks,

Re: signedness problem

2006-06-26 Thread Peter Kümmel
Georg Baum wrote: > In src/lyx_main.C lines 340-341 two unsigned variables are set to -1 and > afterwards passed to the lyx_gui::start function which takes unsigned > arguments. > I forgot who did this change, but could this person please fix the problem? > > > Thanks, > Georg > > Sorry, this