Re: signed/unsigned match

2006-06-07 Thread Peter Kümmel
Angus Leeming wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: >> Angus Leeming wrote: >>> So, what is the usage you're worried about and where? Which constructor? > > [snip supplied details] > >> As I understand we have to be sure that the this pointer is not >> used, if so all is ok. > > Grea

Re: signed/unsigned match

2006-06-07 Thread Angus Leeming
Peter Kümmel <[EMAIL PROTECTED]> writes: > Angus Leeming wrote: > > So, what is the usage you're worried about and where? Which constructor? [snip supplied details] > As I understand we have to be sure that the this pointer is not > used, if so all is ok. Great detective work! Angus

Re: signed/unsigned match

2006-06-07 Thread Peter Kümmel
Angus Leeming wrote: > So, what is the usage you're worried about and where? Which constructor? LyXServer(LyXFunc * f, std::string const & pip) : numclients(0), func(f), pipes(pip, (this), callback) {} Buffer::Buffer(string const & file, bool readonly) : pimpl_(new Impl(*this, file, reado

Re: signed/unsigned match

2006-06-07 Thread Angus Leeming
Peter Kümmel <[EMAIL PROTECTED]> writes: > After disabling the "performance warning" > (it's realy not worth the trouble) As you choose. But wrapping them all as "return bool(foo);" would be perfectly fine I think. > here some unsigned/unsigned patches. Look good. It would appear that the "//Bra