Re: rows() availability problem of multiple window is fixed.

2006-12-16 Thread Abdelrazak Younes
Michael Gerz wrote: Abdelrazak Younes wrote: But let me advice you to use the step by step debugger. It helps a lot in finding bugs like this. OK, I grant you that I knew in advance that it was a matter of redundant update() calls but knowing where this call was was easy to find out: I just h

Re: rows() availability problem of multiple window is fixed.

2006-12-16 Thread Michael Gerz
Abdelrazak Younes wrote: But let me advice you to use the step by step debugger. It helps a lot in finding bugs like this. OK, I grant you that I knew in advance that it was a matter of redundant update() calls but knowing where this call was was easy to find out: I just had to put a break poi

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: But let me advice you to use the step by step debugger. It is more a matter of knowing the code than the use of a debugger, but I agree with you that VS debugger is useful to know which part of the code is involved. The problem is that I am still a 99% linux user, despite the fa

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Bo Peng
But let me advice you to use the step by step debugger. It is more a matter of knowing the code than the use of a debugger, but I agree with you that VS debugger is useful to know which part of the code is involved. The problem is that I am still a 99% linux user, despite the fact that I am cla

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: I have tested that and it works fine so I committed it. Happy Bo? Not exactly. I spent a day on this issue (and filed WONTFIX) Just look at the good side: you now know a lot more about metrics and I am very happy about that. and you fixed it in five minutes? :-) Georg sa

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: Indeed, this is because there's a second update() call in workAreaResize(), the attached is solving that. Confirmed to work, do you want me to commit it? I did that already. Abdel.

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Bo Peng
I have tested that and it works fine so I committed it. Happy Bo? Not exactly. I spent a day on this issue (and filed WONTFIX) and you fixed it in five minutes? :-) Bo

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: Sure, just replace update() with updateMetrics(false) in the resize method. Does not work. Please have a look with 1. start lyx, open tutorial 2. scroll down with mouse (not page down) 3. resize. lyx should not scroll back to textcursor. Indeed, th

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Bo Peng
Indeed, this is because there's a second update() call in workAreaResize(), the attached is solving that. Confirmed to work, do you want me to commit it? Bo

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: Sure, just replace update() with updateMetrics(false) in the resize method. Does not work. Please have a look with 1. start lyx, open tutorial 2. scroll down with mouse (not page down) 3. resize. lyx should not scroll back to textcursor. Indeed, this is because there's a se

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Bo Peng
Sure, just replace update() with updateMetrics(false) in the resize method. Does not work. Please have a look with 1. start lyx, open tutorial 2. scroll down with mouse (not page down) 3. resize. lyx should not scroll back to textcursor. Bo

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: FYI, I put the resize trick in order to avoid crash when switching between windows showing the same Buffer. I figured it out later. (Cut a comment in the resize function would be helpful.) Well, there is a big FIXME explaining that in GuiWorkArea::focusInEvent() I think. Feel

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Bo Peng
FYI, I put the resize trick in order to avoid crash when switching between windows showing the same Buffer. I figured it out later. (Cut a comment in the resize function would be helpful.) This resize triggers a full update and moves the screen to fit the textcursor. This makes cursor navigation

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: The problem is found: switching window focus triggers a resize and a forced update, which then scrolls the window back to its text cursor position. This is not needed since windows size is not changed. This can not be fixed now since a resize is needed when switching between wind

Re: rows() availability problem of multiple window is fixed.

2006-12-15 Thread Abdelrazak Younes
Bo Peng wrote: Another related problem is that when the mouse click back, lyx scrolls back to the paragraph with the text cursor. I am having a look at it. This one is weird and I have not found the problem. Symptom: 1. start lyx, open a doc, open another window 2. from window A, click at par

Re: rows() availability problem of multiple window is fixed.

2006-12-14 Thread Bo Peng
The problem is found: switching window focus triggers a resize and a forced update, which then scrolls the window back to its text cursor position. This is not needed since windows size is not changed. This can not be fixed now since a resize is needed when switching between windows. Status.15x

Re: rows() availability problem of multiple window is fixed.

2006-12-14 Thread Bo Peng
Symptom: 1. start lyx, open a doc, open another window 2. from window A, click at paragraph X, scroll down to paragraph Y. 3. go to window B, click, and return focus to window A 4. when mouse moves, lyx finds the correct pit Y under mouse, click, lyx finds pit for paragraph X and scroll back to pa

Re: rows() availability problem of multiple window is fixed.

2006-12-13 Thread Angus Leeming
Bo Peng wrote: Another related problem is that when the mouse click back, lyx scrolls back to the paragraph with the text cursor. I am having a look at it. This one is weird and I have not found the problem. Symptom: 1. start lyx, open a doc, open another window 2. from window A, click at p

Re: rows() availability problem of multiple window is fixed.

2006-12-13 Thread Bo Peng
Another related problem is that when the mouse click back, lyx scrolls back to the paragraph with the text cursor. I am having a look at it. This one is weird and I have not found the problem. Symptom: 1. start lyx, open a doc, open another window 2. from window A, click at paragraph X, scroll