Doesn't my proposed fix nevertheless do the right thing in this
case? I.e.,
move it from .h to .cpp and make it return false for comment and
greyedout.
Yes it does. Nevertheless, I'd prefer to keep a method with the same
semantics that what we have now,
because it is used (or it should be u
On Sat, Nov 29, 2008 at 10:47:50PM +0100, Jean-Marc Lasgouttes wrote:
> >> ...and reverting is rather a blunt instrument when you could have fixed
> >>
> >> bool producesOutput() const { return false; }
> >>
> >> in InsetNote.h -- in the sense that yes, in some cases a Note _does_
> >> pro
> I can understand that _some_ greyed out notes are broken, but why
are comments broken?
But _every_ is correct. Every document that contains greyed-out
cannot be compiled because your change omitted the needed preamble
code. For an unknown reason I then get also error messages that the
c
...and reverting is rather a blunt instrument when you could have
fixed
bool producesOutput() const { return false; }
in InsetNote.h -- in the sense that yes, in some cases a Note
_does_ produce
LaTeX output ;-)
I suppose this is Richard's turf.
No, this isn't anything I know abo
Martin Vermeer wrote:
On Sat, Nov 29, 2008 at 03:17:23PM +0100, Uwe Stöhr wrote:
Fair enough, although discussion about the scope of the problem would be
easier if you avoided
broad generalizations like "breaks _every_ document that...".
I can understand that _some_ greyed out
Martin Vermeer schrieb:
...and reverting is rather a blunt instrument when you could have fixed
bool producesOutput() const { return false; }
in InsetNote.h -- in the sense that yes, in some cases a Note _does_ produce
LaTeX output ;-)
This change caused a nasty regression, and we wa
On Sat, Nov 29, 2008 at 03:17:23PM +0100, Uwe Stöhr wrote:
> > Fair enough, although discussion about the scope of the problem would be
> easier if you avoided
> > broad generalizations like "breaks _every_ document that...".
> >
> > I can understand that _some_ greyed out notes are broken, but wh
> Fair enough, although discussion about the scope of the problem would be
easier if you avoided
> broad generalizations like "breaks _every_ document that...".
>
> I can understand that _some_ greyed out notes are broken, but why are
comments broken?
But _every_ is correct. Every document that
Le 29 nov. 08 à 01:27, Uwe Stöhr a écrit :
http://www.lyx.org/trac/changeset/27719 breaks every document that
uses comments and/or greyed out notes.
This is a regression to LyX 1.6.0 so I reverted it for now in trunk
and branch.
Fair enough, although discussion about the scope of the problem
