Re: r37945 - lyx-devel/trunk/src/frontends/qt4

2011-03-19 Thread Stephan Witt
Am 18.03.2011 um 21:58 schrieb Andre Poenitz: > On Fri, Mar 18, 2011 at 09:45:32AM +0100, Jean-Marc Lasgouttes wrote: >> Le 18/03/2011 02:28, rgh...@lyx.org a écrit : >>> availableLV->installEventFilter(this); >>> selectedLV->installEventFilter(this); >>> + selectedHasFocus_ = false; >>>

Re: r37945 - lyx-devel/trunk/src/frontends/qt4

2011-03-19 Thread Jean-Marc Lasgouttes
Le 18/03/11 21:58, Andre Poenitz a écrit : Thanks. Note that, since this is a constructor, we are supposed to initialize this variable (and the others that predated your change) using the selectedHasFocus_(false) idiom. I am not sure what this buys us, though. Nothing in case of simple types, a

Re: r37945 - lyx-devel/trunk/src/frontends/qt4

2011-03-18 Thread Andre Poenitz
On Fri, Mar 18, 2011 at 09:45:32AM +0100, Jean-Marc Lasgouttes wrote: > Le 18/03/2011 02:28, rgh...@lyx.org a écrit : > > availableLV->installEventFilter(this); > > selectedLV->installEventFilter(this); > >+selectedHasFocus_ = false; > > } > > Thanks. Note that, since this is a constr

Re: r37945 - lyx-devel/trunk/src/frontends/qt4

2011-03-18 Thread Richard Heck
On 03/18/2011 04:45 AM, Jean-Marc Lasgouttes wrote: Le 18/03/2011 02:28, rgh...@lyx.org a écrit : availableLV->installEventFilter(this); selectedLV->installEventFilter(this); +selectedHasFocus_ = false; } Thanks. Note that, since this is a constructor, we are supposed to ini

Re: r37945 - lyx-devel/trunk/src/frontends/qt4

2011-03-18 Thread Jean-Marc Lasgouttes
Le 18/03/2011 02:28, rgh...@lyx.org a écrit : availableLV->installEventFilter(this); selectedLV->installEventFilter(this); + selectedHasFocus_ = false; } Thanks. Note that, since this is a constructor, we are supposed to initialize this variable (and the others that pre