Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-08-09 Thread Richard Heck
On 08/09/2011 05:31 PM, Pavel Sanda wrote: > Vincent van Ravesteijn wrote: >>> Author: vfr >>> - string const s = cmd.getArg(1); >>> // FIXME: We only check for the very first argument... >>> + string const s = cmd.getArg(1); >>> + // We always enable the l

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-08-09 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >> Author: vfr >> -string const s = cmd.getArg(1); >> // FIXME: We only check for the very first argument... >> +string const s = cmd.getArg(1); >> +// We always enable the lfun if it is coming from the dialog >> +

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-08-09 Thread Vincent van Ravesteijn
Op 17-2-2011 0:09, v...@lyx.org schreef: Author: vfr Date: Thu Feb 17 00:09:29 2011 New Revision: 37706 URL: http://www.lyx.org/trac/changeset/37706 Log: Fix bug #7308: Table settings dialog broken. Modified: lyx-devel/trunk/src/frontends/qt4/GuiTabular.cpp lyx-devel/trunk/src/insets/In

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-17 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Op 17-2-2011 22:52, Pavel Sanda schreef: >> v...@lyx.org wrote: >>> Author: vfr >>> Date: Thu Feb 17 00:09:29 2011 >>> New Revision: 37706 >>> URL: http://www.lyx.org/trac/changeset/37706 >>> >>> Log: >>> Fix bug #7308: Table settings dialog broken. >>> >>> // F

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-17 Thread Vincent van Ravesteijn
Op 17-2-2011 22:52, Pavel Sanda schreef: v...@lyx.org wrote: Author: vfr Date: Thu Feb 17 00:09:29 2011 New Revision: 37706 URL: http://www.lyx.org/trac/changeset/37706 Log: Fix bug #7308: Table settings dialog broken. // FIXME: We should use Tabular directly. - string param_str

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-17 Thread Pavel Sanda
v...@lyx.org wrote: > Author: vfr > Date: Thu Feb 17 00:09:29 2011 > New Revision: 37706 > URL: http://www.lyx.org/trac/changeset/37706 > > Log: > Fix bug #7308: Table settings dialog broken. > > // FIXME: We should use Tabular directly. > - string param_str = "tabular"; > + string

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-16 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 12:23:41AM +0100, Vincent van Ravesteijn wrote: > Op 17-2-2011 0:22, Enrico Forestieri schreef: > >On Thu, Feb 17, 2011 at 12:09:29AM +0100, v...@lyx.org wrote: > >>Author: vfr > >>Date: Thu Feb 17 00:09:29 2011 > >>New Revision: 37706 > >>URL: http://www.lyx.org/trac/chang

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-16 Thread Vincent van Ravesteijn
Op 17-2-2011 0:22, Enrico Forestieri schreef: On Thu, Feb 17, 2011 at 12:09:29AM +0100, v...@lyx.org wrote: Author: vfr Date: Thu Feb 17 00:09:29 2011 New Revision: 37706 URL: http://www.lyx.org/trac/changeset/37706 Log: Fix bug #7308: Table settings dialog broken. Previous fix was just fine.

Re: r37706 - in lyx-devel/trunk/src: frontends/qt4 insets

2011-02-16 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 12:09:29AM +0100, v...@lyx.org wrote: > Author: vfr > Date: Thu Feb 17 00:09:29 2011 > New Revision: 37706 > URL: http://www.lyx.org/trac/changeset/37706 > > Log: > Fix bug #7308: Table settings dialog broken. Previous fix was just fine. I am considering to revert this and