Re: r35040 - lyx-devel/trunk/src/frontends/qt4

2010-08-03 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Yes, but if you find the first solution more readable, you can keep > it... > (now that I see it, I am not sure that it is much of a gain) After looking at the two versions, I think I prefer the first solution. Jürgen

Re: r35040 - lyx-devel/trunk/src/frontends/qt4

2010-08-02 Thread Jean-Marc Lasgouttes
Le 2 août 10 à 19:29, Jürgen Spitzmüller a écrit : Why not factor " Warning" out of the parenthesis? You mean QRegExp exprWarning("^(LaTeX|LaTeX Font|Package [\\w\\.]+|Class \\w+) Warning.*$"); ? (sorry, I'm not so good at regexing). Yes, but if you find the first solution more readable, you

Re: r35040 - lyx-devel/trunk/src/frontends/qt4

2010-08-02 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > -QRegExp exprWarning("^(LaTeX Warning|Package \\w+ Warning).*$"); > > +QRegExp exprWarning("^(LaTeX Warning|LaTeX Font Warning|Package [\\w > > \\.]+ Warning|Class \\w+ Warning).*$"); > > Why not factor " Warning" out of the parenthesis? You mean QRegExp exprWarni

Re: r35040 - lyx-devel/trunk/src/frontends/qt4

2010-08-02 Thread Jean-Marc Lasgouttes
Log: * GuiLog.cpp: refine warning detection: - detect "LaTeX Font Warning" - detect "Class X Warning" - package warnings can contain dots ("Package pdftex.def Warning") -QRegExp exprWarning("^(LaTeX Warning|Package \\w+ Warning).*$"); +QRegExp exprWarning("^(LaTeX Warning|

Re: r35040 - lyx-devel/trunk/src/frontends/qt4

2010-08-02 Thread Jürgen Spitzmüller
spitz wrote: > Author: spitz > Date: Mon Aug 2 18:38:41 2010 > New Revision: 35040 > URL: http://www.lyx.org/trac/changeset/35040 > > Log: > * GuiLog.cpp: refine warning detection: > - detect "LaTeX Font Warning" > - detect "Class X Warning" > - package warnings can contai