On Sun, Jul 18, 2010 at 08:44:48AM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> >> But we could have made a copy of the output for the terminal. If this is
> >> the only remaining issue, then your time was not lost.
> >
> > I think the issue is now fixed.
> >
>
> Ver good, reading yo
Enrico Forestieri wrote:
>> But we could have made a copy of the output for the terminal. If this is
>> the only remaining issue, then your time was not lost.
>
> I think the issue is now fixed.
>
Ver good, reading your log message I thought you've given up ;)
Peter
On Fri, Jul 16, 2010 at 04:45:59PM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> > On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> >> void SystemcallPrivate::flush()
> >> {
> >>if (process_) {
> >>// If the output has been redirected, we write it all at onc
On Fri, Jul 16, 2010 at 04:38:36PM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> > On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> >> void SystemcallPrivate::flush()
> >> {
> >>if (process_) {
> >>// If the output has been redirected, we write it all at onc
Enrico Forestieri wrote:
> On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
>> void SystemcallPrivate::flush()
>> {
>> if (process_) {
>> // If the output has been redirected, we write it all at once.
>> // Even if we are not running in a terminal, the ou
Peter Kümmel wrote:
> Pavel Sanda wrote:
> > Enrico Forestieri wrote:
> >> On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> >>> void SystemcallPrivate::flush()
> >>> {
> >>> if (process_) {
> >>> // If the output has been redirected, we write it all at once.
> >>>
Pavel Sanda wrote:
> Enrico Forestieri wrote:
>> On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
>>> void SystemcallPrivate::flush()
>>> {
>>> if (process_) {
>>> // If the output has been redirected, we write it all at once.
>>> // Even if we are not runni
Enrico Forestieri wrote:
> On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
>> void SystemcallPrivate::flush()
>> {
>> if (process_) {
>> // If the output has been redirected, we write it all at once.
>> // Even if we are not running in a terminal, the ou
On Fri, Jul 16, 2010 at 04:11:13PM +0200, Pavel Sanda wrote:
> Enrico Forestieri wrote:
> > On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> > >
> > > void SystemcallPrivate::flush()
> > > {
> > > if (process_) {
> > > // If the output has been redirected, we write it al
Enrico Forestieri wrote:
> On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> >
> > void SystemcallPrivate::flush()
> > {
> > if (process_) {
> > // If the output has been redirected, we write it all at once.
> > // Even if we are not running in a terminal,
On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
>
> void SystemcallPrivate::flush()
> {
> if (process_) {
> // If the output has been redirected, we write it all at once.
> // Even if we are not running in a terminal, the output could go
>
On Fri, Jul 16, 2010 at 12:08:21PM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> > On Fri, Jul 16, 2010 at 11:31:02AM +0200, Peter Kümmel wrote:
> >> Enrico Forestieri wrote:
> >> >>> ///
> > - bool showerr_;
> > + bool terminalOutExists_;
> terminal_out_ex
Enrico Forestieri wrote:
> On Fri, Jul 16, 2010 at 11:31:02AM +0200, Peter Kümmel wrote:
>> Enrico Forestieri wrote:
>> >>> ///
> - bool showerr_;
> + bool terminalOutExists_;
terminal_out_exists_
>>> stdout_exists_
>> Hope attached patch makes the code more readable.
>
> Yes
>
>> Index: Systemcall.cpp
>> ===
>> --- Systemcall.cpp (Revision 34914)
>> +++ Systemcall.cpp (Arbeitskopie)
>> @@ -246,16 +246,24 @@
>> out_index_(0),
>> err_ind
Enrico Forestieri wrote:
> On Fri, Jul 16, 2010 at 11:15:25AM +0200, Peter Kümmel wrote:
>> Enrico Forestieri wrote:
>>> @@ -254,6 +254,8 @@
>>> // Check whether we have to simply throw away the output.
>>> if (out_file_ != os::nulldev())
>>> process_->se
On Fri, Jul 16, 2010 at 11:31:02AM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> >>> ///
> >>> - bool showerr_;
> >>> + bool terminalOutExists_;
> >> terminal_out_exists_
> >
> > stdout_exists_
>
> Hope attached patch makes the code more readable.
Yes, I think so, but see bel
On Fri, Jul 16, 2010 at 11:15:25AM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
> > @@ -254,6 +254,8 @@
> > // Check whether we have to simply throw away the output.
> > if (out_file_ != os::nulldev())
> > process_->setStandardOutputFile(toqstr(o
Enrico Forestieri wrote:
>>>///
>>> - bool showerr_;
>>> + bool terminalOutExists_;
>> terminal_out_exists_
>
> stdout_exists_
Hope attached patch makes the code more readable.
But why do we ignore the terminal settings in flush() ?
Peter
Index: Systemcall.cpp
=
Am Freitag 16 Juli 2010 schrieb Enrico Forestieri:
> On Fri, Jul 16, 2010 at 10:38:09AM +0200, Kornel Benko wrote:
> > I am always collecting the output in a file ( == redirecting) to be able
> > to analyse the output later. Since I have many debug-keys enabled, the
> > output is huge.
> >
> > Not
Enrico Forestieri wrote:
> @@ -254,6 +254,8 @@
> // Check whether we have to simply throw away the output.
> if (out_file_ != os::nulldev())
> process_->setStandardOutputFile(toqstr(out_file_));
> + // Don't output to terminal if stdout
On Fri, Jul 16, 2010 at 10:38:09AM +0200, Kornel Benko wrote:
>
> I am always collecting the output in a file ( == redirecting) to be able to
> analyse the output later.
> Since I have many debug-keys enabled, the output is huge.
>
> Not happy with disabling redirected output :(
I think you did
Am Freitag 16 Juli 2010 schrieb Enrico Forestieri:
> On Fri, Jul 16, 2010 at 07:55:32AM +0200, kuem...@lyx.org wrote:
> > Author: kuemmel
> > Date: Fri Jul 16 07:55:31 2010
> > New Revision: 34910
> > URL: http://www.lyx.org/trac/changeset/34910
> >
> > Log:
> > only guard terminal output.
> >
>
On Fri, Jul 16, 2010 at 10:22:54AM +0200, Peter Kümmel wrote:
> Enrico Forestieri wrote:
>
> >> -SystemcallPrivate::SystemcallPrivate(const std::string& of) :
> >> +SystemcallPrivate::SystemcallPrivate(const std::string& of) :
> >> proc_(new QProcess), outindex_(0
Enrico Forestieri wrote:
>> -SystemcallPrivate::SystemcallPrivate(const std::string& of) :
>> +SystemcallPrivate::SystemcallPrivate(const std::string& of) :
>> proc_(new QProcess), outindex_(0),
>> errindex_(0),
>> -outfile(of), sh
On Fri, Jul 16, 2010 at 07:55:32AM +0200, kuem...@lyx.org wrote:
> Author: kuemmel
> Date: Fri Jul 16 07:55:31 2010
> New Revision: 34910
> URL: http://www.lyx.org/trac/changeset/34910
>
> Log:
> only guard terminal output.
>
> Modified:
>lyx-devel/trunk/src/support/Systemcall.cpp
>lyx-de
On Fri, Jul 16, 2010 at 09:12:04AM +0200, Abdelrazak Younes wrote:
> On 07/16/2010 07:55 AM, kuem...@lyx.org wrote:
> >Author: kuemmel
> >Date: Fri Jul 16 07:55:31 2010
> >New Revision: 34910
> >URL: http://www.lyx.org/trac/changeset/34910
> >
> >Log:
> >only guard terminal output.
>
> >Modified:
On 07/16/2010 07:55 AM, kuem...@lyx.org wrote:
Author: kuemmel
Date: Fri Jul 16 07:55:31 2010
New Revision: 34910
URL: http://www.lyx.org/trac/changeset/34910
Log:
only guard terminal output.
Modified: lyx-devel/trunk/src/support/SystemcallPrivate.h
===
27 matches
Mail list logo
