Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Peter Kümmel
Andre Poenitz wrote: > On Wed, Feb 03, 2010 at 06:27:06PM +0100, Peter Kümmel wrote: >> Peter Kümmel wrote: >>> Peter Kümmel wrote: Originally it was the Model-View-Controller pattern, so isn't a controller the perfect candidate for the central dispatcher? >>> Wouldn't it be best to

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Andre Poenitz
On Wed, Feb 03, 2010 at 12:40:04PM +0100, Peter Kümmel wrote: > I would also introduce shared libraries which help to avoild > circular dependencies between the libraries, especially when building > Dlls on Windows, but maybe there is also a GCC flag to forbid such > dependencies . Linking with --

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Andre Poenitz
On Wed, Feb 03, 2010 at 06:27:06PM +0100, Peter Kümmel wrote: > Peter Kümmel wrote: > > Peter Kümmel wrote: > >> Originally it was the Model-View-Controller pattern, so isn't a > >> controller the perfect candidate for the central dispatcher? > >> > > > > Wouldn't it be best to completely unlink t

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Peter Kümmel
Peter Kümmel wrote: > Peter Kümmel wrote: >> Originally it was the Model-View-Controller pattern, so isn't a >> controller the perfect candidate for the central dispatcher? >> > > Wouldn't it be best to completely unlink the model and view like in > attached image, found as figue 4-6 in > http://d

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Peter Kümmel
Abdelrazak Younes wrote: > On 02/03/2010 12:17 PM, Peter Kümmel wrote: >> Peter Kümmel wrote: >> >>> Originally it was the Model-View-Controller pattern, so isn't a >>> controller the perfect candidate for the central dispatcher? >>> >>> > > If we proceed as I suggested then that would b

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > If we proceed as I suggested then that would be the result indeed: > > model: everything in src/, src/inset/ and src/math/ > > view: all the different dialogs, including GuiView > > controller: GuiApp mainly, but also GuiView::dispatch(), as well > Dialog, GuiDialog and

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: >> Note that, with my latest changes, LyXFunc only has two member variables >> left (those for saving cursor x/y). I would propose to move these >> variables into Cursor (savedX, savedY). Would somebody object to that? >> > > Not from me. But I think there is already

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Abdelrazak Younes
On 02/03/2010 11:50 AM, Jean-Marc Lasgouttes wrote: Abdelrazak Younes writes: As far as dispatch is concerned, my goal was to make GuiApp::dispatch() the first entry in the dispatch machinery instead of LyXFunc::dispatch() which should basically disappear... At the end, all the virtual inte

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Abdelrazak Younes
On 02/03/2010 12:17 PM, Peter Kümmel wrote: Peter Kümmel wrote: Originally it was the Model-View-Controller pattern, so isn't a controller the perfect candidate for the central dispatcher? If we proceed as I suggested then that would be the result indeed: model: everything in src/,

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Peter Kümmel
Peter Kümmel wrote: > > Originally it was the Model-View-Controller pattern, so isn't a > controller the perfect candidate for the central dispatcher? > Wouldn't it be best to completely unlink the model and view like in attached image, found as figue 4-6 in http://developer.apple.com/mac/librar

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: > Abdelrazak Younes writes: >> As far as dispatch is concerned, my goal was to make >> GuiApp::dispatch() the first entry in the dispatch machinery instead >> of LyXFunc::dispatch() which should basically disappear... At the end, >> all the virtual interface in "src/fro

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > As far as dispatch is concerned, my goal was to make > GuiApp::dispatch() the first entry in the dispatch machinery instead > of LyXFunc::dispatch() which should basically disappear... At the end, > all the virtual interface in "src/frontend/" should disappear too. I c

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-03 Thread Abdelrazak Younes
On 02/02/2010 07:57 PM, Peter Kümmel wrote: Andre Poenitz wrote: On Tue, Feb 02, 2010 at 02:53:58PM +0100, Peter Kümmel wrote: Am Sonntag, den 31.01.2010, 14:29 +0100 schrieb Andre Poenitz: How do we proceed now ? I think it's time to use signal/slots, this time

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-02 Thread Peter Kümmel
Andre Poenitz wrote: > On Tue, Feb 02, 2010 at 02:53:58PM +0100, Peter Kümmel wrote: >> Am Sonntag, den 31.01.2010, 14:29 +0100 schrieb Andre Poenitz: How do we proceed now ? >>> I think it's time to use signal/slots, this time in the right direction. >>> The buffer emits a message, possibly w

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-02 Thread Andre Poenitz
On Tue, Feb 02, 2010 at 02:53:58PM +0100, Peter Kümmel wrote: > Am Sonntag, den 31.01.2010, 14:29 +0100 schrieb Andre Poenitz: > > > How do we proceed now ? > > > > I think it's time to use signal/slots, this time in the right direction. > > The buffer emits a message, possibly with an indication

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-02-02 Thread Peter Kümmel
Am Sonntag, den 31.01.2010, 14:29 +0100 schrieb Andre Poenitz: > > How do we proceed now ? > > I think it's time to use signal/slots, this time in the right direction. > The buffer emits a message, possibly with an indication that it is > temporarily and the view (or the server...) connects to it.

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-31 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Pavel Sanda schreef: >> Andre Poenitz wrote: >> >>> I think it's time to use signal/slots, this time in the right direction. >>> The buffer emits a message, possibly with an indication that it is >>> temporarily and the view (or the server...) connects to it. >>>

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-31 Thread Andre Poenitz
On Sun, Jan 31, 2010 at 02:40:56PM +0100, Pavel Sanda wrote: > Andre Poenitz wrote: > > I think it's time to use signal/slots, this time in the right direction. > > The buffer emits a message, possibly with an indication that it is > > temporarily and the view (or the server...) connects to it. >

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-31 Thread Vincent van Ravesteijn
Pavel Sanda schreef: Andre Poenitz wrote: I think it's time to use signal/slots, this time in the right direction. The buffer emits a message, possibly with an indication that it is temporarily and the view (or the server...) connects to it. hmm, its very hard to debug things in signal

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-31 Thread Pavel Sanda
Andre Poenitz wrote: > I think it's time to use signal/slots, this time in the right direction. > The buffer emits a message, possibly with an indication that it is > temporarily and the view (or the server...) connects to it. hmm, its very hard to debug things in signal slot machinery. pavel

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-31 Thread Andre Poenitz
On Sat, Jan 30, 2010 at 06:22:28PM +0100, Vincent van Ravesteijn wrote: > >> Author: lasgouttes >> Date: Fri Jan 29 11:42:39 2010 >> New Revision: 33258 >> URL: http://www.lyx.org/trac/changeset/33258 >> >> Log: >> add a dispatchresult parameter to lyxview::dispatch >> > > > How do we proceed no

Re: r33258 - in lyx-devel/trunk/src: . frontends frontends/qt4

2010-01-30 Thread Vincent van Ravesteijn
Author: lasgouttes Date: Fri Jan 29 11:42:39 2010 New Revision: 33258 URL: http://www.lyx.org/trac/changeset/33258 Log: add a dispatchresult parameter to lyxview::dispatch How do we proceed now ? As an example, FUN_FILE_INSERT calls: GuiView::insertLyXFile, which emits the messages