Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-24 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: * Close All / Close View Close all should close all visible workareas and the buffers that were hidden in this view. Again, I wouldn't close buffers in another view. There is no such thing as "buffers that were hidden in this view". Yes, that

RE: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-24 Thread Vincent van Ravesteijn - TNW
>> * Close >> >> When you close a buffer in one view, it's everything but >> expected thatthis buffer gets closed in the other view >> too. I know this is 'consistent', but I'd rather stop >> doing that. > > I disagree but I guess this is just a terminology problem. > We should rename that to

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-24 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: but its maybe true that some people would like see 'hide all' in menu... No, I was thinking about "Close All" == "Close All Buffers in this View" if we call it 'close all in window', then it would ok with me. (hide all would be consi

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Pavel Sanda
Vincent van Ravesteijn - TNW wrote: > IMHO: I don't want to be consistent anymore, because I feel that the > current situation is very misleading and unintuitive. > > * Close Tab Group > > This should maybe be Close Split View, and it shouldn't hide the > documents which were in the tabgroup, bec

RE: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Vincent van Ravesteijn - TNW
>> >> >but its maybe true that some people would like >> see 'hide all' in menu... >> >> No, I was thinking about "Close All" == "Close All Buffers in this View" > >if we call it 'close all in window', then it would ok with me. >(hide all would be consistent though, but i have no hard opinion.)

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Pavel Sanda
Vincent van Ravesteijn - TNW wrote: > > >but its maybe true that some people would like see 'hide all' in > menu... > > No, I was thinking about "Close All" == "Close All Buffers in this View" if we call it 'close all in window', then it would ok with me. (hide all would be consistent though, bu

RE: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Vincent van Ravesteijn - TNW
> pavel I mean, Vincent

RE: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Vincent van Ravesteijn - TNW
>but its maybe true that some people would like see 'hide all' in menu... No, I was thinking about "Close All" == "Close All Buffers in this View" pavel

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Pavel Sanda
Vincent van Ravesteijn - TNW wrote: > > >> So, when we close a view, we shouldn't release all buffers, but when > >> we choose File->Close All, then we should ? > > > >close even hidden ones imho > > So, if I choose File->Close All in one view, it'll close all > workareas/buffers in all views.

RE: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-19 Thread Vincent van Ravesteijn - TNW
>> So, when we close a view, we shouldn't release all buffers, but when >> we choose File->Close All, then we should ? > >close even hidden ones imho So, if I choose File->Close All in one view, it'll close all workareas/buffers in all views. That's not as expected I guess, or is it ? >pavel

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread rgheck
On 08/18/2009 04:36 PM, Vincent van Ravesteijn wrote: Vincent van Ravesteijn schreef: I'm a little unclear on how separate views are supposed to work. So, maybe a silly question, but: When we call this, do we really want to close ALL open buffers? Can there be more than one GuiView at a ti

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread rgheck
On 08/18/2009 04:33 PM, Vincent van Ravesteijn wrote: Thanks for checking. Never a problem. rh

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Now, I think about it. It was Pavel who thought it was strange that the > hidden buffers were still loaded, while he was talking about multiple > views. iirc this was about master/child relation and not multiple view. > So, when we close a view, we shouldn't rele

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread Vincent van Ravesteijn
Vincent van Ravesteijn schreef: I'm a little unclear on how separate views are supposed to work. So, maybe a silly question, but: When we call this, do we really want to close ALL open buffers? Can there be more than one GuiView at a time? You see the worry. Ah yes, you're right... I'm bei

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread Vincent van Ravesteijn
I'm a little unclear on how separate views are supposed to work. So, maybe a silly question, but: When we call this, do we really want to close ALL open buffers? Can there be more than one GuiView at a time? You see the worry. Ah yes, you're right... I'm being too enthusiastic. + +bool G

Re: r31125 - lyx-devel/trunk/src/frontends/qt4

2009-08-18 Thread rgheck
On 08/18/2009 04:12 PM, v...@lyx.org wrote: Author: vfr Date: Tue Aug 18 22:12:34 2009 New Revision: 31125 URL: http://www.lyx.org/trac/changeset/31125 Log: Rename closeBufferAll to closeWorkAreaAll (because that's what we do). Add a new closeBufferAll function that closes all WorkArea's and th