Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread Jean-Marc Lasgouttes
Le 14 juil. 09 à 17:13, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: margin notes seem to be affected In what respect? button text is missing. just try to insert it. This is fixed now. JMarc

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >> margin notes seem to be affected > > In what respect? button text is missing. just try to insert it. pavel

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread Jean-Marc Lasgouttes
Le 14 juil. 09 à 15:46, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: This means that if you see strange bugs related to the painting or latex output of collapsable insets, it is my fault :) margin notes seem to be affected In what respect? JMarc

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > This means that if you see strange bugs related to the painting or latex > output of > collapsable insets, it is my fault :) margin notes seem to be affected pavel

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread rgheck
On 07/14/2009 06:11 AM, Jean-Marc Lasgouttes wrote: - virtual bool usePlainLayout() { return true; } - /// What this just unnecessary? I wonder why I put it there? You tell me. I removed it because you added in the same commit the const version /// virtual bool usePlainLayout() const { return

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-14 Thread Jean-Marc Lasgouttes
- virtual bool usePlainLayout() { return true; } - /// What this just unnecessary? I wonder why I put it there? You tell me. I removed it because you added in the same commit the const version /// virtual bool usePlainLayout() const { return true; } One is enough :

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-13 Thread rgheck
On 07/13/2009 11:47 AM, lasgout...@lyx.org wrote: Author: lasgouttes Date: Mon Jul 13 17:47:40 2009 New Revision: 30549 URL: http://www.lyx.org/trac/changeset/30549 Other changes: * remove non-const usePlainLayout methods Modified: lyx-devel/trunk/src/insets/InsetCollapsable.h

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-13 Thread rgheck
On 07/13/2009 12:05 PM, Jean-Marc Lasgouttes wrote: Le 13 juil. 09 à 17:47, lasgout...@lyx.org a écrit : The most important change in this changeset is that InsetCollapsable::getLayout is commented out, so that the documentclass is queried every time instead of using the layout_ cache. This i

RE: r30549 - lyx-devel/trunk/src/insets

2009-07-13 Thread Vincent van Ravesteijn - TNW
>My long-term goal is to remove from InsetCollapsable >everything which is not related to collapsability. I cannot agree more. Vincent

Re: r30549 - lyx-devel/trunk/src/insets

2009-07-13 Thread Jean-Marc Lasgouttes
Le 13 juil. 09 à 17:47, lasgout...@lyx.org a écrit : The most important change in this changeset is that InsetCollapsable::getLayout is commented out, so that the documentclass is queried every time instead of using the layout_ cache. For now I have kept the setLayout calls, but they are in