Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Pavel Sanda
Abdelrazak Younes wrote: > Maybe the difference is that this is a local variable to the if condition. i understood the purpose of this warning as a safety measure for '=' instead of '==', which is not the case of var. definition in the place of condition. > Still I think your warning is bogus. W

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: Hum, I don't understand why you see this warning only here. This type of assignment is used many times elsewhere in the source code... where? you...@younes:~/devel/lyx/trunk/src$ grep -r 'if (Buffer' * frontends/qt4/GuiApplication.cpp:

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Pavel Sanda
Abdelrazak Younes wrote: > Hum, I don't understand why you see this warning only here. This type of > assignment is used many times elsewhere in the source code... where? pavel

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Abdelrazak Younes
Pavel Sanda wrote: Pavel Sanda wrote: Abdelrazak Younes wrote: And I reverted your revert ;-) The problem was that the member variable 'd' was shadowed. hehehe, even after your fix i see: GuiView.cpp:394: warning: suggest parentheses around assignment used as truth value so wh

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Pavel Sanda
Pavel Sanda wrote: > Abdelrazak Younes wrote: > > And I reverted your revert ;-) > > The problem was that the member variable 'd' was shadowed. hehehe, even after your fix i see: GuiView.cpp:394: warning: suggest parentheses around assignment used as truth value so while you are right about the s

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-23 Thread Pavel Sanda
Abdelrazak Younes wrote: > And I reverted your revert ;-) > The problem was that the member variable 'd' was shadowed. ahh, i completely missed the semicolon... ;) pavel

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-22 Thread Abdelrazak Younes
On 22/06/2009 23:01, Pavel Sanda wrote: you...@lyx.org wrote: Author: younes Date: Mon Jun 22 22:16:08 2009 New Revision: 30225 URL: http://www.lyx.org/trac/changeset/30225 Log: Bug fix? Modified: lyx-devel/trunk/src/frontends/qt4/GuiView.cpp Modified: lyx-devel/trunk/src/frontends/qt

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-22 Thread Abdelrazak Younes
On 22/06/2009 23:01, Pavel Sanda wrote: you...@lyx.org wrote: Author: younes Date: Mon Jun 22 22:16:08 2009 New Revision: 30225 URL: http://www.lyx.org/trac/changeset/30225 Log: Bug fix? Modified: lyx-devel/trunk/src/frontends/qt4/GuiView.cpp Modified: lyx-devel/trunk/src/frontends/qt

Re: r30225 - lyx-devel/trunk/src/frontends/qt4

2009-06-22 Thread Pavel Sanda
you...@lyx.org wrote: > Author: younes > Date: Mon Jun 22 22:16:08 2009 > New Revision: 30225 > URL: http://www.lyx.org/trac/changeset/30225 > > Log: > Bug fix? > > Modified: >lyx-devel/trunk/src/frontends/qt4/GuiView.cpp > > Modified: lyx-devel/trunk/src/frontends/qt4/GuiView.cpp >