Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-23 Thread Andre Poenitz
On Sat, May 23, 2009 at 12:51:05PM +0200, Pavel Sanda wrote: > Jürgen Spitzmüller wrote: > > Look at GuiDocument.h, for instance. > > > > The on_* slots are not our own, we have to follow the Qt convention > > here. And change_adaptor() is an exception (that probably would need > > to be changed).

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-23 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Look at GuiDocument.h, for instance. > > The on_* slots are not our own, we have to follow the Qt convention here. And > change_adaptor() is an exception (that probably would need to be changed). ok i changed other slots around. Andre please check with your syntax sha

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-23 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > private Q_SLOTS: > void change_adaptor(); > > void change_group(int); > void change_bb(); > void on_newGroupPB_clicked(); > void on_bro

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-23 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > Aren't we into camelBumpStyle() for member functions? > > > > this function is slot > > We also use CamelCase for (our own) slots. hm private Q_SLOTS: void change_adaptor();

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-22 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > Aren't we into camelBumpStyle() for member functions? > > this function is slot We also use CamelCase for (our own) slots. Jürgen

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-22 Thread Pavel Sanda
Andre Poenitz wrote: > > - void GuiGraphics::change_group(int /* index */) > > +void GuiGraphics::change_group(int /* index */) > > { > > QString const new_group = groupCO->itemData( > > groupCO->currentIndex()).toString(); > > Aren't we into camelBumpStyle() for member functi

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-22 Thread Jürgen Spitzmüller
Andre Poenitz wrote: > Aren't we into camelBumpStyle() for member functions? Yes. I think so. I didn't check for that. Jürgen

Re: r29778 - lyx-devel/trunk/src/frontends/qt4

2009-05-22 Thread Andre Poenitz
On Fri, May 22, 2009 at 06:00:48PM +0200, sp...@lyx.org wrote: > Author: spitz > Date: Fri May 22 18:00:29 2009 > New Revision: 29778 > URL: http://www.lyx.org/trac/changeset/29778 > > Log: > whitespace. > > Modified: >lyx-devel/trunk/src/frontends/qt4/GuiGraphics.cpp > > Modified: lyx-devel