Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: As I said this is an implementation detail that pollutes the clipboard virtual interface (clipboard.h). If you don't like "mutable", move that code to a private implementation in GuiClipboard.cpp its not that i dont like, i'm just curious :

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Pavel Sanda
Abdelrazak Younes wrote: > As I said this is an implementation detail that pollutes the clipboard > virtual interface (clipboard.h). If you don't like "mutable", move that > code to a private implementation in GuiClipboard.cpp its not that i dont like, i'm just curious :) pavel

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Pavel Sanda wrote: Abdelrazak Younes wrote: Please leave this const and make schedule_check_ mutable. can you explain why (sincere question)? Because, by definition, checking for emptyness is not something that should change the contents of a class. The scheduled ch

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: Please leave this const and make schedule_check_ mutable. can you explain why (sincere question)? Because, by definition, checking for emptyness is not something that should change the contents of a class. The scheduled checki

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Pavel Sanda
Abdelrazak Younes wrote: >>> Please leave this const and make schedule_check_ mutable. >>> >> >> can you explain why (sincere question)? >> > > Because, by definition, checking for emptyness is not something that should > change the contents of a class. The scheduled checking is an imple

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: Author: sanda Date: Tue Jul 29 03:51:20 2008 New Revision: 25950 +++ lyx-devel/trunk/src/frontends/Selection.h Tue Jul 29 03:51:20 2008 - virtual bool empty() const = 0; + virtual bool empty() =

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-29 Thread Pavel Sanda
Abdelrazak Younes wrote: > [EMAIL PROTECTED] wrote: >> Author: sanda >> Date: Tue Jul 29 03:51:20 2008 >> New Revision: 25950 > >> +++ lyx-devel/trunk/src/frontends/Selection.h Tue Jul 29 03:51:20 2008 >> -virtual bool empty() const = 0; >> +virtual bool empty() = 0; > > Please leave this c

Re: r25950 - in /lyx-devel/trunk/src/frontends: Selection.h q...

2008-07-28 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: sanda Date: Tue Jul 29 03:51:20 2008 New Revision: 25950 +++ lyx-devel/trunk/src/frontends/Selection.h Tue Jul 29 03:51:20 2008 - virtual bool empty() const = 0; + virtual bool empty() = 0; Please leave this const and make schedule_check_ mutable.