Re: r21048 - in /lyx-devel/trunk/src: BufferView.cpp Converte...

2007-10-19 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Oct 18, 2007 at 02:07:49PM -0700, Angus Leeming wrote: This makes the source much more readable; obviously the right thing to do. However, I think it also makes sense to make that QFileInfo a member variable of FileName, no? I think it is not considered politically

Re: r21048 - in /lyx-devel/trunk/src: BufferView.cpp Converte...

2007-10-19 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 02:07:49PM -0700, Angus Leeming wrote: > This makes the source much more readable; obviously the right thing to do. > However, I think it also makes sense to make that QFileInfo a member > variable of FileName, no? I think it is not considered politically correct to use Q*

Re: r21048 - in /lyx-devel/trunk/src: BufferView.cpp Converte...

2007-10-18 Thread Abdelrazak Younes
Angus Leeming wrote: This makes the source much more readable; obviously the right thing to do. However, I think it also makes sense to make that QFileInfo a member variable of FileName, no? You seem to be creating an awful lot of temporary objects for no real reason. Agreed. And I think that'

Re: r21048 - in /lyx-devel/trunk/src: BufferView.cpp Converte...

2007-10-18 Thread Angus Leeming
[EMAIL PROTECTED] wrote: > Author: poenitz > Date: Fri Oct 19 01:03:51 2007 > New Revision: 21048 > > URL: http://www.lyx.org/trac/changeset/21048 > Log: > isome more FileName shuffling http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.cpp?rev=21048 > =