Re: r21033 - in /lyx-devel/trunk/src: Buffer.cpp CutAndPaste....

2007-10-19 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes wrote: Well it was just modeled after Inset::clone but you're right, it's strange. Maybe I should just rename it to cloneInset() instead or implement a copy ctor... The copy constructor sounds sane. This thing isn't polymorphic at all. Yes, I am in the

Re: r21033 - in /lyx-devel/trunk/src: Buffer.cpp CutAndPaste....

2007-10-19 Thread Angus Leeming
Abdelrazak Younes wrote: Well it was just modeled after Inset::clone but you're right, it's > strange. Maybe I should just rename it to cloneInset() instead or > implement a copy ctor... The copy constructor sounds sane. This thing isn't polymorphic at all. -- Angus

Re: r21033 - in /lyx-devel/trunk/src: Buffer.cpp CutAndPaste....

2007-10-18 Thread Abdelrazak Younes
Angus Leeming wrote: [EMAIL PROTECTED] wrote: Author: younes Date: Thu Oct 18 17:29:51 2007 New Revision: 21033 URL: http://www.lyx.org/trac/changeset/21033 Log: Reduce header dependencies in Paragraph.h - Move Changes.h out of Paragraph.h - pimpl the inset list.

Re: r21033 - in /lyx-devel/trunk/src: Buffer.cpp CutAndPaste....

2007-10-18 Thread Angus Leeming
[EMAIL PROTECTED] wrote: > Author: younes > Date: Thu Oct 18 17:29:51 2007 > New Revision: 21033 > > URL: http://www.lyx.org/trac/changeset/21033 > Log: > Reduce header dependencies in Paragraph.h > - Move Changes.h out of Paragraph.h > - pimpl the inset list. ===