Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-23 Thread Andre Poenitz
On Thu, Feb 22, 2007 at 10:35:07PM +0100, Lars Gullik Bjønnes wrote: > Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: > > | > | > | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing > so > | > | > | by Asger). > | > | We profiled stuff and found that in some critical inner loo

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Asger Ottar Alstrup
Lars Gullik Bjønnes wrote: Then you are saying that __func__ is hurting a lot... and that is resolved at compile time, so I just do not belive you. This depends on the compiler. What costs is writing to lyxerr in the first place, not BOOST_CURRENT_FUNCTION. A lyxerr null-wirte is not free. (f

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Lars Gullik Bjønnes
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: | > | > | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing so | > | > | by Asger). | | We profiled stuff and found that in some critical inner loops, the use | of BOOST_CURRENT_FUNCTION hurt performance a lot. If you want to use |

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Asger Ottar Alstrup
| > | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing so | > | by Asger). We profiled stuff and found that in some critical inner loops, the use of BOOST_CURRENT_FUNCTION hurt performance a lot. If you want to use such stuff, please make sure it is guarded correctly to not

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > Georg Baum <[EMAIL PROTECTED]> | > writes: | > | > | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing so | > | by Asger). | > | > Hmm. Why was that? | | I believe he thought that BOOST_CURRENT_FUNCTIO

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > > | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing so > | by Asger). > > Hmm. Why was that? I believe he thought that BOOST_CURRENT_FUNCTION would pull in too much other stuff and is too expensive, but

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | this I do use BOOST_CURRENT_FUNCTION (and even got flamed for doing so by | Asger). Hmm. Why was that? -- Lgb

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Georg Baum
Lars Gullik Bjønnes wrote: > It is not really about making me happy you know... Yes I know. I should have added a smiley:-) I know why BOOST_CURRENT_FUNCTION is better. I did just not think about it yesterday, since this was only moving code around. When I add new debug messages like this I do us

Re: r17298 - /lyx-devel/trunk/src/CutAndPaste.C

2007-02-22 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] writes: | Author: baum | Date: Thu Feb 22 09:18:59 2007 | New Revision: 17298 | | URL: http://www.lyx.org/trac/changeset/17298 | Log: | make Lars happy It is not really about making me happy you know... -- Lgb