Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-11-11 Thread Georg Baum
Am Mittwoch, 8. November 2006 19:18 schrieb Andre Poenitz: > On Mon, Oct 30, 2006 at 02:41:15PM +0100, Georg Baum wrote: > > Yes, that was the reason for similar problems in the past, but I could not > > find any undefined virtual method. Are we all blind? BTW Abdel your latest > > patch does not

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-11-11 Thread Andre Poenitz
On Mon, Oct 30, 2006 at 02:41:15PM +0100, Georg Baum wrote: > Yes, that was the reason for similar problems in the past, but I could not > find any undefined virtual method. Are we all blind? BTW Abdel your latest > patch does not help either (although callinf the Painter() constructor is a > good

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-11-08 Thread Andre Poenitz
On Mon, Oct 30, 2006 at 02:19:02PM +0100, Abdelrazak Younes wrote: > - : qwa_(qwa) > -{ > - //lyxerr << "QLPainter::start()" << endl; > - QPainter::begin(qwa_); > +QLPainter::QLPainter(QPaintDevice * device) > + : QPainter(device), Painter() > +{ The empty Painter() contructor woul

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-11-02 Thread Andre Poenitz
On Mon, Oct 30, 2006 at 12:49:54PM +0100, Jean-Marc Lasgouttes wrote: > Abdelrazak> POD? > > Plain old data (bool, int, double... as opposed to structs and classes). also structs that are valid 'plain C structs'. Andre'

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: If changing the inheritance order then I prefer this last solution. That does not help (and if it did it would be vodoo to me), but I found the problem: You have to reimplement _all_ virtual methods in the derived class, not just the undefined ones.

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Abdelrazak Younes wrote: >> If changing the inheritance order then I prefer this last solution. Georg> That does not help (and if it did it would be vodoo to me), but Georg> I found the problem: You have to reimplement _all_ virtual G

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Georg Baum
Abdelrazak Younes wrote: > If changing the inheritance order then I prefer this last solution. That does not help (and if it did it would be vodoo to me), but I found the problem: You have to reimplement _all_ virtual methods in the derived class, not just the undefined ones. I am not sure whethe

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Peter Kümmel wrote: Georg Baum wrote: Peter Kümmel wrote: "I don't know if this will help you, but I got this one time when I declared a virtual member but failed to define it." Yes, that was the reason for similar problems in the past, but I could not find any undefined virtual method. Are w

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Georg Baum wrote: > Peter Kümmel wrote: > >> "I don't know if this will help you, but I got this one time when I >> declared a virtual member but failed to define it." > > Yes, that was the reason for similar problems in the past, but I could not > find any undefined virtual method. Are we all bl

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Georg Baum wrote: > Peter Kümmel wrote: > >> "I don't know if this will help you, but I got this one time when I >> declared a virtual member but failed to define it." > > Yes, that was the reason for similar problems in the past, but I could not > find any undefined virtual method. Are we all bl

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Abdelrazak Younes wrote: > Not in this case. I tried to instantiate a QLPainter with new and it > works fine. I am 100% sure that MSVC does not compile with incomplete > virtual interface. You could not instantiate a class with a missing virtual implementation, I've tested it. Peter

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Georg Baum wrote: Peter Kümmel wrote: "I don't know if this will help you, but I got this one time when I declared a virtual member but failed to define it." Yes, that was the reason for similar problems in the past, but I could not find any undefined virtual method. Are we all blind? I am

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Georg Baum
Peter Kümmel wrote: > "I don't know if this will help you, but I got this one time when I > declared a virtual member but failed to define it." Yes, that was the reason for similar problems in the past, but I could not find any undefined virtual method. Are we all blind? BTW Abdel your latest pat

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Peter Kümmel wrote: Jean-Marc Lasgouttes wrote: "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Yes this would be strange. Peter> Here the next idea: No luck either... Would have bee strange too :) JMarc Gogling gives mw this: "I don't know if this will help you, but I got th

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> Yes this would be strange. > > Peter> Here the next idea: > > No luck either... Would have bee strange too :) > > JMarc > > Gogling gives mw this: "I don't know if this will help you, but I got

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Peter Kümmel wrote: Georg Baum wrote: I don't use pch here (gcc too old), but it does not work. I just tried Peter's fix, and it did not help either (as expected, if gcc had a problem with inlined virtual destructors many people would have seen it). Yes this would be strange. Here the next i

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Yes this would be strange. Peter> Here the next idea: No luck either... Would have bee strange too :) JMarc

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Georg Baum wrote: Jean-Marc Lasgouttes wrote: Abdelrazak> Really? hum, do you use precompiled header? Yes. I'll try to remove them and recompile. I don't use pch here (gcc too old), but it does not work. I just tried Peter's fix, and it did not help either (as expected, if gcc had a problem

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Georg Baum wrote: > I don't use pch here (gcc too old), but it does not work. I just tried > Peter's fix, and it did not help either (as expected, if gcc had a problem > with inlined virtual destructors many people would have seen it). Yes this would be strange. Here the next idea: Index: QLPai

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Abdelrazak> Really? hum, do you use precompiled header? > > Yes. I'll try to remove them and recompile. I don't use pch here (gcc too old), but it does not work. I just tried Peter's fix, and it did not help either (as expected, if gcc had a problem with inlined vir

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Maybe this helps. If it solves the problem and I fear it will, it is a gcc bug. Abdel.

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> BTW, I still cannot link after your latest commit. Same errors as >> Georg. Abdelrazak> Does this patch helps? No :( JMarc

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Peter Kümmel
Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> >> Abdelrazak> Jean-Marc Lasgouttes wrote: > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> Yes, the destructor was not virtual. This

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Also, the 'const' of isDrawing Enabled seems badly placed. Returning a 'bool const' is weird, Abdelrazak> I thought this was defined in LyX code style as a hint to Abdelrazak> say "This returned value is n

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Yes, the destructor was not virtual. This should be fixed Abdelrazak> now. Also, the 'c

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> Jean-Marc Lasgouttes wrote: > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdel

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Yes, the destructor was not virtual. This should be fixed Abdelrazak> now. Also, the 'c

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> Yes, the destructor was not virtual. This should be fixed Abdelrazak> now. >> Also, the 'const' of isDra

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Yes, the destructor was not virtual. This should be fixed Abdelrazak> now. Also, the 'const' of isDrawing Enabled seems badly placed. Returning a 'bool const' is weird, I thought this was de

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Yes, the destructor was not virtual. This should be fixed Abdelrazak> now. Also, the 'const' of isDrawing Enabled seems badly placed. Returning a 'bool const' is weird, but OTOH the method could be const. JMarc

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Abdelrazak Younes
Georg Baum wrote: [EMAIL PROTECTED] wrote: Author: younes Date: Mon Oct 30 11:47:59 2006 New Revision: 15615 URL: http://www.lyx.org/trac/changeset/15615 Log: Forgot that! That was not enough. It does not link: frontends/qt4/.libs/libqt4.a(QLPainter.o (.gnu.linkonce.t._ZN3lyx8frontend7Pain

Re: r15615 - in /lyx-devel/trunk/src: insets/insettabular.C m...

2006-10-30 Thread Georg Baum
[EMAIL PROTECTED] wrote: > Author: younes > Date: Mon Oct 30 11:47:59 2006 > New Revision: 15615 > > URL: http://www.lyx.org/trac/changeset/15615 > Log: > Forgot that! That was not enough. It does not link: frontends/qt4/.libs/libqt4.a(QLPainter.o (.gnu.linkonce.t._ZN3lyx8frontend7PainterC2Ev+