Andre Poenitz wrote:
On Fri, Aug 25, 2006 at 02:37:58PM +0200, Abdelrazak Younes wrote:
I don't know why there is this line in the UI file but I know for sure
that Ui classes are _not_ QWidget; there are not even QObject. So this
QWidget inheritance is the right thing to do:
class FloatPl
Andre Poenitz <[EMAIL PROTECTED]> writes:
| I personally use the
|
| class FloatPlacement : public QWidget
| {
| private:
| Ui::FloatPlacementUi * ui_;
| }
|
| approach as this effectively pimpls away everything pulled in by the
| ui_*.h files, but it requires an explict constructor.
|
On Fri, Aug 25, 2006 at 02:37:58PM +0200, Abdelrazak Younes wrote:
> I don't know why there is this line in the UI file but I know for sure
> that Ui classes are _not_ QWidget; there are not even QObject. So this
> QWidget inheritance is the right thing to do:
>
> class FloatPlacement : public
On Fri, Aug 25, 2006 at 01:23:16PM +0100, Angus Leeming wrote:
> Edwin Leuven wrote:
> >the attached patch fp.diff
> >
> >* implements the float widget as a .ui file
> >* renames from floatplacement.[Ch] -> FloatPlacement.[Ch]
> >
> >
> >compare.diff shows the differences between the two files
> >
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Otherwise looks good except that you took the path of minimal effort
;-) No automatic slots, etc...
added some autoslots, other suggestions?
so many things to do, yet so little time
No problem I was just teasing you. You got me used to redesign
Abdelrazak Younes wrote:
Otherwise looks good except that you took the path of minimal effort ;-)
No automatic slots, etc...
added some autoslots, other suggestions?
so many things to do, yet so little time
will commit the attached...
Index: src/frontends/qt4/QFloatDialog.C
==
Edwin Leuven wrote:
Angus Leeming wrote:
Given that FloatPlacementUi derives from QWidget:
+ FloatPlacementUi
+
I don't think FloatPlacement needs to derive directly from QWidget:
-class FloatPlacement : public QWidget {
+class FloatPlacement : public QWidget, public Ui::FloatPlacementUi {
Angus Leeming wrote:
Edwin Leuven wrote:
the attached patch fp.diff
* implements the float widget as a .ui file
* renames from floatplacement.[Ch] -> FloatPlacement.[Ch]
compare.diff shows the differences between the two files
If you'd used svn rename I think this diff would have come for f
Angus Leeming wrote:
Given that FloatPlacementUi derives from QWidget:
+ FloatPlacementUi
+
I don't think FloatPlacement needs to derive directly from QWidget:
-class FloatPlacement : public QWidget {
+class FloatPlacement : public QWidget, public Ui::FloatPlacementUi {
that's what i thought
Edwin Leuven wrote:
the attached patch fp.diff
* implements the float widget as a .ui file
* renames from floatplacement.[Ch] -> FloatPlacement.[Ch]
compare.diff shows the differences between the two files
comments welcome
Given that FloatPlacementUi derives from QWidget:
+ FloatPlacementUi
10 matches
Mail list logo
