Re: msvc chmod.

2006-11-19 Thread Enrico Forestieri
On Sun, Nov 19, 2006 at 03:36:08PM +0100, Georg Baum wrote: > Am Sonntag, 19. November 2006 14:56 schrieb Bo Peng: > > > > mode_t is only used when HAVE_CHMOD is enabled > > > > so why do you need a HAVE_MODE_T? > > > > Because msvc has chmod, but not mode_t; and I am reluctant to use > > compile

Re: msvc chmod.

2006-11-19 Thread Peter Kümmel
Georg Baum wrote: > Am Sonntag, 19. November 2006 14:56 schrieb Bo Peng: mode_t is only used when HAVE_CHMOD is enabled so why do you need a HAVE_MODE_T? >> Because msvc has chmod, but not mode_t; and I am reluctant to use >> compiler/os specific flags. >> >>> And mingw has a mode_t. >> m

Re: msvc chmod.

2006-11-19 Thread Georg Baum
Am Sonntag, 19. November 2006 14:56 schrieb Bo Peng: > > > mode_t is only used when HAVE_CHMOD is enabled > > > so why do you need a HAVE_MODE_T? > > Because msvc has chmod, but not mode_t; and I am reluctant to use > compiler/os specific flags. > > > And mingw has a mode_t. > > msvc is only *on

Re: msvc chmod.

2006-11-19 Thread Peter Kümmel
Bo Peng wrote: >> > mode_t is only used when HAVE_CHMOD is enabled >> > so why do you need a HAVE_MODE_T? > > Because msvc has chmod, but not mode_t; and I am reluctant to use > compiler/os specific flags. But chmod should be disabled for msvc. > >> And mingw has a mode_t. > > msvc is only *on

Re: msvc chmod.

2006-11-19 Thread Bo Peng
> mode_t is only used when HAVE_CHMOD is enabled > so why do you need a HAVE_MODE_T? Because msvc has chmod, but not mode_t; and I am reluctant to use compiler/os specific flags. And mingw has a mode_t. msvc is only *one* compiler under windows. mingw happens to have mode_t, but what about c

Re: msvc chmod.

2006-11-19 Thread Peter Kümmel
Peter Kümmel wrote: > Bo Peng wrote: Does cmake define HAVE_CHMOD? >>> No, after discussing it with Georg I've disabled chmod on Windows, >>> config.h.cmake: >>> >>> #ifdef _MSC_VER >> I see. I am uncomfortable with #_MSC_VER since this assumes msvc >> compiler so this may fail under mingw. >>

Re: msvc chmod.

2006-11-19 Thread Peter Kümmel
Bo Peng wrote: >> > Does cmake define HAVE_CHMOD? >> >> No, after discussing it with Georg I've disabled chmod on Windows, >> config.h.cmake: >> >> #ifdef _MSC_VER > > I see. I am uncomfortable with #_MSC_VER since this assumes msvc > compiler so this may fail under mingw. > > I am adding HAVE_MO

Re: msvc chmod.

2006-11-19 Thread Bo Peng
> Does cmake define HAVE_CHMOD? No, after discussing it with Georg I've disabled chmod on Windows, config.h.cmake: #ifdef _MSC_VER I see. I am uncomfortable with #_MSC_VER since this assumes msvc compiler so this may fail under mingw. I am adding HAVE_MODE_T. Please, Georg and Peter, adjust a

Re: msvc chmod.

2006-11-19 Thread Peter Kümmel
Bo Peng wrote: > Hi, Peter, > > Does cmake define HAVE_CHMOD? Scons detects chmod under msvc and > defines HAVE_CHMOD. However, in src/support/copy.C, chmod is used with > mode_t which does not exist under windows. > > HAVE_MODE_T may be needed. > > Bo > No, after discussing it with Georg I've

Re: msvc chmod.

2006-11-19 Thread Georg Baum
Am Sonntag, 19. November 2006 07:13 schrieb Bo Peng: > Hi, Peter, > > Does cmake define HAVE_CHMOD? Scons detects chmod under msvc and > defines HAVE_CHMOD. However, in src/support/copy.C, chmod is used with > mode_t which does not exist under windows. > > HAVE_MODE_T may be needed. Yes. The win

Re: msvc chmod.

2006-11-18 Thread Angus Leeming
Bo Peng <[EMAIL PROTECTED]> writes: > Does cmake define HAVE_CHMOD? Scons detects chmod under msvc and > defines HAVE_CHMOD. However, in src/support/copy.C, chmod is used with > mode_t which does not exist under windows. > > HAVE_MODE_T may be needed. Or (#define mode_t int) which I believe is wh