Re: [Patch] Re: math madness with double underlining

2005-03-24 Thread Martin Vermeer
On Wed, Mar 23, 2005 at 12:51:17PM +0200, Martin Vermeer wrote: > ... > > > > Unfortunately there is still "cases" which is handled separately: it > > > currently too allows vertical grid lines to be added, which LaTeX > > > doesn't display. Am I right in supposing that fixing this will require >

Re: [Patch] Re: math madness with double underlining

2005-03-23 Thread Martin Vermeer
... > > Unfortunately there is still "cases" which is handled separately: it > > currently too allows vertical grid lines to be added, which LaTeX > > doesn't display. Am I right in supposing that fixing this will require > > adding doDispatch and getStatus methods to MathCasesInset? > > I think

Re: [Patch] Re: math madness with double underlining

2005-03-23 Thread Georg Baum
Martin Vermeer wrote: > As I noticed, the situation with grid line lines in multi-line equations > is a little bit more complicated: in reality, *vertical* grid lines are > *never* displayed in these. > > Currently LyX accepts their addition and shows them on the screen, but > LaTeX doesn't show

[Patch] Re: [Patch] Re: math madness with double underlining

2005-03-23 Thread Martin Vermeer
As I noticed, the situation with grid line lines in multi-line equations is a little bit more complicated: in reality, *vertical* grid lines are *never* displayed in these. Currently LyX accepts their addition and shows them on the screen, but LaTeX doesn't show them. I think this is bad from a UI

Re: [Patch] Re: math madness with double underlining

2005-03-22 Thread Martin Vermeer
On Tue, Mar 22, 2005 at 08:25:10AM +0100, Georg Baum wrote: > Martin Vermeer wrote: ... > > Attached my slightly modified patch. > > Looks good. > > > Georg > Committed. - Martin pgpuJmZOELeyP.pgp Description: PGP signature

Re: [Patch] Re: math madness with double underlining

2005-03-21 Thread Georg Baum
Martin Vermeer wrote: > On Mon, Mar 21, 2005 at 08:52:30PM +0100, Andre Poenitz wrote: > >> So this indicates a bug in either doDispatch or getStatus in this area. >> The most nested inset should be asked first and thus gets a chance to >> give a definite answer first. If that does not happen auto

[Patch] Re: math madness with double underlining

2005-03-21 Thread Martin Vermeer
On Mon, Mar 21, 2005 at 08:52:30PM +0100, Andre Poenitz wrote: > On Mon, Mar 21, 2005 at 05:56:42PM +0200, Martin Vermeer wrote: > > > From my testing it appears that for a true grid inset (which may be > > nested inside an "untrue" one), control never even passes the > > MathHullInset getStatus

Re: math madness with double underlining

2005-03-21 Thread Martin Vermeer
On Mon, Mar 21, 2005 at 08:43:46PM +0100, Andre Poenitz wrote: > On Mon, Mar 21, 2005 at 01:54:34PM +0200, Martin Vermeer wrote: > > The problem is not that a MathGridInset would have only one row/col. The > > problem is that MathGridInset's getStatus gets called even for insets > > that in reality

Re: math madness with double underlining

2005-03-21 Thread Andre Poenitz
On Mon, Mar 21, 2005 at 09:16:24AM +0100, Georg Baum wrote: > Martin Vermeer wrote: > > > This is a real bug, and probably easy to fix. In math_gridinset's > > getStatus, there should be tests for nrows() <= 0 and ncols() <= 0 for > > the cases add-(h/v)line-(above|below), just like there are for

Re: math madness with double underlining

2005-03-21 Thread Andre Poenitz
On Mon, Mar 21, 2005 at 05:56:42PM +0200, Martin Vermeer wrote: > I believe that asGridInset will not return the right answer: it will > always return true if the inset is a MathGridInset in the C++ sense, > irrespective whether it is in the role of, e.g., an eqnarray. Indeed. > From my testing

Re: math madness with double underlining

2005-03-21 Thread Andre Poenitz
On Mon, Mar 21, 2005 at 01:54:34PM +0200, Martin Vermeer wrote: > The problem is not that a MathGridInset would have only one row/col. The > problem is that MathGridInset's getStatus gets called even for insets > that in reality are _not_ array-type insets. Every math inset is wrapped in a MathHul

Re: math madness with double underlining

2005-03-21 Thread Andre Poenitz
On Mon, Mar 21, 2005 at 03:36:15PM +0100, Georg Baum wrote: > There is one (btw for every math inset): Not for every one, only for these that need extra tweaking in some form or the other. Unfortunately there are quite a few of them. This is sort of "poor man's RTTI". > virtual MathGridInset

Re: math madness with double underlining

2005-03-21 Thread Georg Baum
Martin Vermeer wrote: > The problem is that MathGridInset is "abused" by MathHullInset to draw > grid-like display formulas of various kinds, which can do most of the > things a "true" gridinset can (like swapping two rows or columns) but > not everything. See the handling of rowChangeOK and colCh

Re: math madness with double underlining

2005-03-21 Thread Martin Vermeer
On Mon, 2005-03-21 at 16:36, Georg Baum wrote: > Martin Vermeer wrote: > > > The problem is not that a MathGridInset would have only one row/col. The > > problem is that MathGridInset's getStatus gets called even for insets > > that in reality are _not_ array-type insets. > > Do you know why? It

Re: math madness with double underlining

2005-03-21 Thread Georg Baum
Martin Vermeer wrote: > The problem is not that a MathGridInset would have only one row/col. The > problem is that MathGridInset's getStatus gets called even for insets > that in reality are _not_ array-type insets. Do you know why? It looks like my picture of this whole getStatus/dispatch mechan

Re: math madness with double underlining

2005-03-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> While you are at it: Shouldn't the other lfuns that exist in >> do_dispatch() be handled in getStatus(), too?. Martin> Only those that are connected to a menu entry or such, that Martin> should be greyed out. I think. No, all functi

Re: math madness with double underlining

2005-03-21 Thread Martin Vermeer
On Mon, 2005-03-21 at 10:16, Georg Baum wrote: > Martin Vermeer wrote: > > > This is a real bug, and probably easy to fix. In math_gridinset's > > getStatus, there should be tests for nrows() <= 0 and ncols() <= 0 for > > the cases add-(h/v)line-(above|below), just like there are for the > > other

Re: math madness with double underlining

2005-03-21 Thread Georg Baum
Martin Vermeer wrote: > This is a real bug, and probably easy to fix. In math_gridinset's > getStatus, there should be tests for nrows() <= 0 and ncols() <= 0 for > the cases add-(h/v)line-(above|below), just like there are for the > others. I thought that every MathGridInset has at least one row

Re: math madness with double underlining

2005-03-20 Thread Martin Vermeer
On Sun, 2005-03-20 at 23:58, Helge Hafting wrote: > On Sat, Mar 19, 2005 at 08:06:17AM +0100, Andre Poenitz wrote: > > On Fri, Mar 18, 2005 at 11:56:10PM +0100, Helge Hafting wrote: > > > On Fri, Mar 18, 2005 at 11:49:58PM +0100, Helge Hafting wrote: > > > > I have a table where the cells consist o

Re: math madness with double underlining

2005-03-20 Thread Helge Hafting
On Sat, Mar 19, 2005 at 08:06:17AM +0100, Andre Poenitz wrote: > On Fri, Mar 18, 2005 at 11:56:10PM +0100, Helge Hafting wrote: > > On Fri, Mar 18, 2005 at 11:49:58PM +0100, Helge Hafting wrote: > > > I have a table where the cells consist of single digits, > > > sometimes with an underbar or two.

Re: math madness with double underlining

2005-03-20 Thread Andre Poenitz
On Fri, Mar 18, 2005 at 11:56:10PM +0100, Helge Hafting wrote: > On Fri, Mar 18, 2005 at 11:49:58PM +0100, Helge Hafting wrote: > > I have a table where the cells consist of single digits, > > sometimes with an underbar or two. The ones that need > > one underbar use underlining of normal text. Th

Re: math madness with double underlining

2005-03-18 Thread Helge Hafting
On Fri, Mar 18, 2005 at 11:49:58PM +0100, Helge Hafting wrote: > I have a table where the cells consist of single digits, > sometimes with an underbar or two. The ones that need > one underbar use underlining of normal text. That works. > > Digits that need double underlining use mathed, and I u