Re: insetgraphicsParam

2002-04-08 Thread John Levon
On Mon, Apr 08, 2002 at 09:25:51AM +0200, Andre Poenitz wrote: > Pimpls do not come for free, either. In the case of LyX, the cost for > running times are certainly negligible, but then we have to ask ourself > also what benefit ES will give us. Pimpls make code navigation a real pain ... john

Re: insetgraphicsParam

2002-04-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Pimpls do not come for free, either. In the case of LyX, the cost for | running times are certainly negligible, but then we have to ask ourself | also what benefit ES will give us. being able to use exceptions? -- Lgb

Re: insetgraphicsParam

2002-04-08 Thread Andre Poenitz
On Fri, Apr 05, 2002 at 01:02:44PM +1000, Allan Rae wrote: > It would seem you are referring to: > http://www.gotw.ca/gotw/059.htm > as the obscure theory behind these arguements. > > At least now I can see a reason instead of just drug induced ravings. There is certainly something good in excep

Re: insetgraphicsParam

2002-04-04 Thread Allan Rae
It would seem you are referring to: http://www.gotw.ca/gotw/059.htm as the obscure theory behind these arguements. At least now I can see a reason instead of just drug induced ravings. Allan. (ARRae)

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Thursday 04 April 2002 2:52 pm, Lars Gullik Bjønnes wrote: >> ?? >> >> I wonder what kind of drug I am on today... >> >> I obviously mean exception safe. > | Talking of such (rather than about your medication), I bought Exceptional C++ | the other d

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Every now and then somebody adds a member to the class but not to swap. | No compiler warning possible. Been there, done that. Removed swap again | in most cases. Called it a 'obscure theory'. If you keep your class variables in a Pimpl, then it gets

Re: insetgraphicsParam

2002-04-04 Thread Andre Poenitz
On Thu, Apr 04, 2002 at 02:06:43PM +, Angus Leeming wrote: > Talking of such (rather than about your medication), I bought > Exceptional C++ the other day. I guess this is where you get your ideas > on this front from. > > I also bought Scott Meyer's Effective STL. It's bloody good! It's fa

Re: insetgraphicsParam

2002-04-04 Thread Angus Leeming
On Thursday 04 April 2002 2:52 pm, Lars Gullik Bjønnes wrote: > ?? > > I wonder what kind of drug I am on today... > > I obviously mean exception safe. Talking of such (rather than about your medication), I bought Exceptional C++ the other day. I guess this is where you get your ideas on this fr

Re: insetgraphicsParam

2002-04-04 Thread Andre Poenitz
On Thu, Apr 04, 2002 at 03:48:22PM +0200, Lars Gullik Bjønnes wrote: > | [Which is always a pain in the ass to maintain if you have a dozen members > | or so...] > > ... and if there are a lot of class variables then something is wrong > with the design... (I think I even heard you say that) >

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Andre Poenitz <[EMAIL PROTECTED]> writes: > | | On Thu, Apr 04, 2002 at 03:32:20PM +0200, Lars Gullik Bjønnes wrote: >>> Yes, you need to implement a non-throwing swap function, but then you >>> are typesafe. >> | | [Typesafe?] ?? | Yes typesafe?

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Apr 04, 2002 at 03:32:20PM +0200, Lars Gullik Bjønnes wrote: >> Yes, you need to implement a non-throwing swap function, but then you >> are typesafe. > | [Typesafe?] Yes typesafe? | [Which is always a pain in the ass to maintain if you have a

Re: insetgraphicsParam

2002-04-04 Thread Andre Poenitz
On Thu, Apr 04, 2002 at 03:32:20PM +0200, Lars Gullik Bjønnes wrote: > Yes, you need to implement a non-throwing swap function, but then you > are typesafe. [Typesafe?] [Which is always a pain in the ass to maintain if you have a dozen members or so...] What the heck is wrong with the auto-gene

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Thursday 04 April 2002 1:59 pm, Andre Poenitz wrote: >> What is >> >> void InsetGraphicsParams::copy(InsetGraphicsParams const & igp) >> >> good for? The auto-generated copy constructor would be fine, wouldn't it? I think init should be removed as

Re: insetgraphicsParam

2002-04-04 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | What is > | void InsetGraphicsParams::copy(InsetGraphicsParams const & igp) > | good for? The auto-generated copy constructor would be fine, wouldn't it? > This should change as well: InsetGraphicsParams & InsetGraphicsParams::operator=(InsetGraphics

Re: insetgraphicsParam

2002-04-04 Thread Angus Leeming
On Thursday 04 April 2002 1:59 pm, Andre Poenitz wrote: > What is > > void InsetGraphicsParams::copy(InsetGraphicsParams const & igp) > > good for? The auto-generated copy constructor would be fine, wouldn't it? > > Andre' Looks like you're right... Angus