Re: help needed with bug 3043

2007-05-07 Thread Jürgen Spitzmüller
Georg Baum wrote: > > Georg, where is this function supposed to be called? > > in validate() (therefore the hack with init() const and the mutable > members). The comment says it: > > +       // validate() should have been called before > +       BOOST_ASSERT(complete_); > + But Encoding does not

Re: help needed with bug 3043

2007-05-07 Thread Georg Baum
Jürgen Spitzmüller wrote: > The source for all those problems (including the assert, which is correct > and should be reenabled) is that Encoding::init() is _never_ called. I > guess Georg just overlooked that. It was called originally, but for some reason I don't know the call did not appear in

Re: help needed with bug 3043

2007-05-06 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > 1. open the file "armenian-article.lyx" from the examples > > 2. change the document layout from "article (armenian)" to "article" and > > save the file under a new name. > > 3. change the document language from Armenian to Korean > > > > -> Crash: > > This problem is more gene

Re: help needed with bug 3043

2007-05-06 Thread Uwe Stöhr
Uwe Stöhr schrieb: 1. open the file "armenian-article.lyx" from the examples 2. change the document layout from "article (armenian)" to "article" and save the file under a new name. 3. change the document language from Armenian to Korean -> Crash: This problem is more general and only appea

Re: help needed with bug 3043

2007-05-06 Thread Uwe Stöhr
After the commit, the unicodesymbols file is no longer correctly read. I've seen it too late. The unicodesymbols file itself is read, but not the second token with the command. So when you now create a new document and insert a €, or µ, or × character, you don't get \texteuro, \textmu, or \tex

Re: help needed with bug 3043

2007-05-06 Thread Uwe Stöhr
Can you list some examples (and what is to be output for those instead of babel)? OK, the babel stuff works now for me - had some wrong entries in my tree. As you all wanted that I commit it, I tested the patch again and put it in: http://www.lyx.org/trac/changeset/18216 While testing I foun

Re: help needed with bug 3043

2007-05-06 Thread José Matos
On Sunday 06 May 2007 10:24:10 Jürgen Spitzmüller wrote: > FWIW, I agree. But I guess this is José's call. Since this improves LyX I think that it should go in. Any remaining issues will/should be fixed afterwards. Proceed. > Jürgen -- José Abílio

Re: help needed with bug 3043

2007-05-06 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > There's one issue why I don't think this can be committed right now: > > babel is called every time because it is hardcoded in lyxrc.cpp. But babel > shouldn't or even mustn't be called for some languages. Can you list some examples (and what is to be output for those instead of

Re: help needed with bug 3043

2007-05-06 Thread Uwe Stöhr
>>Apart from that, the patch looks straightforward from a first glance, and it cleans up things >> significantly. >> >>It certainly needs some testing (especially wrt CJK and thailatex), but it looks like the >> right thing in general, from what I can judge. > > Then I suggest to commit

Re: help needed with bug 3043

2007-05-06 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Then I suggest to commit it. AFAIU the file format is not going to > change even if there's some errors in processing CJK. That's the only > way to move forward. FWIW, I agree. But I guess this is José's call. Jürgen

Re: help needed with bug 3043

2007-05-06 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: I found my mistakes now and updated the patch agian. But anyway, I need somebody who examines the patch and testers. A minor thing: Apart from that, the patch looks straightforward from a first glance, and it cleans up things significantly.

Re: help needed with bug 3043

2007-05-06 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > I found my mistakes now and updated the patch agian. But anyway, I need > > somebody who examines the patch and testers. > > A minor thing: Apart from that, the patch looks straightforward from a first glance, and it cleans up things significantly. It certainly need

Re: help needed with bug 3043

2007-05-06 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > I found my mistakes now and updated the patch agian. But anyway, I need > somebody who examines the patch and testers. A minor thing: # A plain utf8 encoding that does not use the inputenc package. # Such an encoding is required for XeTeX. -Encoding utf8-plain utf8-plain UTF-

Re: help needed with bug 3043

2007-05-05 Thread Abdelrazak Younes
Uwe Stöhr wrote: I wrote: Unfortunately I'm not good enough in C++ to get it to compile. I found my mistakes now and updated the patch agian. But anyway, I need somebody who examines the patch and testers. Please send it to the list. Hopefully some CJK developer will show an interest. A

Re: help needed with bug 3043

2007-05-05 Thread Uwe Stöhr
I wrote: Unfortunately I'm not good enough in C++ to get it to compile. I found my mistakes now and updated the patch agian. But anyway, I need somebody who examines the patch and testers. regards Uwe