Re: cursorup/down

2003-11-18 Thread Alfredo Braunstein
Andre Poenitz wrote: >> [another problem: we should set x_target in absolute coordinates, but >> we do it within LyXText, and LyXText doesn't kown it's own absolute >> x coords. Maybe it should?] > > Absolute document coordinates? Would be feasible. bv->text gets 0,0, the > rest could be compute

Re: cursorup/down

2003-11-18 Thread Andre Poenitz
On Tue, Nov 18, 2003 at 12:22:38PM +0100, Alfredo Braunstein wrote: > > Might be true... > > It was. > > This patch solves this, + some bv() -> true (except in moveUp/Down, where it > was set to false to allow entering insets) Good. > [another problem: we should set x_target in absolute coordin

Re: cursorup/down

2003-11-18 Thread Alfredo Braunstein
Andre Poenitz wrote: >> [I think that the problem with target_x_ is that it is updated *too >> [much*, >> and thus it is completely in-sync with the cursor (and thus useless). >> I'll have a look at it.] > > Might be true... It was. This patch solves this, + some bv() -> true (except in moveUp/

Re: cursorup/down

2003-11-18 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Mmm... but we don't use x_target_ at all IIUC. We simply return with > DISPATCHED_RIGHT/LEFT when exiting and inset. ugh: FINISHED_UP/DOWN Alfredo

Re: cursorup/down

2003-11-18 Thread Andre Poenitz
On Tue, Nov 18, 2003 at 10:01:35AM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Tue, Nov 18, 2003 at 09:19:16AM +0100, Alfredo Braunstein wrote: > >> - shouldn't these be handled by the BufferView? > > > > Maybe. I am not sure, though. > > > >> As opposed to right/left, they

Re: cursorup/down

2003-11-18 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Tue, Nov 18, 2003 at 09:19:16AM +0100, Alfredo Braunstein wrote: >> - shouldn't these be handled by the BufferView? > > Maybe. I am not sure, though. > >> As opposed to right/left, they (should/used to) ignore the document >> structure. > > Getting up/down (sort of) ri

Re: cursorup/down

2003-11-18 Thread Andre Poenitz
On Tue, Nov 18, 2003 at 09:19:16AM +0100, Alfredo Braunstein wrote: > - shouldn't these be handled by the BufferView? Maybe. I am not sure, though. > As opposed to right/left, they (should/used to) ignore the document > structure. Getting up/down (sort of) right was _the_ problem when glueing th