Re: The cursor is seriously broken..

2006-10-26 Thread Andre Poenitz
On Mon, Oct 23, 2006 at 05:57:26PM +0200, Abdelrazak Younes wrote: > Hi Andre, > > I just merged my tree with SVN and I see now big black blinking square > instead of the cursor. Anybody else seeing that? It's the new block cursor. Andre'

Re: The cursor is seriously broken..

2006-10-26 Thread Peter Kümmel
Edwin Leuven wrote: > Peter Kümmel wrote: >> Hope this helps a bit. > > not not really (wouldn't know where to get the correct cursor pos). > > and why does the proper cursor position get lost? Because the cachc has been cleared: void BufferView::updateMetrics(bool singlepar) { // FIXME

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Edwin Leuven wrote: John Levon wrote: On Thu, Oct 26, 2006 at 01:06:14PM +0200, Peter Kümmel wrote: Was this the bug Asger talked about ('Fix cursor trouble')? Possibly that selecting within an inset is broken? and: 1. when typing in math the cursor blinks before the math inset before

Re: The cursor is seriously broken..

2006-10-26 Thread Edwin Leuven
Peter Kümmel wrote: Hope this helps a bit. not not really (wouldn't know where to get the correct cursor pos). and why does the proper cursor position get lost?

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> To be fair too, I noticed this remotely first. There, the Jean-Marc> white background is visible during more than one second! I Jean-Marc> am not sure what would be causing that, since both machines Jean-Marc> are ~3G

Re: The cursor is seriously broken..

2006-10-26 Thread Peter Kümmel
Edwin Leuven wrote: > John Levon wrote: >> On Thu, Oct 26, 2006 at 01:06:14PM +0200, Peter Kümmel wrote: >> >>> Was this the bug Asger talked about ('Fix cursor trouble')? >> >> Possibly that selecting within an inset is broken? > > and: > > 1. when typing in math the cursor blinks before the mat

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Thursday 26 October 2006 3:02 pm, José Matos wrote: >> On Thursday 26 October 2006 2:15 pm, Jean-Marc Lasgouttes wrote: > >> Do other people see that, on linux in particular? >> >> Not here. :-) >> >> qt-4.2.1 in Fedora 6. José>

Re: The cursor is seriously broken..

2006-10-26 Thread José Matos
On Thursday 26 October 2006 3:02 pm, José Matos wrote: > On Thursday 26 October 2006 2:15 pm, Jean-Marc Lasgouttes wrote: > > Do other people see that, on linux in particular? > > Not here. :-) > > qt-4.2.1 in Fedora 6. To be fair, I see some kind of redrawing but it is so fast, that I would

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Of course if it wrong but the possibility is there (not my Abdelrazak> doing). What do you want me to do? Further clean up the Abdelrazak> BufferView and the Buffer? I'll do that in 1.6 ;-) Abdelrazak> When we do that

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, there is no more buffer, that is different. The Buffer Abdelrazak> pointer in BufferView was not properly set to zero when Abdelrazak> the Buffer was closed file was reloaded hence one the

Re: The cursor is seriously broken..

2006-10-26 Thread José Matos
On Thursday 26 October 2006 2:15 pm, Jean-Marc Lasgouttes wrote: > Do other people see that, on linux in particular? Not here. :-) qt-4.2.1 in Fedora 6. > JMarc -- José Abílio

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, there is no more buffer, that is different. The Buffer Abdelrazak> pointer in BufferView was not properly set to zero when Abdelrazak> the Buffer was closed file was reloaded hence one the Abdelrazak> crashes. Hav

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: What about removing the buffer from the lyxview, and reading from disk as with a new file? Abdelrazak> ??? This is what is done already in Abdelrazak> BufferView::loadLyXFile(). So, there is no more b

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> What about removing the buffer from the lyxview, and reading from >> disk as with a new file? Abdelrazak> ??? This is what is done already in Abdelrazak> BufferView::loadLyXFile(). So, there is no more bufferview concerning

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> This is very tricky and it was very hard to find. The Abdelrazak> problem is that GuiWorkArea::paintEvent() uses the Buffer Abdelrazak> before it is completely constructed. Buffer::pimpl is Abd

Re: The cursor is seriously broken..

2006-10-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> This is very tricky and it was very hard to find. The Abdelrazak> problem is that GuiWorkArea::paintEvent() uses the Buffer Abdelrazak> before it is completely constructed. Buffer::pimpl is Abdelrazak> still equal to 0

Re: The cursor is seriously broken..

2006-10-26 Thread Edwin Leuven
John Levon wrote: On Thu, Oct 26, 2006 at 01:06:14PM +0200, Peter Kümmel wrote: Was this the bug Asger talked about ('Fix cursor trouble')? Possibly that selecting within an inset is broken? and: 1. when typing in math the cursor blinks before the math inset before returning to the righ

Re: The cursor is seriously broken..

2006-10-26 Thread John Levon
On Thu, Oct 26, 2006 at 01:06:14PM +0200, Peter Kümmel wrote: > Was this the bug Asger talked about ('Fix cursor trouble')? Possibly that selecting within an inset is broken? john

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: What about this patch? Much better than what we have now! Shove it in... Done. Was this the bug Asger talked about ('Fix cursor trouble')? I don't think so. I guess he was talking about the big black square that served as cursor. I fixed that

Re: The cursor is seriously broken..

2006-10-26 Thread Peter Kümmel
Abdelrazak Younes wrote: >> >> What about this patch? > > Much better than what we have now! > > Shove it in... Done. Was this the bug Asger talked about ('Fix cursor trouble')? -- Peter Kümmel

Re: The cursor is seriously broken..

2006-10-26 Thread Abdelrazak Younes
Peter Kümmel wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: i think that the positioning of the cursor is nicer with the attached (moves it 2 pixels to the right...) Yep. I hesitated to do that but I think you're right for an immediate solutio

Re: The cursor is seriously broken..

2006-10-26 Thread Peter Kümmel
Edwin Leuven wrote: > Abdelrazak Younes wrote: >> Edwin Leuven wrote: >>> Abdelrazak Younes wrote: >>> i think that the positioning of the cursor is nicer with the attached >>> (moves it 2 pixels to the right...) >> >> Yep. I hesitated to do that but I think you're right for an immediate >> solutio

Re: The cursor is seriously broken..

2006-10-25 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: i think that the positioning of the cursor is nicer with the attached (moves it 2 pixels to the right...) Yep. I hesitated to do that but I think you're right for an immediate solution. In principle the BufferView (via Cur

Re: The cursor is seriously broken..

2006-10-25 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Edwin Leuven wrote: >> Abdelrazak Younes wrote: >>> I have just fixed that. Very simple... I should look at the code >>> before commenting... The former state was probably due to >>> temporary debugging state from Andr

Re: The cursor is seriously broken..

2006-10-25 Thread Abdelrazak Younes
Michael Gerz wrote: i think that the positioning of the cursor is nicer with the attached (moves it 2 pixels to the right...) - cursor_->setGeometry(x, y, 2, h); + cursor_->setGeometry(x + 2, y, 2, h); Indeed. Committed. As I said to Edwin, fixing the call would be better. A

Re: The cursor is seriously broken..

2006-10-25 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: I have just fixed that. Very simple... I should look at the code before commenting... The former state was probably due to temporary debugging state from Andre :-) i think that the positioning of the cursor is nicer with the attached (moves it 2 p

Re: The cursor is seriously broken..

2006-10-24 Thread Michael Gerz
i think that the positioning of the cursor is nicer with the attached (moves it 2 pixels to the right...) - cursor_->setGeometry(x, y, 2, h); + cursor_->setGeometry(x + 2, y, 2, h); Indeed. Committed. Michael

Re: The cursor is seriously broken..

2006-10-24 Thread Edwin Leuven
Abdelrazak Younes wrote: I have just fixed that. Very simple... I should look at the code before commenting... The former state was probably due to temporary debugging state from Andre :-) i think that the positioning of the cursor is nicer with the attached (moves it 2 pixels to the right...

Re: The cursor is seriously broken..

2006-10-24 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hi Andre, I just merged my tree with SVN and I see now big black blinking square instead of the cursor. Anybody else seeing that? I have just fixed that. Very simple... I should look at the code before commenting... The former state was probably due to temporary debu

Re: The cursor is seriously broken..

2006-10-23 Thread Asger Ottar Alstrup
Bo Peng wrote: On 10/23/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: I just merged my tree with SVN and I see now big black blinking square instead of the cursor. Anybody else seeing that? Yes. ugly, black, blinking stuff. André changed the cursor to become a new widget, rather than some

Re: The cursor is seriously broken..

2006-10-23 Thread Jonathan Vogt
Am Montag 23 Oktober 2006 18:29 schrieb Michael Gerz: > I see no cursor at all... me too Jonathan

Re: The cursor is seriously broken..

2006-10-23 Thread Bo Peng
On 10/23/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Hi Andre, I just merged my tree with SVN and I see now big black blinking square instead of the cursor. Anybody else seeing that? Yes. ugly, black, blinking stuff. Bo

Re: The cursor is seriously broken..

2006-10-23 Thread Michael Gerz
Abdelrazak Younes wrote: Hi Andre, I just merged my tree with SVN and I see now big black blinking square instead of the cursor. Anybody else seeing that? I see no cursor at all... Michael