Re: TextClassPtr Must Die

2008-02-26 Thread rgheck
Andre Poenitz wrote: On Tue, Feb 26, 2008 at 04:31:56PM -0500, rgheck wrote: - TextClassPtr newClass(TextClass const & baseClass); + DocumentClass * newClass(TextClass const & baseClass); I'd prefer a reference her... otherwise it somehow make me wonder whether ownership is

Re: TextClassPtr Must Die

2008-02-26 Thread Andre Poenitz
On Tue, Feb 26, 2008 at 04:31:56PM -0500, rgheck wrote: > - TextClassPtr newClass(TextClass const & baseClass); > + DocumentClass * newClass(TextClass const & baseClass); I'd prefer a reference her... otherwise it somehow make me wonder whether ownership is passed or not... > /// \r

Re: TextClassPtr

2008-02-22 Thread rgheck
Andre Poenitz wrote: On Fri, Feb 22, 2008 at 04:46:44PM -0500, rgheck wrote: Andre Poenitz wrote: Does anybody remember why we use a shared pointer and not an index into the global list of textclasses? Yes, that was my doing. So this is a recent change? A few months

Re: TextClassPtr

2008-02-22 Thread Andre Poenitz
On Fri, Feb 22, 2008 at 04:46:44PM -0500, rgheck wrote: > Andre Poenitz wrote: >> Does anybody remember why we use a shared pointer and not an index into >> the global list of textclasses? > > Yes, that was my doing. So this is a recent change? > It used to be a list of textclasses, when these we

Re: TextClassPtr

2008-02-22 Thread rgheck
Andre Poenitz wrote: Does anybody remember why we use a shared pointer and not an index into the global list of textclasses? Yes, that was my doing. It used to be a list of textclasses, when these were static objects. But now the textclasses that are in use are dynamic objects: They get cha