Re: Tests failing on recent master

2024-05-19 Thread Jürgen Spitzmüller
Am Sonntag, dem 19.05.2024 um 19:23 +0200 schrieb Jean-Marc Lasgouttes: > You are right. What happens is that, since ad6aa8ba4b9, > updateIndexes() > relies on is_long_tabular, but this boolean is initialized *after* > calling updateIndexes() in Tabular::init(). > > I could just put the initiali

Re: Tests failing on recent master

2024-05-19 Thread Jean-Marc Lasgouttes
Le 18/05/2024 à 17:45, Jürgen Spitzmüller a écrit : Am Samstag, dem 18.05.2024 um 16:28 +0200 schrieb Kornel Benko: How should I know? I am reacting to the output of valgrind only. I'd like to understand why the patch is needed. And why only for this boolean. Otherwise it seems just a shot in

Re: Tests failing on recent master

2024-05-18 Thread Jürgen Spitzmüller
Am Samstag, dem 18.05.2024 um 16:28 +0200 schrieb Kornel Benko: > How should I know? I am reacting to the output of > valgrind only. I'd like to understand why the patch is needed. And why only for this boolean. Otherwise it seems just a shot in the dark. -- Jürgen signature.asc Description: T

Re: Tests failing on recent master

2024-05-18 Thread Scott Kostyshak
On Sat, May 18, 2024 at 10:33:09AM GMT, Kornel Benko wrote: > Am Fri, 17 May 2024 13:18:44 -0400 > schrieb Scott Kostyshak : > > > On Fri, May 17, 2024 at 11:34:51AM GMT, Scott Kostyshak wrote: > > > On Fri, May 17, 2024 at 03:20:11PM GMT, Kornel Benko wrote: > > > > Am Fri, 17 May 2024 08:46:53

Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 15:09:44 +0200 schrieb "Jürgen Spitzmüller" : > Am Samstag, dem 18.05.2024 um 14:16 +0200 schrieb Kornel Benko: > > Am Sat, 18 May 2024 13:58:21 +0200 > > schrieb Jean-Marc Lasgouttes : > > > > > Le 18/05/2024 à 13:52, Kornel Benko a écrit : > > > > Test passes after the a

Re: Tests failing on recent master

2024-05-18 Thread Jürgen Spitzmüller
Am Samstag, dem 18.05.2024 um 14:16 +0200 schrieb Kornel Benko: > Am Sat, 18 May 2024 13:58:21 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 18/05/2024 à 13:52, Kornel Benko a écrit : > > > Test passes after the attached patch.  > > > > The patch looks good. Is this where other variables are >

Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 13:58:21 +0200 schrieb Jean-Marc Lasgouttes : > Le 18/05/2024 à 13:52, Kornel Benko a écrit : > > Test passes after the attached patch. > > The patch looks good. Is this where other variables are initialized, or > is it in the constructor here? > > JMarc > It is the cons

Re: Tests failing on recent master

2024-05-18 Thread Jean-Marc Lasgouttes
Le 18/05/2024 à 13:52, Kornel Benko a écrit : Test passes after the attached patch. The patch looks good. Is this where other variables are initialized, or is it in the constructor here? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 12:12:56 +0200 schrieb Kornel Benko : > Am Fri, 17 May 2024 15:21:10 +0200 > schrieb Kornel Benko : > > > > Did you try to run LyX under valgrind? It can be very useful in such > > > cases. > > > > Will try later ... now grandpa duties > > > > > JMarc > > > >

Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Fri, 17 May 2024 15:21:10 +0200 schrieb Kornel Benko : > > Did you try to run LyX under valgrind? It can be very useful in such cases. > > > > Will try later ... now grandpa duties > > > JMarc > > Kornel Ok there are plenty of errors. Using # valgrind --track-origins=yes

Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Fri, 17 May 2024 13:18:44 -0400 schrieb Scott Kostyshak : > On Fri, May 17, 2024 at 11:34:51AM GMT, Scott Kostyshak wrote: > > On Fri, May 17, 2024 at 03:20:11PM GMT, Kornel Benko wrote: > > > Am Fri, 17 May 2024 08:46:53 -0400 > > > schrieb Scott Kostyshak : > > > > > > > On Fri, May 17,

Re: Tests failing on recent master

2024-05-17 Thread Scott Kostyshak
On Fri, May 17, 2024 at 11:34:51AM GMT, Scott Kostyshak wrote: > On Fri, May 17, 2024 at 03:20:11PM GMT, Kornel Benko wrote: > > Am Fri, 17 May 2024 08:46:53 -0400 > > schrieb Scott Kostyshak : > > > > > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: > > > > > I get this warning only

Re: Tests failing on recent master

2024-05-17 Thread Scott Kostyshak
On Fri, May 17, 2024 at 03:20:11PM GMT, Kornel Benko wrote: > Am Fri, 17 May 2024 08:46:53 -0400 > schrieb Scott Kostyshak : > > > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: > > > I get this warning only if lyx is compiled with debugging enabled. > > > > g++ or clang? Which vers

Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 15:01:08 +0200 schrieb Jean-Marc Lasgouttes : > Le 17/05/2024 à 14:46, Scott Kostyshak a écrit : > > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: > >> Am Fri, 17 May 2024 05:57:27 +0200 > >> schrieb "Jürgen Spitzmüller" : > >> > >>> Am Donnerstag, dem 16.05.2

Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 08:46:53 -0400 schrieb Scott Kostyshak : > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: > > Am Fri, 17 May 2024 05:57:27 +0200 > > schrieb "Jürgen Spitzmüller" : > > > > > Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko: > > > > -- Error li

Re: Tests failing on recent master

2024-05-17 Thread Jean-Marc Lasgouttes
Le 17/05/2024 à 14:46, Scott Kostyshak a écrit : On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: Am Fri, 17 May 2024 05:57:27 +0200 schrieb "Jürgen Spitzmüller" : Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko: -- Error line = /usr2/src/lyx/lyx- git/src/insets/I

Re: Tests failing on recent master

2024-05-17 Thread Scott Kostyshak
On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote: > Am Fri, 17 May 2024 05:57:27 +0200 > schrieb "Jürgen Spitzmüller" : > > > Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko: > > > -- Error line = /usr2/src/lyx/lyx- > > > git/src/insets/InsetTabular.cpp:1070:51: runtime

Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 05:57:27 +0200 schrieb "Jürgen Spitzmüller" : > Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko: > > -- Error line = /usr2/src/lyx/lyx- > > git/src/insets/InsetTabular.cpp:1070:51: runtime > > error: load of value 110, which is not a valid value for type 'bool

Re: Tests failing on recent master

2024-05-16 Thread Jürgen Spitzmüller
Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko: > -- Error line = /usr2/src/lyx/lyx- > git/src/insets/InsetTabular.cpp:1070:51: runtime > error: load of value 110, which is not a valid value for type 'bool' > > Picky compiler ... Aha. I don't get what it is complaining about, t

Re: Tests failing on recent master

2024-05-16 Thread Kornel Benko
Am Thu, 16 May 2024 17:07:13 +0200 schrieb "Jürgen Spitzmüller" : > Am Donnerstag, dem 16.05.2024 um 10:54 +0200 schrieb Kornel Benko: > > With today's test, I get only ... > > export/doc/es/UserGuide_lyx23 (Failed) > > The export to these formats works well for me. What errors do you get? >

Re: Tests failing on recent master

2024-05-16 Thread Scott Kostyshak
On Thu, May 16, 2024 at 05:07:13PM GMT, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 16.05.2024 um 10:54 +0200 schrieb Kornel Benko: > > With today's test, I get only > > export/doc/es/UserGuide_lyx16 (Failed) > > export/doc/es/UserGuide_lyx20 (Failed) > > export/doc/es/UserGuide_lyx2

Re: Tests failing on recent master

2024-05-16 Thread Scott Kostyshak
On Thu, May 16, 2024 at 07:36:33AM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 15.05.2024 um 16:50 -0400 schrieb Scott Kostyshak: > > Bisect leads to: > > > > 207eaeee9071cb828a2ab7f4680f8ff92e379af8 is the first bad commit > > commit 207eaeee9071cb828a2ab7f4680f8ff92e379af8 > > Author: Juer

Re: Tests failing on recent master

2024-05-16 Thread Jürgen Spitzmüller
Am Donnerstag, dem 16.05.2024 um 10:54 +0200 schrieb Kornel Benko: > With today's test, I get only > export/doc/es/UserGuide_lyx16 (Failed) > export/doc/es/UserGuide_lyx20 (Failed) > export/doc/es/UserGuide_lyx21 (Failed) > export/doc/es/UserGuide_lyx22 (Failed) > expo

Re: Tests failing on recent master

2024-05-16 Thread Kornel Benko
Am Tue, 14 May 2024 19:29:53 -0400 schrieb Scott Kostyshak : > The following tests now fail (and used to pass not too long ago): > > export/export/latex/languages/supported-languages_babel_auto-legacy_dvi > (Failed) > export/export/latex/languages/supported-languages_babel_auto-legacy_pdf >

Re: Tests failing on recent master

2024-05-15 Thread Jürgen Spitzmüller
Am Mittwoch, dem 15.05.2024 um 16:50 -0400 schrieb Scott Kostyshak: > Bisect leads to: > > 207eaeee9071cb828a2ab7f4680f8ff92e379af8 is the first bad commit > commit 207eaeee9071cb828a2ab7f4680f8ff92e379af8 > Author: Juergen Spitzmueller > Date:   Sun May 12 07:52:16 2024 +0200 > >     Introduce

Re: Tests failing on recent master

2024-05-15 Thread Jürgen Spitzmüller
Am Donnerstag, dem 16.05.2024 um 06:24 +0200 schrieb Jürgen Spitzmüller: > Well, the iconv conversion error stems from the fact that the > encodings > of master and child differ (latin9 vs. utf8). This looks very wring. > Why is this? > > If I change the encoding of the master file to utf8, I get

Re: Tests failing on recent master

2024-05-15 Thread Jürgen Spitzmüller
Am Mittwoch, dem 15.05.2024 um 16:50 -0400 schrieb Scott Kostyshak: > > These are iconv conversion errors. Strange. > > Bisect leads to: Well, the iconv conversion error stems from the fact that the encodings of master and child differ (latin9 vs. utf8). This looks very wring. Why is this? If I

Re: Tests failing on recent master

2024-05-15 Thread Scott Kostyshak
On Wed, May 15, 2024 at 09:01:04PM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 15.05.2024 um 14:24 -0400 schrieb Scott Kostyshak: > > Yes the timeouts are gone now. The only remaining newly failing tests > > are the following: > > > >   export/export/latex/languages/supported-languages_babel

Re: Tests failing on recent master

2024-05-15 Thread Jürgen Spitzmüller
Am Mittwoch, dem 15.05.2024 um 14:24 -0400 schrieb Scott Kostyshak: > Yes the timeouts are gone now. The only remaining newly failing tests > are the following: > >   export/export/latex/languages/supported-languages_babel_auto- > legacy_dvi (Failed) >   export/export/latex/languages/supported-lan

Re: Tests failing on recent master

2024-05-15 Thread Scott Kostyshak
On Wed, May 15, 2024 at 06:37:18PM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 15.05.2024 um 11:05 -0400 schrieb Scott Kostyshak: > > And now tests are timing out. For example: > > > >   cd lib/doc && lyx -e lyx23x Additional.lyx > > > > Can anyone reproduce the issue with that command? >

Re: Tests failing on recent master

2024-05-15 Thread Jürgen Spitzmüller
Am Mittwoch, dem 15.05.2024 um 11:05 -0400 schrieb Scott Kostyshak: > And now tests are timing out. For example: > >   cd lib/doc && lyx -e lyx23x Additional.lyx > > Can anyone reproduce the issue with that command? Better now? (I don't have time to check myself, but I'll do so in a few days i

Re: Tests failing on recent master

2024-05-15 Thread Scott Kostyshak
On Tue, May 14, 2024 at 07:29:53PM GMT, Scott Kostyshak wrote: > The following tests now fail (and used to pass not too long ago): > > export/export/latex/languages/supported-languages_babel_auto-legacy_dvi > (Failed) > export/export/latex/languages/supported-languages_babel_auto-legacy_pdf