Re: State of the killqt4 branch

On Mon, 21 Nov 2022 at 09:34, Kornel Benko wrote: > Am Sun, 20 Nov 2022 21:12:56 +0100 > schrieb Jean-Marc Lasgouttes : > > > Dear all, > > > > I think I have done everything I can do on the branch (actually I just > > noticed a few remnants in config/, I will handle that). > > > > What remains t

Re: State of the killqt4 branch (Stephan?)

Le 24/11/2022 à 15:39, Scott Kostyshak a écrit : I haven't been following the conversation, but I would be OK if you want to merge to master now as long as it doesn't (knowingly) break compilation for anyone. Just make it clear in the merge commit message what is still left to be done. I did th

Re: State of the killqt4 branch (Stephan?)

Am 25.11.2022 um 00:55 schrieb Stephan Witt : > > Am 25.11.2022 um 00:29 schrieb Jean-Marc Lasgouttes : >> >> Le 25/11/2022 à 00:18, Stephan Witt a écrit : >>> This is a profiler run with Apple Instruments - I built the LyX binary for >>> profiling. >>> https://my.hidrive.com/share/6t6dr1c.4o >>

Re: State of the killqt4 branch (Stephan?)

Am 25.11.2022 um 00:29 schrieb Jean-Marc Lasgouttes : > > Le 25/11/2022 à 00:18, Stephan Witt a écrit : >> This is a profiler run with Apple Instruments - I built the LyX binary for >> profiling. >> https://my.hidrive.com/share/6t6dr1c.4o >> The experiment was to open the german tutorial and star

Re: State of the killqt4 branch (Stephan?)

Le 25/11/2022 à 00:18, Stephan Witt a écrit : This is a profiler run with Apple Instruments - I built the LyX binary for profiling. https://my.hidrive.com/share/6t6dr1c.4o The experiment was to open the german tutorial and start scrolling from top to bottom and back to top. The left side is

Re: State of the killqt4 branch (Stephan?)

Am 24.11.2022 um 17:32 schrieb Jean-Marc Lasgouttes : > > What would be great is to find the discussion that led to this change. I > tried a bit, but did not succeed. > > Yes scrolling around in user guide is not bad. > > Uncomment DISABLE_PMPROF at the start of the file and run with a release

Re: State of the killqt4 branch (Stephan?)

What would be great is to find the discussion that led to this change. I tried a bit, but did not succeed. Yes scrolling around in user guide is not bad. Uncomment DISABLE_PMPROF at the start of the file and run with a release or profile build. JMarc >> What would remain is the code in GuiF

Re: State of the killqt4 branch (Stephan?)

Am 24.11.2022 um 12:20 schrieb Jean-Marc Lasgouttes : > > Le 23/11/2022 à 22:41, Stephan Witt a écrit : >> I’m alive but not able to react right now. Sorry. >> This week I cannot spend enough time to dive into LyX issues. >> Next week I'll start with checkout of the branch and contribute code. >

Re: State of the killqt4 branch (Stephan?)

On Thu, Nov 24, 2022 at 12:20:43PM +0100, Jean-Marc Lasgouttes wrote: > Le 23/11/2022 à 22:41, Stephan Witt a écrit : > > I’m alive but not able to react right now. Sorry. > > > > This week I cannot spend enough time to dive into LyX issues. > > > > Next week I'll start with checkout of the branc

Re: State of the killqt4 branch (Stephan?)

Le 23/11/2022 à 22:41, Stephan Witt a écrit : I’m alive but not able to react right now. Sorry. This week I cannot spend enough time to dive into LyX issues. Next week I'll start with checkout of the branch and contribute code. If you are confident that you can have a look next week, then I'l

Re: State of the killqt4 branch (Stephan?)

Am 22.11.2022 um 17:21 schrieb Jean-Marc Lasgouttes : > > Le 20/11/2022 à 21:12, Jean-Marc Lasgouttes a écrit : >> Dear all, >> I think I have done everything I can do on the branch (actually I just >> noticed a few remnants in config/, I will handle that). > > Hello Stephan, > > Following the

Re: State of the killqt4 branch

Le 22/11/2022 à 18:53, Kornel Benko a écrit : Thanks to take care. Unclear how I missed it though ... git grep is my special ability :) Thanks for the quick fix. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: State of the killqt4 branch

Am Tue, 22 Nov 2022 17:25:47 +0100 schrieb Jean-Marc Lasgouttes : > Hi Kornel, > > Le 21/11/2022 à 09:33, Kornel Benko a écrit : > > development/cmake/modules/LyXPaths.cmake > > This is the Windows-part. Maybe Thibaut could have a look? > > Indeed. > > I see a couple things left that may be i

Re: State of the killqt4 branch

Hi Kornel, Le 21/11/2022 à 09:33, Kornel Benko a écrit : development/cmake/modules/LyXPaths.cmake This is the Windows-part. Maybe Thibaut could have a look? Indeed. I see a couple things left that may be in your ballpark: * development/cmake/modules/LyXMacros.cmake This refers to a QT4_GET_M

Re: State of the killqt4 branch (Stephan?)

Le 20/11/2022 à 21:12, Jean-Marc Lasgouttes a écrit : Dear all, I think I have done everything I can do on the branch (actually I just noticed a few remnants in config/, I will handle that). Hello Stephan, Following the heroic effort of Kornel, most of what remains needs the attention of St

Re: State of the killqt4 branch

Am Sun, 20 Nov 2022 21:12:56 +0100 schrieb Jean-Marc Lasgouttes : > Dear all, > > I think I have done everything I can do on the branch (actually I just > noticed a few remnants in config/, I will handle that). > > What remains to be done? Who can help? > > Kornel: there are still trace of Qt4

Re: State of the killqt4 branch

Le 20/11/2022 à 21:12, Jean-Marc Lasgouttes a écrit : Stephan: The last FIXME KILLQT4 in the source, to know whether we still need to cache QTextLayout objects in Qt/Mac. They are correctly cached by Qt on other platforms. I could not find the relevant discussion, but this change was done at