Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | I thnk that adding a couple of ? should do that. >> | // A valid environment variable is defined as >> | // $\{?[A-Za-z_][A-Za-z_0-9]*\}? >> | Do you agree? >> >> $\{?[[:alpha:]][[:word:]]*\}? >> >> bett

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Angus Leeming
On Friday 26 September 2003 10:03 am, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> I thnk that adding a couple of ? should do that. // A valid > Angus> environment variable is defined as // > Angus> $\{?[A-Za-z_][A-Za-z_0-9]*\}? Do you agree? >

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I thnk that adding a couple of ? should do that. // A valid Angus> environment variable is defined as // Angus> $\{?[A-Za-z_][A-Za-z_0-9]*\}? Do you agree? Does this really make sure that the {} match? It is probably good enough, t

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | I thnk that adding a couple of ? should do that. > | // A valid environment variable is defined as > | // $\{?[A-Za-z_][A-Za-z_0-9]*\}? > | Do you agree? > > $\{?[[:alpha:]][[:word:]]*\}? > > better? I have to admit that I am not familiar with thes

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Angus Leeming <[EMAIL PROTECTED]> writes: > | | I thnk that adding a couple of ? should do that. | | // A valid environment variable is defined as | | // $\{?[A-Za-z_][A-Za-z_0-9]*\}? | | Do you agree? > | $\{?[[:alpha:]][[:word:]]

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | I thnk that adding a couple of ? should do that. | // A valid environment variable is defined as | // $\{?[A-Za-z_][A-Za-z_0-9]*\}? | Do you agree? $\{?[[:alpha:]][[:word:]]*\}? better? http://www.boost.org/libs/regex/syntax.htm#synta

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > This is very nice. The only possible improvement would be to allow the > omission of curly brackets in cases where there is no ambiguity. > > That would mean that, beside this case: > + // A valid environment variable is defined as > + // $\{[A-Za-z_][A-Za-z_0

Re: Rewrite of ReplaceEnvironmentPath

2003-09-26 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I've rewritten ReplaceEnvironmentPath in a sane manner and got Angus> rid of lstrings.[Ch] regexMatch because nothing was using it. This is very nice. The only possible improvement would be to allow the omission of curly brackets i

Re: Rewrite of ReplaceEnvironmentPath

2003-09-25 Thread Angus Leeming
Angus Leeming wrote: > I have committed this. Please report any failures. (Don't worry, I didn't commit lib/external_templates which somehow made its way into the diff.) -- Angus