Re: Question about Patch submission and commit

2006-03-20 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Of course, if you're worried about the redundancy of the second Angus> test for functions that *do* have a return type, you could Angus> write the above as: I am not worried about anything, as long as it works. Thanks. JMarc

Re: Question about Patch submission and commit

2006-03-20 Thread Angus Leeming
Jean-Marc Lasgouttes writes: >>> It works pretty well, except that I need the following trivial >>> patch to see the function name: >>> -s/[^ ]\{1,\} *// +s/[^ ]\{1,\} +// > Angus> Interesting. I take it you were matching too much stuff? > Yes. I attach the offending patch. Ahhh. I didn't think

Re: Question about Patch submission and commit

2006-03-20 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> It works pretty well, except that I need the following trivial >> patch to see the function name: >> -s/[^ ]\{1,\} *// +s/[^ ]\{1,\} +// Angus> Interesting. I take it you were ma

Re: Question about Patch submission and commit

2006-03-20 Thread Angus Leeming
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > It works pretty well, except that I need the following trivial patch > to see the function name: > -s/[^ ]\{1,\} *// > +s/[^ ]\{1,\} +// Interesting. I take it you were matching too much stuff? If you're going to use "+", then that may as well b

Re: Question about Patch submission and commit

2006-03-20 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Martin Vermeer wrote: >> svndiff='svn diff --diff-cmd /usr/bin/diff -x -up' alias >> grepfunc='egrep \(Index:\|^@@\)' Angus> $ svndiff -r 13397 > svndiff.txt $ sh svndiff.sh svndiff.txt It works pretty well, except that I need the

Re: Question about Patch submission and commit

2006-03-16 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Martin Vermeer <[EMAIL PROTECTED]> writes: | > On Thu, Mar 16, 2006 at 03:55:06PM +, Angus Leeming wrote: | > > Martin Vermeer wrote: | > > > svndiff='svn diff --diff-cmd /usr/bin/diff -x -up' | > > > alias grepfunc='egrep \(Index:\|^\)' | > > |

Re: Question about Patch submission and commit

2006-03-16 Thread Angus Leeming
Martin Vermeer <[EMAIL PROTECTED]> writes: > On Thu, Mar 16, 2006 at 03:55:06PM +, Angus Leeming wrote: > > Martin Vermeer wrote: > > > svndiff='svn diff --diff-cmd /usr/bin/diff -x -up' > > > alias grepfunc='egrep \(Index:\|^\)' > > > > $ svndiff -r 13397 > svndiff.txt > > $ sh svndiff.sh

Re: Question about Patch submission and commit

2006-03-16 Thread Martin Vermeer
On Thu, Mar 16, 2006 at 03:55:06PM +, Angus Leeming wrote: > Martin Vermeer wrote: > > svndiff='svn diff --diff-cmd /usr/bin/diff -x -up' > > alias grepfunc='egrep \(Index:\|^@@\)' > > $ svndiff -r 13397 > svndiff.txt > $ sh svndiff.sh svndiff.txt Cool! How to integrate this into the commit

Re: Question about Patch submission and commit

2006-03-16 Thread Angus Leeming
Martin Vermeer wrote: > svndiff='svn diff --diff-cmd /usr/bin/diff -x -up' > alias grepfunc='egrep \(Index:\|^@@\)' $ svndiff -r 13397 > svndiff.txt $ sh svndiff.sh svndiff.txt Regards, -- Angus svndiff.sh Description: application/shellscript

Re: Question about Patch submission and commit

2006-03-16 Thread Martin Vermeer
On Thu, Mar 16, 2006 at 02:35:17PM +, Angus Leeming wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > Is there a way to automate the commit message editing process in such a > > way that the user can easily add this info to the list of files? I.e., > > the guard protecting the file list s

Re: Question about Patch submission and commit

2006-03-16 Thread Angus Leeming
Martin Vermeer <[EMAIL PROTECTED]> writes: > Is there a way to automate the commit message editing process in such a > way that the user can easily add this info to the list of files? I.e., > the guard protecting the file list should be removed and some smaller > format conversions to make it chang

Re: Question about Patch submission and commit

2006-03-16 Thread Martin Vermeer
On Thu, Mar 16, 2006 at 02:49:11PM +0100, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: > | > Lars Gullik Bjønnes a écrit : > | > > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? > | > | > I guess un

Re: Question about Patch submission and commit

2006-03-16 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes a écrit : | > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? | | I guess unless someone decide there would be no decision. | | So? I'd like to at least convince Jean-Marc that

Re: Question about Patch submission and commit

2006-03-16 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I'd like to at least convince Jean-Marc that this is a good Lars> idea. But I guess to be able to do that, the rest of you have to Lars> help. Create nice commit messages so that J-M understands that Lars> this will give just wh

Re: Question about Patch submission and commit

2006-03-16 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes a écrit : | > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? | | I guess unless someone decide there would be no decision. | | So? I'd like to at least convince Jean-Marc that this is a good idea. But I guess

Re: Question about Patch submission and commit

2006-03-16 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Lars Gullik Bjønnes a écrit : | > > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? | | > I guess unless someone decide there would be no decision. | > So? | | I don't hear anybody s

Re: Question about Patch submission and commit

2006-03-16 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Lars Gullik Bjønnes a écrit : > > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? > I guess unless someone decide there would be no decision. > So? I don't hear anybody speaking up for ChangeLogs. Just do it and move on :) Angus

Re: Question about Patch submission and commit

2006-03-16 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : btw. did we come to any consensus about my "Drop ChangeLogs" RFC? I guess unless someone decide there would be no decision. So?

Re: Question about Patch submission and commit

2006-03-15 Thread Georg Baum
Am Mittwoch, 15. März 2006 15:56 schrieb Lars Gullik Bjønnes: > I'll setup both a viewvc and a trac so that we can try them both out. Great! Georg

Re: Question about Patch submission and commit

2006-03-15 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> In this case that would be enough. | | Lars> One thing the ChangeLog format has that is usefule is mentioning | Lars> the function where the change took place. | | Defini

Re: Question about Patch submission and commit

2006-03-15 Thread Martin Vermeer
On Wed, Mar 15, 2006 at 03:09:56PM +0100, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: ... > | Even that is overkill: svn log -v gives output like > | > | > | r13311 | baum | 2006-03-07 12:02:07

Re: Question about Patch submission and commit

2006-03-15 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> In this case that would be enough. Lars> One thing the ChangeLog format has that is usefule is mentioning Lars> the function where the change took place. Definitely that part I like most. Lars> But, yes, a tiny bit of effort

Re: Question about Patch submission and commit

2006-03-15 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, Mar 15, 2006 at 02:41:33PM +0200, Martin Vermeer wrote: | > On Wed, Mar 15, 2006 at 12:57:24PM +0100, Lars Gullik Bjønnes wrote: | > > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > > | > > | Hello, | > > | | > > | I have a tendency to comm

Re: Question about Patch submission and commit

2006-03-15 Thread Georg Baum
Lars Gullik Bjønnes wrote: > btw. did we come to any consensus about my "Drop ChangeLogs" RFC? I don't care too much about ChangeLog <-> log message, but I think we should do it uniformly (I don't want to look both in ChangeLogs and svn log). Georg

Re: Question about Patch submission and commit

2006-03-15 Thread Martin Vermeer
On Wed, Mar 15, 2006 at 02:41:33PM +0200, Martin Vermeer wrote: > On Wed, Mar 15, 2006 at 12:57:24PM +0100, Lars Gullik Bjønnes wrote: > > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > > | Hello, > > | > > | I have a tendency to commit very often... but this double-changelogs > > | and mail

Re: Question about Patch submission and commit

2006-03-15 Thread Martin Vermeer
On Wed, Mar 15, 2006 at 12:57:24PM +0100, Lars Gullik Bjønnes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > | Hello, > | > | I have a tendency to commit very often... but this double-changelogs > | and mail to lyx-devel is fastidious. > > Agree. > > btw. did we come to any consensu

Re: Question about Patch submission and commit

2006-03-15 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | I have a tendency to commit very often... but this double-changelogs | and mail to lyx-devel is fastidious. Agree. btw. did we come to any consensus about my "Drop ChangeLogs" RFC? | Is it OK if I don't respect the | rule for simple pa