Re: Qt toolbar prettiness

2005-09-12 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: Fine. The patches are saved for Angus> posterity at http://bugzilla.lyx.org/show_bug.cgi?id=2013 >> I thought a bit more about it at lunch, and I think we'd better >> not try to change what is basically

Re: Qt toolbar prettiness

2005-09-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Fine. The patches are saved for posterity at > Angus> http://bugzilla.lyx.org/show_bug.cgi?id=2013 > > I thought a bit more about it at lunch, and I think we'd better not > try to change what is basically a Qt design choice. It may even be > that the behaviour

Re: Qt toolbar prettiness

2005-09-09 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Fine. The patches are saved for posterity at Angus> http://bugzilla.lyx.org/show_bug.cgi?id=2013 I thought a bit more about it at lunch, and I think we'd better not try to change what is basically a Qt design choice. It may even be

Re: Qt toolbar prettiness

2005-09-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Jean-Marc, any objection to me committing the attached code to > Angus> both repositories? > > I am not sure that windows and OSX use these stretched toolbars. > Actually, I am almost sure that OSX does not. So this should probably > only be done for X11. > >

Re: Qt toolbar prettiness

2005-09-09 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Vladimir Prus wrote: >> I attach the complete source, maybe that will help. Angus> Fantastic! Thanks, Volodya. It works perfectly. Angus> Jean-Marc, any objection to me committing the attached code to Angus> both repositories? I

Re: Qt toolbar prettiness

2005-09-09 Thread Angus Leeming
Vladimir Prus wrote: > I attach the complete source, maybe that will help. Fantastic! Thanks, Volodya. It works perfectly. Jean-Marc, any objection to me committing the attached code to both repositories? -- AngusIndex: status.13x

Re: Qt toolbar prettiness

2005-09-09 Thread Vladimir Prus
Vladimir Prus wrote: > As another try, using > > toolbar->boxLayout()->addStrech() > > fails to work in two ways: > > - stretch is added *before* buttons > - the toolbar is not resized to full width. > > The thing I hate about Qt is that sometimes things just don't work and > it's extra

Re: Qt toolbar prettiness

2005-09-09 Thread Vladimir Prus
Angus Leeming wrote: >> Looks like your approach is the only one. > > Thanks, Volodya. Another alternative would be: > > #if 1 > // tb = new QToolButton(toolbar, ""); > // tb->setEnabled(false); > toolbar->setStretchableWidget(tb); > #endif > > Ie, make the final "real" widget

Re: Qt toolbar prettiness

2005-09-08 Thread Angus Leeming
Vladimir Prus wrote: >>> Personally, I'm quite comfortable with this small extra spacer. Are >>> you? >> >> Maybe, you can just copy-paste KDE code? >> >>void KToolBar::setFullSize(bool flag ) >>{ >> setHorizontalStretchable( flag ); >> setVerticalStretchable( flag ); >>}

Re: Qt toolbar prettiness

2005-09-08 Thread Vladimir Prus
Vladimir Prus wrote: >> Personally, I'm quite comfortable with this small extra spacer. Are >> you? > > Maybe, you can just copy-paste KDE code? > >void KToolBar::setFullSize(bool flag ) >{ > setHorizontalStretchable( flag ); > setVerticalStretchable( flag ); >} Oops, r

Re: Qt toolbar prettiness

2005-09-08 Thread Vladimir Prus
Angus Leeming wrote: > Jean-Marc Lasgouttes wrote: >> Angus> Here's the (much simpler) patch for 1.4 too. > >> What happens when two toolbars are put on the same line? How does >> the filler behave? > > It appears to create a small, but non-zero spacer. Try the attached, > changing the "#if 0" t

Re: Qt toolbar prettiness

2005-09-08 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Here's the (much simpler) patch for 1.4 too. > What happens when two toolbars are put on the same line? How does > the filler behave? It appears to create a small, but non-zero spacer. Try the attached, changing the "#if 0" to "#if 1" to see the difference.

Re: Qt toolbar prettiness

2005-09-08 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Here's the (much simpler) patch for 1.4 too. What happens when two toolbars are put on the same line? How does the filler behave? JMarc

Re: Qt toolbar prettiness

2005-09-07 Thread Angus Leeming
John Levon wrote: >> The attached patch implements this for LyX 1.3.x. Thoughts? > What happens if the real widgets extend right to the edge already? > You don't get the ">>" thing do you? If not, fine. Good point. I'll go ask on the Qt devel list what the recognised way to do this is and whether

Re: Qt toolbar prettiness

2005-09-07 Thread John Levon
On Wed, Sep 07, 2005 at 09:46:00AM +0100, Angus Leeming wrote: > The attached patch implements this for LyX 1.3.x. Thoughts? What happens if the real widgets extend right to the edge already? You don't get the ">>" thing do you? If not, fine. regards john

Re: Qt toolbar prettiness

2005-09-07 Thread Angus Leeming
Angus Leeming wrote: > The toolbars in KDE apps all extend to the end of the line. LyX's are cut > short and the result has always looked a little ugly to me. I've been > writing some Qt code here and have discovered that one way to create the > KDE-style toolbar is to add an empty, but stretchabl